Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some of the tests broken with Java17 #3550

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

pjfanning
Copy link
Member

@pjfanning pjfanning commented Jul 27, 2022

Relates to #3469

The remaining broken tests are related to java.lang.Record

The pom change is borrowed from #3549 (thanks to @sigpwned) - seems best to grab the pom change while rest of the PR is discussed.

See #3549 (comment) for list of broken tests (ones not fixed by this change - this change fixes about a dozen other test failures).

#3102 seems to be the issue that is breaking the Record tests. According to this medium article, this reflection support was hardened in Java 15. So the reflection field setter might have worked in Java 14 but has been broken since.

@cowtowncoder cowtowncoder merged commit 75c5cb8 into FasterXML:2.14 Jul 27, 2022
@cowtowncoder
Copy link
Member

Thank you! I'll manually merge this to master as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants