Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some tests fail or error when run with java 17 #3469

Closed
pjfanning opened this issue Apr 25, 2022 · 3 comments
Closed

some tests fail or error when run with java 17 #3469

pjfanning opened this issue Apr 25, 2022 · 3 comments

Comments

@pjfanning
Copy link
Member

pjfanning commented Apr 25, 2022

Describe the bug
https://github.com/FasterXML/jackson-databind/runs/6166440881?check_suite_focus=true

seems to be related to JPM (Jigsaw) rules

Jackson 2.14 branch

@pjfanning pjfanning added the to-evaluate Issue that has been received but not yet evaluated label Apr 25, 2022
@pjfanning pjfanning changed the title 19 tests fail or error when run with java 17 some tests fail or error when run with java 17 Nov 30, 2022
@pjfanning
Copy link
Member Author

@cowtowncoder

There are still a few Record tests that fail with Java 17.
There are even more tests that fail with Java 19.

[ERROR]   ArrayDelegatorCreatorForCollectionTest.testUnmodifiable:31 » InvalidDefinition
[ERROR]   MapEntryFormatTest.testDefaultShapeOverride:181 » InvalidDefinition Invalid ty...
[ERROR]   AccessFixTest.testCauseOfThrowableIgnoral:31 » UnsupportedOperation The Securi...
[ERROR]   MixinForCreators2795Test.testMixinWithUnmmodifiableCollection:32 » InvalidDefinition
[ERROR]   TestTypeFactoryWithClassLoader.testCallingOnlyWithClassLoaderGivesExpectedResults » InaccessibleObject
[ERROR]   TestTypeFactoryWithClassLoader.testCallingOnlyWithModifierGivesExpectedResults » InaccessibleObject
[ERROR]   TestTypeFactoryWithClassLoader.testDefaultTypeFactoryNotAffectedByWithConstructors » InaccessibleObject
[ERROR]   TestTypeFactoryWithClassLoader.testSetsTheCorrectClassLoderIfUsingWithClassLoaderFollowedByWithModifier » InaccessibleObject
[ERROR]   TestTypeFactoryWithClassLoader.testSetsTheCorrectClassLoderIfUsingWithModifierFollowedByWithClassLoader » InaccessibleObject
[ERROR]   TestTypeFactoryWithClassLoader.testThreadContextClassLoaderIsUsedIfNotUsingWithClassLoader » InaccessibleObject
[ERROR]   TestTypeFactoryWithClassLoader.testUsesCorrectClassLoaderWhenThreadClassLoaderIsNotNull » InaccessibleObject
[ERROR]   TestTypeFactoryWithClassLoader.testUsesCorrectClassLoaderWhenThreadClassLoaderIsNull » InaccessibleObject
[ERROR]   TestTypeFactoryWithClassLoader.testUsesFallBackClassLoaderIfNoThreadClassLoaderAndNoWithClassLoader » InaccessibleObject
[ERROR]   ClassUtilTest.testFindEnumMapTypeJDK:229 » IllegalState Cannot figure out type...
[ERROR]   ClassUtilTest.testFindEnumSetTypeJDK:223 » IllegalState Cannot figure out type...

@cowtowncoder
Copy link
Member

Yes. I am not 100% sure what to do here, mostly because these issues require introspection rewrite -- something I do hope to tackle now, for 2.15, but something that will take a while.
One possibility would be to just either remove these, or move under failing, for time being, and rely on jackson-integration-tests (or the other one(s)... jackson-jdk17-compat-test).

I think I'll try moving tests to failing under existing dir, try to get us a green build.
Thank you for reminder.

@cowtowncoder cowtowncoder added 2.14 and removed to-evaluate Issue that has been received but not yet evaluated labels Dec 1, 2022
@cowtowncoder
Copy link
Member

Fixed; enabled jdk17 on CI as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants