Merge pull request AdaptiveConsulting#2289 from AdaptiveConsulting/ch…

…ore/5587-update-playwright-1.38.1

chore: Update playwright from 1.37 > 1.38

.github/workflows/pull.yml

@@ -188,7 +188,7 @@ jobs:
         with:
           node-version: 20.5.1
 
-      - name: Install dependencies
+      - name: Install
         run: npm ci
 
       - name: start openfin
@@ -218,7 +218,7 @@ jobs:
         with:
           node-version: 20.5.1
 
-      - name: Install dependencies
+      - name: Install
         run: npm ci
 
       - name: start openfin

packages/client/e2e/fixtures.ts

@@ -1,6 +1,5 @@
-import { test as base } from "@playwright/test"
+import { chromium, Page, test as base } from "@playwright/test"
 import * as dotenv from "dotenv"
-import { chromium, Page } from "playwright"
 
 import { OPENFIN_PROJECT_NAME } from "./utils"
 

packages/client/e2e/fx.spec.ts

@@ -1,5 +1,4 @@
-import { expect, selectors } from "@playwright/test"
-import { Page } from "playwright"
+import { expect, Page, selectors } from "@playwright/test"
 
 import { test } from "./fixtures"
 import { OPENFIN_PROJECT_NAME } from "./utils"
@@ -34,7 +33,6 @@ test.describe("Fx App", () => {
 
     test.skip(testInfo.project.name !== OPENFIN_PROJECT_NAME)
 
-
     const popOutButtons = mainWindow.getByTitle("open in new window")
     const toggleLock = mainWindow.getByTitle("toggle layout lock")
 
@@ -60,7 +58,7 @@ test.describe("Fx App", () => {
 
     await expect(mainWindow.locator("text=Live Rates")).toBeVisible()
     expect(poppedOutLiveRatesPage.isClosed()).toBeTruthy()
-    
+
     await poppedOutBlotterPage
       .locator("[data-qa='openfin-chrome__close']")
       .click()

packages/client/e2e/limit-checker.spec.ts

@@ -1,4 +1,4 @@
-import { Page } from "playwright"
+import { Page } from "@playwright/test"
 
 import { test } from "./fixtures"
 import { assertGridCell, assertGridRow, OPENFIN_PROJECT_NAME, Timeout } from "./utils"

packages/client/e2e/utils.ts

@@ -1,11 +1,10 @@
-import { expect } from "@playwright/test"
-import { Locator } from "playwright"
+import { expect, Locator } from "@playwright/test"
 
 export const OPENFIN_PROJECT_NAME = "openfin"
 export enum Timeout {
   AGGRESSIVE = 5000,
   NORMAL = 10000,
-  LONG = 20000
+  LONG = 20000,
 }
 
 export const assertGridRow = async ({