chore: Update playwright from 1.37 > 1.38 #2289
Conversation
stephan-thibodeau
changed the title
stephan-thibodeau
force-pushed
the
chore/5587-update-playwright-1.38.1
branch
from
d6c7171 to
488b1bf
Compare
stephan-thibodeau
force-pushed
the
chore/5587-update-playwright-1.38.1
branch
from
488b1bf to
893f2af
Compare
|
(auto-deploy) A deployment has been created for this Pull Request Preview linksAs part of the code review process, please ensure that you test against the following
PerformancePlease ensure that this PR does not degrade the performance of the UI. We should maintain a performance score of 95+. |
.github/workflows/e2e-full.yml
Outdated
| run: npm ci | ||
| run: | | ||
| npm ci | ||
| npx playwright install --with-deps chromium |
There was a problem hiding this comment.
installing chromium only when required
There was a problem hiding this comment.
I am doubtful about installing browsers .. we have not needed to do that previously (unless it was happening behind the scenes somehow). Can we start with lowest touch approach, and refine from there i.e. what is the minimum setup required to complete the tests.
Also - what version of Chromium??
There was a problem hiding this comment.
see https://playwright.dev/docs/browsers#google-chrome--microsoft-edge
we can run against the Chrome that is surely available on CI .. let's try it at least
certainly should not be installing every time we run a job (surely?)
.github/workflows/e2e-full.yml
Outdated
| run: npm ci | ||
| run: | | ||
| npm ci | ||
| npx playwright install --with-deps chromium |
There was a problem hiding this comment.
I am doubtful about installing browsers .. we have not needed to do that previously (unless it was happening behind the scenes somehow). Can we start with lowest touch approach, and refine from there i.e. what is the minimum setup required to complete the tests.
Also - what version of Chromium??
packages/client/README.md
Outdated
| @@ -192,6 +192,12 @@ There seems to be some issues with storybook cache on some machines, we can solv | |||
|
|
|||
| How to run e2e tests against the web | |||
|
|
|||
| Install chromium if not already installed | |||
There was a problem hiding this comment.
I don't think this should be mandatory when running locally .. we will already have browser installations as web developers. This is making me think we should have regular tests against Firefox too, just to mix it up a bit.
stephan-thibodeau
force-pushed
the
chore/5587-update-playwright-1.38.1
branch
from
494ea85 to
8394f2b
Compare
stephan-thibodeau
force-pushed
the
chore/5587-update-playwright-1.38.1
branch
from
cafa6cf to
07a9707
Compare
stephan-thibodeau
force-pushed
the
chore/5587-update-playwright-1.38.1
branch
from
07a9707 to
cb57c9c
Compare
Updated playwright from
1.37.1>1.38.11.38.1requires to explicitly install required browsers. I've updated the specific ci workflows to downloadchromiumprior to run the testplaywrightdev-dependency and migrate import usage to@playwright/testREADMEto explicitly mention the need to installchromiumif it never been installedTested locally for both web and openfin ✅