update playwright to 1.38.1 and setup workflow to download chromium

AdaptiveConsulting · Sep 26, 2023 · 893f2af · 893f2af
1 parent 9267e1b
commit 893f2af
Show file tree

Hide file tree

Showing 6 changed files with 57 additions and 294 deletions.
diff --git a/.github/workflows/e2e-full.yml b/.github/workflows/e2e-full.yml
@@ -25,7 +25,9 @@ jobs:
           node-version: 20
 
       - name: Install
-        run: npm ci
+        run: |
+          npm ci 
+          npx playwright install --with-deps chromium
 
       - name: Test
         env:

diff --git a/.github/workflows/e2e-smoke.yml b/.github/workflows/e2e-smoke.yml
@@ -25,7 +25,9 @@ jobs:
           node-version: 20
 
       - name: Install
-        run: npm ci
+        run: |
+          npm ci 
+          npx playwright install --with-deps chromium
 
       - name: Test
         env:

diff --git a/.github/workflows/pull.yml b/.github/workflows/pull.yml
@@ -161,7 +161,9 @@ jobs:
           node-version: 20
 
       - name: Install
-        run: npm ci
+        run: |
+          npm ci 
+          npx playwright install --with-deps chromium
 
       - name: Test
         env:
@@ -188,8 +190,10 @@ jobs:
         with:
           node-version: 20.5.1
 
-      - name: Install dependencies
-        run: npm ci
+      - name: Install
+        run: |
+          npm ci 
+          npx playwright install --with-deps chromium
 
       - name: start openfin
         run: npm run _e2e:openfin:run --manifest_url=https://openfin.env.reactivetrader.com/pull/${{ github.event.number }}/config/rt-fx.json
@@ -218,8 +222,10 @@ jobs:
         with:
           node-version: 20.5.1
 
-      - name: Install dependencies
-        run: npm ci
+      - name: Install
+        run: |
+          npm ci 
+          npx playwright install --with-deps chromium
 
       - name: start openfin
         run: npm run _e2e:openfin:run --manifest_url=https://openfin.env.reactivetrader.com/pull/${{ github.event.number }}/config/rt-credit.json

diff --git a/packages/client/README.md b/packages/client/README.md
@@ -192,6 +192,12 @@ There seems to be some issues with storybook cache on some machines, we can solv
 
 How to run e2e tests against the web
 
+Install chromium if not already installed
+
+```sh
+npx playwright install --with-deps chromium
+```
+
 ```sh
 npm start
 ```
@@ -204,6 +210,12 @@ arguments: --headed (launches a browser visible to the user) and --workers=1 to
 
 How to run e2e tests against openfin
 
+Install chromium if not already installed
+
+```sh
+npx playwright install --with-deps chromium
+```
+
 ```sh
 npm run openfin:dev
 npm run openfin:start:launcher