Tracker optimize gen #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e connecting as (with plans to cache those so it won't gen the same world+slot data more than once) and adds a framework so all worlds that will need to regen can be skipped from the multiworld gen'd at launch note: this will break UT for worlds that still use old options API, but those are soon disappearing so I don't care as much
…was necessary anymore
…it retries it doesn't crash on frozen installs (where it doesn't exist) (ArchipelagoMW#16)
…e connecting as (with plans to cache those so it won't gen the same world+slot data more than once) and adds a framework so all worlds that will need to regen can be skipped from the multiworld gen'd at launch note: this will break UT for worlds that still use old options API, but those are soon disappearing so I don't care as much
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
adds optimization to regen so that it only generates the world you are connecting as (with plans to cache those so it won't gen the same world+slot data more than once) and adds a framework so all worlds that will need to regen can be skipped from the multiworld gen'd at launch
How was this tested?
forced TUNIC to be in the REGEN_WORLDS and connected to a tunic slot, using manually_collect to prove it was working
including connecting/disconnecting multiple times and switching to a different slot and back
will run a full test later
If this makes graphical changes, please attach screenshots.