Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMH improvements #857

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

MMH improvements #857

Changes from 9 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
84df57a
Update en_us.json
Madis0 Jun 17, 2024
d13969e
Update en_us.json
Madis0 Jun 17, 2024
58dd864
Merge branch 'main' into mmh-improvement
Madis0 Oct 6, 2024
af81155
Update en_us.json
Madis0 Oct 6, 2024
667b1d9
Update en_us.json
Madis0 Oct 6, 2024
ad0fcbc
Update en_us.json
Madis0 Oct 6, 2024
a60c42e
Update en_us.json
Madis0 Oct 6, 2024
89a51b6
Merge branch 'main' into mmh-improvement
Madis0 Oct 10, 2024
b93888a
Merge branch 'main' into mmh-improvement
Madis0 Oct 29, 2024
6bf72c0
Merge branch 'main' into mmh-improvement
Madis0 Jan 7, 2025
94a467e
Update en_us.json
Madis0 Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions Resource Packs/Mod Menu Helper/assets/fo/lang/en_us.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,17 @@
"modmenu.summaryTranslation.colormatic": "§6🔀§r OptiFine's Custom Colors\n§3§l📥§r§9🛠§8 Clear sky/void, light smoothing",
"modmenu.summaryTranslation.continuity": "OptiFine's Connected & Emissive Textures\n§3§l📥§r§9🛠§8 Toggle block features",
"modmenu.summaryTranslation.controlify": "Game controller support\n§9🛠§8 Vibration, sounds, ...",
"modmenu.summaryTranslation.cubes-without-borders": "Full screen with Alt+Tab support (opt-in)\n§9🛠§8 In Video Settings: toggle mod",
"modmenu.summaryTranslation.cubes-without-borders": "Full screen with Alt+Tab support (opt-in)\n§9🛠§8 In <lang options.videoTitle>: toggle mod",
Copy link
Member Author

@Madis0 Madis0 Jan 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this implicitly adds more language compatibility, it also has two issues:

  • Looks out of place with English-other language mix
  • Translators may not understand they can still translate it

"modmenu.summaryTranslation.cull-less-leaves": "§6🔀§r Faster tree leaves\n§9🛠§8 Toggle mod, leaf depth",
"modmenu.summaryTranslation.debugify": "Fixes bugs, disables Mojang's telemetry\n§9🛠§8 See FO wiki for more info",
"modmenu.summaryTranslation.debugify": "Fixes bugs, disables Mojang's telemetry\n§9🛠§8 <url 'https://wiki.download.fo/changed-options#fixed-bugs'>See FO wiki for more info</url>",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These links might change soon, though it is trivial to update them for all languages

Copy link
Member Author

@Madis0 Madis0 Jan 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In testing with MM 12.0.0 for 1.21.3 and TP API 2.5.1+1.21.3, adding an URL made the menu crash:

[17:25:18] [Render thread/ERROR]:Reported exception thrown!
net.minecraft.class_148: Rendering screen
	at knot/net.minecraft.class_757.method_3192(class_757.java:558) ~[client-intermediary.jar:?]
	at knot/net.minecraft.class_310.method_1523(class_310.java:1352) ~[client-intermediary.jar:?]
	at knot/net.minecraft.class_310.method_1514(class_310.java:933) [client-intermediary.jar:?]
	at knot/net.minecraft.client.main.Main.main(Main.java:265) [client-intermediary.jar:?]
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:480) [fabric-loader-0.16.9.jar:?]
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) [fabric-loader-0.16.9.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) [fabric-loader-0.16.9.jar:?]
Caused by: java.lang.NullPointerException: Cannot invoke "String.length()" because "string" is null
	at knot/eu.pb4.placeholders.api.parsers.TagLikeParser$Format.findFirst(TagLikeParser.java:368) ~[placeholder-api-2.5.1+1.21.3.jar:?]
	at knot/eu.pb4.placeholders.impl.textparser.SingleTagLikeParser.handleLiteral(SingleTagLikeParser.java:21) ~[placeholder-api-2.5.1+1.21.3.jar:?]
	at knot/eu.pb4.placeholders.api.parsers.TagLikeParser.parse(TagLikeParser.java:82) ~[placeholder-api-2.5.1+1.21.3.jar:?]
	at knot/eu.pb4.placeholders.api.parsers.TagLikeParser.parseNodes(TagLikeParser.java:75) ~[placeholder-api-2.5.1+1.21.3.jar:?]

Also it is relevant to consider that the user may not expect to be able to click it anyway (unless blue and underlined?), leading to unintended behaviour on accidental clicks.

"modmenu.summaryTranslation.dynamic_fps": "Reduces FPS in the background\n§9🛠§8 Toggle mod, restore on hover, ...",
"modmenu.summaryTranslation.e4mc_minecraft": "Open worlds to Internet, just like LAN\n§9🛠§8 Use and configure via \"Open to Internet\"",
"modmenu.summaryTranslation.e4mc_minecraft": "Open worlds to Internet, just like LAN\n§9🛠§8 Use and configure via \"<lang menu.shareToLan>\"",
"modmenu.summaryTranslation.enhancedblockentities": "Faster chests, signs, beds etc.\n§9🛠§8 Blocks to improve, method",
"modmenu.summaryTranslation.entity_model_features": "OptiFine's Custom Entity Models\n§3§l📥§r§8🛠 (only advanced options)",
"modmenu.summaryTranslation.entity_texture_features": "OptiFine's Random & Emissive Entities\n§3§l📥§r§9🛠§8 Random mobs, emissivity, eye blinking, ...",
"modmenu.summaryTranslation.entityculling": "Stops rendering mobs behind walls\n§8🛠 (only advanced options)",
"modmenu.summaryTranslation.fabricskyboxes": "Custom Sky\n§3§l📥§r§9🛠§8 Expand the mod to configure (click ▼ on icon)",
"modmenu.summaryTranslation.fabrishot": "Take 4K screenshots with F9\n§9🛠§8 Override F2, resolution, keybind, ...",
"modmenu.summaryTranslation.fabrishot": "Take 4K screenshots with <keybind 'key_key.fabrishot.screenshot'>\n§9🛠§8 Override <keybind 'key_key.screenshot'>, resolution, keybind, ...",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even when MMH one is correct, the pause menu one won't be... But it's better than nothing I guess.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In testing with MM 12.0.0 for 1.21.3 and TP API 2.5.1+1.21.3, the mod keybind crashed while the vanilla one worked. Maybe due to not being available in early loading yet?

[17:25:18] [Render thread/ERROR]:Reported exception thrown!
net.minecraft.class_148: Rendering screen
	at knot/net.minecraft.class_757.method_3192(class_757.java:558) ~[client-intermediary.jar:?]
	at knot/net.minecraft.class_310.method_1523(class_310.java:1352) ~[client-intermediary.jar:?]
	at knot/net.minecraft.class_310.method_1514(class_310.java:933) [client-intermediary.jar:?]
	at knot/net.minecraft.client.main.Main.main(Main.java:265) [client-intermediary.jar:?]
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:480) [fabric-loader-0.16.9.jar:?]
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) [fabric-loader-0.16.9.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) [fabric-loader-0.16.9.jar:?]
Caused by: java.lang.NullPointerException: Cannot invoke "String.length()" because "string" is null
	at knot/eu.pb4.placeholders.api.parsers.TagLikeParser$Format.findFirst(TagLikeParser.java:368) ~[placeholder-api-2.5.1+1.21.3.jar:?]
	at knot/eu.pb4.placeholders.impl.textparser.SingleTagLikeParser.handleLiteral(SingleTagLikeParser.java:21) ~[placeholder-api-2.5.1+1.21.3.jar:?]
	at knot/eu.pb4.placeholders.api.parsers.TagLikeParser.parse(TagLikeParser.java:82) ~[placeholder-api-2.5.1+1.21.3.jar:?]
	at knot/eu.pb4.placeholders.api.parsers.TagLikeParser.parseNodes(TagLikeParser.java:75) ~[placeholder-api-2.5.1+1.21.3.jar:?]

"isxander-main-menu-credits.fabrishot": "Take 4K screenshots with F9",
"modmenu.summaryTranslation.fadeless": "§6🔀§r Removes loading fade animation\n§8§m🛠§8 (no options)",
"modmenu.summaryTranslation.fastquit": "Quits from singleplayer instantly\n§9🛠§8 Toasts, indicator, ...",
Expand All @@ -34,7 +34,7 @@
"modmenu.summaryTranslation.isxander-main-menu-credits": "Modpack version in title screen\n§8🛠 (only advanced options)",
"modmenu.summaryTranslation.itemmodelfix": "§6🔀§r Fixes transparent lines in held items\n§9🛠§8 Method",
"modmenu.summaryTranslation.lambdynlights": "OptiFine's Dynamic Lights\n§9🛠§8 Quality, entity options, ...",
"modmenu.summaryTranslation.languagereload": "Instant language switching, searchbar\n§9🛠§8 Multi-language Creative search, ...",
"modmenu.summaryTranslation.languagereload": "Instant language switching, searchbar\n§9🛠§8 Multi-language <lang key.categories.creative> search, ...",
"modmenu.summaryTranslation.lithium": "Optimizes physics and chunks\n§8🛠 (only advanced options)",
"modmenu.summaryTranslation.memoryleakfix": "Fixes memory leaks\n§8§m🛠§8 (no options)",
"modmenu.summaryTranslation.midnightcontrols": "§6🔀§r Controller and touchscreen support\n§9🛠§8 Input method, keybinds, controller options, ...",
Expand All @@ -49,13 +49,13 @@
"modmenu.summaryTranslation.paginatedadvancements": "Big advancement screen and requirement list\n§9🛠§8 Requirement visibility, tab pinning, ...",
"modmenu.summaryTranslation.polytone": "OptiFine's Custom Colors\n§3§l📥§r§8§m🛠§8 (no options)",
"modmenu.summaryTranslation.puzzle": "OptiFine's Custom Loading Screen\n§3§l📥§r§9🛠§8 Toggle mod, ...",
"modmenu.summaryTranslation.reeses-sodium-options": "Vertical video settings\n§8§m🛠§8 (no options)",
"modmenu.summaryTranslation.reeses-sodium-options": "Vertical <lang options.videoTitle>\n§8§m🛠§8 (no options)",
"modmenu.summaryTranslation.rrls": "Resource packs load in the background\n§9🛠§8 Loading fade animation speed, ...",
"modmenu.summaryTranslation.sodium-extra": "OptiFine's graphics options\n§9🛠§8 In Video Settings: animations, particles, ...",
"modmenu.summaryTranslation.sodium": "Optimizes rendering, better FPS\n§9🛠§8 In Video Settings: optimizations",
"modmenu.summaryTranslation.sodium-extra": "OptiFine's graphics options\n§9🛠§8 In <lang options.videoTitle>: animations, particles, ...",
"modmenu.summaryTranslation.sodium": "Optimizes rendering, better FPS\n§9🛠§8 In <lang options.videoTitle>: optimizations",
"sodium.options.buttons.donate": "Support Sodium!",
"modmenu.summaryTranslation.yosbr": "Modpack's default options\n§9🛠§8 To reset, see FO wiki",
"modmenu.summaryTranslation.zoomify": "Zoom by holding C\n§9🛠§8 Distance, cinematic camera, keybind, ...",
"modmenu.summaryTranslation.yosbr": "Modpack's default options\n§9🛠§8 <url 'https://wiki.download.fo/update-instructions#resetting-options'>To reset, see FO wiki</url>",
"modmenu.summaryTranslation.zoomify": "Zoom by holding <keybind 'key_zoomify.key.zoom'>\n§9🛠§8 Distance, cinematic camera, keybind, ...",
"fo.resourcePack.fastbettergrass": "§7OptiFine's Better Grass (fast)§r\n§4Must be the first to work§r",
"menu.shareToLan": "Open to Internet",
"lanServer.title": "Open to Internet",
Expand Down