MMH improvements #857
Draft
MMH improvements #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madis0
commented
Jun 17, 2024
| @@ -23,7 +23,7 @@ | |||
| "modmenu.summaryTranslation.entity_texture_features": "OptiFine's Random & Emissive Entities\n§3§l📥§r§9🛠§8 Random mobs, emissivity, eye blinking, ...", | |||
| "modmenu.summaryTranslation.entityculling": "Stops rendering mobs behind walls\n§8🛠 (only advanced options)", | |||
| "modmenu.summaryTranslation.fabricskyboxes": "Custom Sky\n§3§l📥§r§9🛠§8 Expand the mod to configure (click ▼ on icon)", | |||
| "modmenu.summaryTranslation.fabrishot": "Take 4K screenshots with F9\n§9🛠§8 Override F2, resolution, keybind, ...", | |||
| "modmenu.summaryTranslation.fabrishot": "Take 4K screenshots with <keybind 'key_key.fabrishot.screenshot'>\n§9🛠§8 Override <keybind 'key_key.screenshot'>, resolution, keybind, ...", | |||
There was a problem hiding this comment.
Even when MMH one is correct, the pause menu one won't be... But it's better than nothing I guess.
There was a problem hiding this comment.
In testing with MM 12.0.0 for 1.21.3 and TP API 2.5.1+1.21.3, the mod keybind crashed while the vanilla one worked. Maybe due to not being available in early loading yet?
[17:25:18] [Render thread/ERROR]:Reported exception thrown!
net.minecraft.class_148: Rendering screen
at knot/net.minecraft.class_757.method_3192(class_757.java:558) ~[client-intermediary.jar:?]
at knot/net.minecraft.class_310.method_1523(class_310.java:1352) ~[client-intermediary.jar:?]
at knot/net.minecraft.class_310.method_1514(class_310.java:933) [client-intermediary.jar:?]
at knot/net.minecraft.client.main.Main.main(Main.java:265) [client-intermediary.jar:?]
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:480) [fabric-loader-0.16.9.jar:?]
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) [fabric-loader-0.16.9.jar:?]
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) [fabric-loader-0.16.9.jar:?]
Caused by: java.lang.NullPointerException: Cannot invoke "String.length()" because "string" is null
at knot/eu.pb4.placeholders.api.parsers.TagLikeParser$Format.findFirst(TagLikeParser.java:368) ~[placeholder-api-2.5.1+1.21.3.jar:?]
at knot/eu.pb4.placeholders.impl.textparser.SingleTagLikeParser.handleLiteral(SingleTagLikeParser.java:21) ~[placeholder-api-2.5.1+1.21.3.jar:?]
at knot/eu.pb4.placeholders.api.parsers.TagLikeParser.parse(TagLikeParser.java:82) ~[placeholder-api-2.5.1+1.21.3.jar:?]
at knot/eu.pb4.placeholders.api.parsers.TagLikeParser.parseNodes(TagLikeParser.java:75) ~[placeholder-api-2.5.1+1.21.3.jar:?]
Madis0
commented
Oct 29, 2024
| "modmenu.summaryTranslation.cull-less-leaves": "§6🔀§r Faster tree leaves\n§9🛠§8 Toggle mod, leaf depth", | ||
| "modmenu.summaryTranslation.debugify": "Fixes bugs, disables Mojang's telemetry\n§9🛠§8 See FO wiki for more info", | ||
| "modmenu.summaryTranslation.debugify": "Fixes bugs, disables Mojang's telemetry\n§9🛠§8 <url 'https://wiki.download.fo/changed-options#fixed-bugs'>See FO wiki for more info</url>", |
There was a problem hiding this comment.
These links might change soon, though it is trivial to update them for all languages
There was a problem hiding this comment.
In testing with MM 12.0.0 for 1.21.3 and TP API 2.5.1+1.21.3, adding an URL made the menu crash:
[17:25:18] [Render thread/ERROR]:Reported exception thrown!
net.minecraft.class_148: Rendering screen
at knot/net.minecraft.class_757.method_3192(class_757.java:558) ~[client-intermediary.jar:?]
at knot/net.minecraft.class_310.method_1523(class_310.java:1352) ~[client-intermediary.jar:?]
at knot/net.minecraft.class_310.method_1514(class_310.java:933) [client-intermediary.jar:?]
at knot/net.minecraft.client.main.Main.main(Main.java:265) [client-intermediary.jar:?]
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:480) [fabric-loader-0.16.9.jar:?]
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) [fabric-loader-0.16.9.jar:?]
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) [fabric-loader-0.16.9.jar:?]
Caused by: java.lang.NullPointerException: Cannot invoke "String.length()" because "string" is null
at knot/eu.pb4.placeholders.api.parsers.TagLikeParser$Format.findFirst(TagLikeParser.java:368) ~[placeholder-api-2.5.1+1.21.3.jar:?]
at knot/eu.pb4.placeholders.impl.textparser.SingleTagLikeParser.handleLiteral(SingleTagLikeParser.java:21) ~[placeholder-api-2.5.1+1.21.3.jar:?]
at knot/eu.pb4.placeholders.api.parsers.TagLikeParser.parse(TagLikeParser.java:82) ~[placeholder-api-2.5.1+1.21.3.jar:?]
at knot/eu.pb4.placeholders.api.parsers.TagLikeParser.parseNodes(TagLikeParser.java:75) ~[placeholder-api-2.5.1+1.21.3.jar:?]
Also it is relevant to consider that the user may not expect to be able to click it anyway (unless blue and underlined?), leading to unintended behaviour on accidental clicks.
Remove single-quotes
Madis0
commented
Jan 7, 2025
| @@ -13,17 +13,17 @@ | |||
| "modmenu.summaryTranslation.colormatic": "§6🔀§r OptiFine's Custom Colors\n§3§l📥§r§9🛠§8 Clear sky/void, light smoothing", | |||
| "modmenu.summaryTranslation.continuity": "OptiFine's Connected & Emissive Textures\n§3§l📥§r§9🛠§8 Toggle block features", | |||
| "modmenu.summaryTranslation.controlify": "Game controller support\n§9🛠§8 Vibration, sounds, ...", | |||
| "modmenu.summaryTranslation.cubes-without-borders": "Full screen with Alt+Tab support (opt-in)\n§9🛠§8 In Video Settings: toggle mod", | |||
| "modmenu.summaryTranslation.cubes-without-borders": "Full screen with Alt+Tab support (opt-in)\n§9🛠§8 In <lang options.videoTitle>: toggle mod", | |||
There was a problem hiding this comment.
While this implicitly adds more language compatibility, it also has two issues:
- Looks out of place with English-other language mix
- Translators may not understand they can still translate it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New cool stuff in 1.21 due to the added support of QuickText. Needs testing!