Skip to content

Resolve Pool name collision#4407

Open
bluebear94 wants to merge 1 commit into
FabricMC:1.21.11from
bluebear94:mf/pool-renames-1.21.11
Open

Resolve Pool name collision#4407
bluebear94 wants to merge 1 commit into
FabricMC:1.21.11from
bluebear94:mf/pool-renames-1.21.11

Conversation

@bluebear94
Copy link
Copy Markdown
Contributor

Executive summary

Resolves duplicate classes named Pool introduced by 721bbfa.

  • net.minecraft.client.util.Pool has been renamed to ObjectPool to remove the name collision with net.minecraft.util.collection.Pool.
  • net.minecraft.util.collection.Pool has been renamed to WeightedPool (the official name is likely WeightedList as mentioned in error messages, but there is an existing class with this as its Yarn name).
  • WeightedList has been renamed to ShufflingList (mentioned in its toString implementation).
  • Several memory-related client util classes have been moved to their own package.
    • BufferAllocator is moved to com.mojang.blaze3d.buffers instead. There is precedent for obfuscated classes under com.mojang.blaze3d: namely ProjectionType and VertexSorter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant