Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename some builder classes #2921

Merged
merged 5 commits into from
Feb 11, 2022
Merged

Rename some builder classes #2921

merged 5 commits into from
Feb 11, 2022

Conversation

enbrain
Copy link
Contributor

@enbrain enbrain commented Dec 12, 2021

Cherry-picked class name changes from #1940

@enbrain enbrain added refactor A PR that renames existing names. release A PR that targets a release version of Minecraft labels Dec 12, 2021
@enbrain enbrain requested a review from a team December 12, 2021 05:08
@Juuxel
Copy link
Member

Juuxel commented Dec 12, 2021

This PR might be impactful if people are already using these classes with the datagen API in Fabric API (Specifically when implementing their FabricRecipesProvider)

@liach
Copy link
Contributor

liach commented Dec 12, 2021

This one is actually impactful for the advancement builder, but we need that rename.

@Juuxel Juuxel added the impactful A change that is likely to affect some mods. Will require more reviews. label Dec 12, 2021
@haykam821 haykam821 added the update-base Add this label to a pull request to automatically change the target branch to the default branch. label Jan 19, 2022
@github-actions github-actions bot changed the base branch from 1.18.1 to 22w03a January 19, 2022 17:49
@github-actions
Copy link
Contributor

🚀 Target branch has been updated to 22w03a

@github-actions github-actions bot added snapshot A PR that targets a snapshot version of Minecraft and removed release A PR that targets a release version of Minecraft update-base Add this label to a pull request to automatically change the target branch to the default branch. labels Jan 19, 2022
@liach liach requested a review from a team January 19, 2022 18:27
@haykam821 haykam821 added the update-base Add this label to a pull request to automatically change the target branch to the default branch. label Feb 2, 2022
@github-actions github-actions bot changed the base branch from 22w03a to 22w05a February 2, 2022 21:30
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2022

🚀 Target branch has been updated to 22w05a

@github-actions github-actions bot removed the update-base Add this label to a pull request to automatically change the target branch to the default branch. label Feb 2, 2022
@modmuss50 modmuss50 added the update-base Add this label to a pull request to automatically change the target branch to the default branch. label Feb 11, 2022
@github-actions github-actions bot changed the base branch from 22w05a to 22w06a February 11, 2022 08:54
@github-actions
Copy link
Contributor

🚀 Target branch has been updated to 22w06a

@github-actions
Copy link
Contributor

🚨 Please fix merge conflicts before this can be merged

@github-actions github-actions bot added outdated A PR that targets an outdated branch. and removed update-base Add this label to a pull request to automatically change the target branch to the default branch. labels Feb 11, 2022
@modmuss50 modmuss50 merged commit c35b686 into FabricMC:22w06a Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liach liach liach approved these changes

@Juuxel Juuxel Juuxel approved these changes

@modmuss50 modmuss50 modmuss50 approved these changes

Assignees
No one assigned
Labels
impactful A change that is likely to affect some mods. Will require more reviews. outdated A PR that targets an outdated branch. refactor A PR that renames existing names. snapshot A PR that targets a snapshot version of Minecraft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@enbrain @Juuxel @liach @modmuss50 @haykam821