Skip to content

Recipe cleanups #2548

Open
Open
@liach

Description

When looking at #2544, I find quite a few more problem with recipes in general:

  1. The distinction of "recipe" and "crafting". Crafting, in vanilla, strictly refers to the recipes in the crafting table, while we have mixed names, such as Recipe.craft.
  2. In addition, we assume "recipe" can cover "crafting", as seen in ShapedRecipe, whose minecraft ID is crafting_shaped, and should be named ShapedCraftingRecipe.
  3. CuttingRecipe has nothing related to cutting; it is more or so a recipe that takes a single input ingredient, and can be of any recipe type once it implements the proper marker interface.
  4. There are a few more legacy names in the recipe package, such as inconsistent getters, deserialize in RecipeManager.

I plan to delay these changes into 1.18, as 1.17 is out here and mojang does plan to release 1.18 quite soon. The documentation and less impactful renames (params, private members) may go into 1.17 though.

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions