Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtysh: fix searching commands in parent nodes #5083

Merged
merged 1 commit into from
Oct 14, 2019

Conversation

zays26
Copy link
Contributor

@zays26 zays26 commented Sep 30, 2019

Do not check parent command nodes in case of ambiguous and incomplete commands

Signed-off-by: Pavel Ivashchenko pivashchenko@nfware.com

@LabN-CI
Copy link
Collaborator

LabN-CI commented Sep 30, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/5083 f811427
Date 09/30/2019
Start 12:36:56
Finish 12:58:45
Run-Time 21:49
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-09-30-12:36:56.txt
Log autoscript-2019-09-30-12:37:51.log.bz2
Memory 425 434 360

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9087/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
Report for vtysh.c | 4 issues
===============================================
< ERROR: code indent should use tabs where possible
< #495: FILE: /tmp/f1-2199/vtysh.c:495:
< WARNING: please, no spaces at the start of a line
< #495: FILE: /tmp/f1-2199/vtysh.c:495:

CLANG Static Analyzer Summary

  • Github Pull Request 5083, comparing to Git base SHA c4cb057
  • Base image data for Git c4cb057 does not exist - compare skipped

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9087/artifact/shared/static_analysis/index.html

@zays26 zays26 force-pushed the feature/vtysh-master branch from f811427 to 4d60e3e Compare September 30, 2019 20:32
@LabN-CI
Copy link
Collaborator

LabN-CI commented Sep 30, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/5083 4d60e3e
Date 09/30/2019
Start 16:57:22
Finish 17:19:21
Run-Time 21:59
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-09-30-16:57:22.txt
Log autoscript-2019-09-30-16:58:28.log.bz2
Memory 433 427 359

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9091/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.


CLANG Static Analyzer Summary

  • Github Pull Request 5083, comparing to Git base SHA 8ce1753

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9091/artifact/shared/static_analysis/index.html

@qlyoung qlyoung closed this Oct 7, 2019
@qlyoung qlyoung reopened this Oct 7, 2019
  Do not check parent command nodes in case of ambiguous and incomplete commands

Signed-off-by: Pavel Ivashchenko <pivashchenko@nfware.com>
@zays26 zays26 force-pushed the feature/vtysh-master branch from 4d60e3e to d741915 Compare October 8, 2019 12:19
@LabN-CI
Copy link
Collaborator

LabN-CI commented Oct 8, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/5083 d741915
Date 10/08/2019
Start 08:25:22
Finish 08:47:02
Run-Time 21:40
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-10-08-08:25:22.txt
Log autoscript-2019-10-08-08:26:12.log.bz2
Memory 433 431 360

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9168/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
Report for command.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #1150: FILE: /tmp/f1-22046/command.c:1150:

CLANG Static Analyzer Summary

  • Github Pull Request 5083, comparing to Git base SHA 4668ac9

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9168/artifact/shared/static_analysis/index.html

@qlyoung
Copy link
Member

qlyoung commented Oct 8, 2019

@zays26 I'm okay with this patch, however you need to apply the same behavior everywhere else this code has been copy-pasted. Unfortunately this is one of the worst bits of code in the whole codebase. There's another copy of this code around line 790 that I am pretty sure needs to be changed as well, and maybe in command.c.

@zays26
Copy link
Contributor Author

zays26 commented Oct 14, 2019

@qlyoung I have updated all copies of this code

@qlyoung
Copy link
Member

qlyoung commented Oct 14, 2019

Oh. I must have been looking at an old patch or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants