Merge pull request #5112 from qlyoung/cli-reject-ipv4-leading-zero

lib: reject leading 0 in ipv4 decimal quad
FRRouting · Oct 7, 2019 · 4668ac9 · 4668ac9
2 parents f7192aa + e843208
commit 4668ac9
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/lib/command_match.c b/lib/command_match.c
@@ -724,7 +724,12 @@ static enum match_type match_ipv4(const char *str)
 			return no_match;
 
 		memcpy(buf, sp, str - sp);
-		if (atoi(buf) > 255)
+
+		int v = atoi(buf);
+
+		if (v > 255)
+			return no_match;
+		if (v > 0 && buf[0] == '0')
 			return no_match;
 
 		nums++;
@@ -775,7 +780,12 @@ static enum match_type match_ipv4_prefix(const char *str)
 			return no_match;
 
 		memcpy(buf, sp, str - sp);
-		if (atoi(buf) > 255)
+
+		int v = atoi(buf);
+
+		if (v > 255)
+			return no_match;
+		if (v > 0 && buf[0] == '0')
 			return no_match;
 
 		if (dots == 3) {