zebra: stop sending invalid nexthops to clients #4165
Conversation
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7298/ This is a comment from an automated CI system. CLANG Static Analyzer Summary
No Changes in Static Analysis warnings compared to base12 Static Analyzer issues remaining.See details at |
lib/nexthop.h
Outdated
| @@ -83,6 +83,7 @@ struct nexthop { | |||
| #define NEXTHOP_FLAG_MATCHED (1 << 4) /* Already matched vs a nexthop */ | |||
| #define NEXTHOP_FLAG_FILTERED (1 << 5) /* rmap filtered, used by static only */ | |||
| #define NEXTHOP_FLAG_DUPLICATE (1 << 6) /* nexthop duplicates another active one */ | |||
| #define NEXTHOP_FLAG_RNH_FILTERED (1 << 7) /* rmap filtered, used by rnh */ | |||
There was a problem hiding this comment.
Donald's PR #4154 is going to touch these flags values too - will you re-sync after the merge?
There was a problem hiding this comment.
Yes the looser will have to :)
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Found that zebra_rnh_apply_nht_rmap would set the NEXTHOP_FLAG_ACTIVE if not blocked by the route-map, even if the flag was not active prior to the check. This fix changes the flag used to denote the nexthop is filtered so that proper active state can be retained. Additionally, found two cases where we would send invalid nexthops via send_client, which would also cause this crash. All three fixed in this commit. Signed-off-by: Don Slice <dslice@cumulusnetworks.com>
dslicenc
force-pushed
the
rnh-invalid-nexthops
branch
from
9d6d1e7 to
e47c4d3
Compare
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7302/ This is a comment from an automated CI system. CLANG Static Analyzer Summary
12 Static Analyzer issues remaining.See details at |
Found that zebra_rnh_apply_nht_rmap would set the
NEXTHOP_FLAG_ACTIVE if not blocked by the route-map, even
if the flag was not active prior to the check. This fix
changes the flag used to denote the nexthop is filtered so
that proper active state can be retained. Additionally,
found two cases where we would send invalid nexthops via
send_client, which would also cause this crash. All three
fixed in this commit.
Signed-off-by: Don Slice dslice@cumulusnetworks.com