Zebra run once #4154
Merged
Zebra run once #4154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donaldsharp
force-pushed
the
zebra_run_once
branch
from
27ca78a to
d67c8d4
Compare
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7276/ This is a comment from an automated CI system. CLANG Static Analyzer Summary
No Changes in Static Analysis warnings compared to base12 Static Analyzer issues remaining.See details at |
mjstapp
reviewed
Apr 18, 2019
The tests are not coming up consistently on my test box. Add a bit of wait time to test to allow normal bgp when the first attempt doesn't come up. Especially since bgp timeouts are 120 seconds with non datacenter compiles. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Add a ability to count the number of nexthops in a nexthop_group. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
We are effectively calling nexthop_active_update() on every route entry being processed for installation at least 2 times. This is a bit ridiculous. We need to resolve the nexthops when we know a route has changed in some manner, so do so. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
The NEXTHOP_FLAG_FILTERED went away when we started treating static routes like every other route in the system. This was a special case for handling static route code that just didn't get finished cleaning up. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
The nexthop_active_update command looks at each individual nexthop and decides if it has changed. If any nexthop has changed we will set the re->status to ROUTE_ENTRY_CHANGED and ROUTE_ENTRY_NEXTHOPS_CHANGED. Additionally the test for old_nh_num != curr_active makes no sense because suppose we have several events we are processing at the same time and a total ecmp of 16 but 14 are active at the start and 14 are active at the end but different interfaces are up or down. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
We currently run nexthop_active_check multiple times. Make the code run once and figure out state from that. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Update the nexthop flag output for the route entry dump to include all possible flag states be output. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
donaldsharp
force-pushed
the
zebra_run_once
branch
from
d67c8d4 to
df38b09
Compare
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
mjstapp
approved these changes
Apr 18, 2019
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7299/ This is a comment from an automated CI system. CLANG Static Analyzer Summary
12 Static Analyzer issues remaining.See details at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run nexthop_active_update() one time as part of handling a new route in the system.