Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bgpd: Confederation fixes with remote-as external/internal #12861

Merged
merged 2 commits into from
Feb 22, 2023
Merged

bgpd: Confederation fixes with remote-as external/internal #12861

merged 2 commits into from
Feb 22, 2023

Conversation

ton31337
Copy link
Member

Closes #12857

@ton31337
bgpd: Pass global ASN for confederation peers if not AS_SPECIFIED
db5a5ee 
When we specify remote-as as external/internal, we need to set local_as to
bgp->as, instead of bgp->confed_id. Before this patch, (bgp->as != *as) is
always valid for such a case because *as is always 0.

Also, append peer->local_as as CONFED_SEQ to avoid other side withdrawing
the routes due to confederation own AS received and/or malformed as-path.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
@frrbot frrbot bot added bgp tests Topotests, make check, etc labels Feb 21, 2023
@ton31337 ton31337 added this to the 8.5 milestone Feb 21, 2023
@LabN-CI
Copy link
Collaborator

LabN-CI commented Feb 21, 2023 •
edited
Loading

Outdated results 🚧

Basic BGPD CI results: Partial FAILURE, 1 tests failed

_ _
Result SUCCESS git merge/12861 0cb6384
Date 02/21/2023
Start 17:11:34
Finish 17:38:57
Run-Time 27:23
Total 1813
Pass 1812
Fail 1
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2023-02-21-17:11:34.txt
Log autoscript-2023-02-21-17:12:57.log.bz2
Memory 544 536 478

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Feb 22, 2023 •
edited
Loading

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9815/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

@ton31337
tests: Check if BGP confederation works with AS_EXTERNAL (!AS_SPECIFIED)
caf65e4 
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
@ton31337 ton31337 force-pushed the fix/bgp_confederation_with_astype branch from 0cb6384 to caf65e4 Compare February 22, 2023 08:08
@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9823/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

@donaldsharp donaldsharp merged commit 71286b6 into FRRouting:master Feb 22, 2023
@ton31337 ton31337 deleted the fix/bgp_confederation_with_astype branch February 22, 2023 17:24
@ton31337
Copy link
Member Author

@Mergifyio backport stable/8.4 dev/8.5

@mergify
Copy link

mergify bot commented Feb 22, 2023 •
edited
Loading

backport stable/8.4 dev/8.5

✅ Backports have been created

This was referenced Feb 22, 2023
Merged
Merged
ton31337 added a commit that referenced this pull request Feb 22, 2023
@ton31337
Merge pull request #12872 from FRRouting/mergify/bp/stable/8.4/pr-12861
3ffbcc7 
bgpd: Confederation fixes with remote-as external/internal (backport #12861)
ton31337 added a commit that referenced this pull request Feb 22, 2023
@ton31337
Merge pull request #12873 from FRRouting/mergify/bp/dev/8.5/pr-12861
02f10c3 
bgpd: Confederation fixes with remote-as external/internal (backport #12861)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport bgp master size/L tests Topotests, make check, etc
Projects
None yet
Milestone
8.5
4 participants
@ton31337 @LabN-CI @NetDEF-CI @donaldsharp