bgpd: Confederation fixes with remote-as external/internal (backport #12861) #12873
Conversation
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
When we specify remote-as as external/internal, we need to set local_as to bgp->as, instead of bgp->confed_id. Before this patch, (bgp->as != *as) is always valid for such a case because *as is always 0. Also, append peer->local_as as CONFED_SEQ to avoid other side withdrawing the routes due to confederation own AS received and/or malformed as-path. Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org> (cherry picked from commit db5a5ee)
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org> (cherry picked from commit caf65e4)
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 i386 part 4: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO4U18I386-9843/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 4 Successful on other platforms/tests
|
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9843/ This is a comment from an automated CI system. |
This is an automatic backport of pull request #12861 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com