Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routemap debugging #12796

Merged
merged 11 commits into from
Feb 14, 2023
Merged

Routemap debugging #12796

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3fb4812
zebra: Use string for type instead of number
donaldsharp Feb 12, 2023
b7d234f
bgpd: Add warning when access list does not exist in route-map
donaldsharp Feb 12, 2023
5913a17
lib: Start partitioning of rmap_debug to allow detail level
donaldsharp Feb 13, 2023
1c950f3
lib: Add `debug routemap [detail]`
donaldsharp Feb 13, 2023
819547b
bgpd: Add access list lookup failure to `debug routemap detail`
donaldsharp Feb 13, 2023
2a3ffbb
bgpd: Add useful information to prefix list lookup failures in routemaps
donaldsharp Feb 13, 2023
46b2a03
ospfd: Add access-list lookup failures to routemap code
donaldsharp Feb 13, 2023
1df4bd1
ospfd: Warn operator about prefix lists not existing in routemaps
donaldsharp Feb 13, 2023
ca4795d
zebra: Add prefix-list lookup failures to routemap debug detail
donaldsharp Feb 13, 2023
774cd0c
zebra: Add access-list lookup failures to debug routemap detail
donaldsharp Feb 13, 2023
0c89616
doc: Add documentation for `debug routemap [detail]`
donaldsharp Feb 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ospfd: Add access-list lookup failures to routemap code 
When using access-list and the access-list is not specified
let's give the operator some clue about what is going on.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
  • Loading branch information
@donaldsharp
donaldsharp committed Feb 13, 2023
commit 46b2a036a54669766b5baf6c0caeda6bacef982a
14 changes: 12 additions & 2 deletions ospfd/ospf_routemap.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,13 @@ route_match_ip_nexthop(void *rule, const struct prefix *prefix, void *object)
p.prefixlen = IPV4_MAX_BITLEN;

alist = access_list_lookup(AFI_IP, (char *)rule);
if (alist == NULL)
if (alist == NULL) {
if (CHECK_FLAG(rmap_debug, DEBUG_ROUTEMAP_DETAIL))
zlog_debug(
"%s: Access-List Specified: %s does not exist defaulting to NO_MATCH",
__func__, (char *)rule);
return RMAP_NOMATCH;
}

return (access_list_apply(alist, &p) == FILTER_DENY ? RMAP_NOMATCH
: RMAP_MATCH);
Expand Down Expand Up @@ -249,8 +254,13 @@ route_match_ip_address(void *rule, const struct prefix *prefix, void *object)
/* struct prefix_ipv4 match; */

alist = access_list_lookup(AFI_IP, (char *)rule);
if (alist == NULL)
if (alist == NULL) {
if (CHECK_FLAG(rmap_debug, DEBUG_ROUTEMAP_DETAIL))
zlog_debug(
"%s: Access-List Specified: %s does not exist defaulting to NO_MATCH",
__func__, (char *)rule);
return RMAP_NOMATCH;
}

return (access_list_apply(alist, prefix) == FILTER_DENY ? RMAP_NOMATCH
: RMAP_MATCH);
Expand Down