Routemap debugging #12796
Merged
Routemap debugging #12796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's make it easier to debug instead of guessing Signed-off-by: Donald Sharp <sharpd@nvidia.com>
When using `match ip[v6] next-hop <Access-list>` warn when creating the access-list that the access list does not yet exist and nothing can be done with it yet. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Change the bool to a uint32_t and setup a flag to test for and set against. Future commits will allow a debug detail which should be used by match/set statements to give further context of what is going on. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Add the ability to turn on `debug routemap detail` for FRR. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Let's give the operator some inkling as to why a routemap is not working the way they thing it should be when something goes wrong using it. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
When a routemap lookup of the prefix fails, add some useful data to the end operator about what has just gone wrong when they are using `debug routemap detail` Signed-off-by: Donald Sharp <sharpd@nvidia.com>
When using access-list and the access-list is not specified let's give the operator some clue about what is going on. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
|
All in all I hit the major bits of FRR(bgp, ospf and zebra) for access-list and prefix-list lookup failures. |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9641/ This is a comment from an automated CI system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits but end goal is to see stuff like this:
Effectively I spent a bunch of time tracking down why the ip address I was using was not matching the nexthop. Turns out that I had specified a accesslist instead of an ip address and it took me forever to figure it out. Debug routemap gives no clue as to what is going on with the system. So I was left with manual debugging w/ gdb. How can an operator figure this out?