Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: pim_basic fails in micronet #12655

Merged
merged 2 commits into from
Jan 19, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
tests: pim_basic fails in micronet
Looks like under heavy load, the test is not giving enough
time to come to steady state.  Do this:

a) send more udp packets and for longer
b) Increase time spent waiting

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
  • Loading branch information
donaldsharp committed Jan 18, 2023
commit 6483e73336eba47d3387d85c72472525b18d71ba
12 changes: 6 additions & 6 deletions tests/topotests/pim_basic/test_pim.py
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ def test_pim_rp_setup():
test_func = partial(
topotest.router_json_cmp, r1, "show ip pim rp-info json", expected
)
_, result = topotest.run_and_expect(test_func, None, count=15, wait=5)
_, result = topotest.run_and_expect(test_func, None, count=30, wait=1)
assertmsg = '"{}" JSON output mismatches'.format(r1.name)
assert result is None, assertmsg
# tgen.mininet_cli()
Expand All @@ -148,13 +148,13 @@ def test_pim_send_mcast_stream():
# Let's establish a S,G stream from r2 -> r1
CWD = os.path.dirname(os.path.realpath(__file__))
r2.run(
"{}/mcast-tx.py --ttl 5 --count 5 --interval 10 229.1.1.1 r2-eth0 > /tmp/bar".format(
"{}/mcast-tx.py --ttl 5 --count 40 --interval 2 229.1.1.1 r2-eth0 > /tmp/bar".format(
CWD
)
)
# And from r3 -> r1
r3.run(
"{}/mcast-tx.py --ttl 5 --count 5 --interval 10 229.1.1.1 r3-eth0 > /tmp/bar".format(
"{}/mcast-tx.py --ttl 5 --count 40 --interval 2 229.1.1.1 r3-eth0 > /tmp/bar".format(
CWD
)
)
Expand All @@ -175,7 +175,7 @@ def test_pim_send_mcast_stream():
test_func = partial(
topotest.router_json_cmp, r1, "show ip pim upstream json", expected
)
_, result = topotest.run_and_expect(test_func, None, count=20, wait=1)
_, result = topotest.run_and_expect(test_func, None, count=40, wait=1)
assert result is None, "failed to converge pim"
# tgen.mininet_cli()

Expand All @@ -191,7 +191,7 @@ def test_pim_rp_sees_stream():
test_func = partial(
topotest.router_json_cmp, rp, "show ip pim upstream json", expected
)
_, result = topotest.run_and_expect(test_func, None, count=20, wait=0.5)
_, result = topotest.run_and_expect(test_func, None, count=40, wait=1)
assertmsg = '"{}" JSON output mismatches'.format(rp.name)
assert result is None, assertmsg

Expand Down Expand Up @@ -225,7 +225,7 @@ def test_pim_igmp_report():
test_func = partial(
topotest.router_json_cmp, r1, "show ip pim upstream json", expected
)
_, result = topotest.run_and_expect(test_func, None, count=10, wait=0.5)
_, result = topotest.run_and_expect(test_func, None, count=40, wait=1)
assertmsg = '"{}" JSON output mismatches'.format(r1.name)
assert result is None, assertmsg
finally:
Expand Down