-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: pim_basic fails in micronet #12655
Conversation
ci:micronet |
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9293/ This is a comment from an automated CI system. |
19eb17c
to
da8530a
Compare
ci:micronet |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 amd64 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-9299/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9 Successful on other platforms/tests
|
ci:micronet |
1 similar comment
ci:micronet |
95790ef
to
5b8fe42
Compare
ci:micronet |
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9300/ This is a comment from an automated CI system. |
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9303/ This is a comment from an automated CI system. |
Looks like under heavy load, the test is not giving enough time to come to steady state. Do this: a) send more udp packets and for longer b) Increase time spent waiting Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Under really heavily loaded systems this is insufficient. Looking at the run output we have this: "2.1.3.22\/32":[ { "installed":true, } ], "2.1.3.23\/32":[ { "queued":true, } ], So after 10 seconds on the micronet system only 30 of the 100 routes are installed. Give it more time. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
5b8fe42
to
a6782fb
Compare
ci:micronet |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9306/ This is a comment from an automated CI system. |
ci:micronet |
@@ -109,7 +109,7 @@ def test_zebra_netlink_batching(tgen): | |||
pfx = str(ipaddress.ip_network((i, 32))) | |||
match[pfx] = [dict(entry, prefix=pfx)] | |||
|
|||
ok = topotest.router_json_cmp_retry(r1, "show ip route json", match) | |||
ok = topotest.router_json_cmp_retry(r1, "show ip route json", match, False, 30) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest this clarifying change s/ False, 30/retry_timeout=30/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from slack, @donaldsharp declined suggestion.
Looks like under heavy load, the test is not giving enough time to come to steady state. Do this:
a) send more udp packets and for longer
b) Increase time spent waiting
Signed-off-by: Donald Sharp sharpd@nvidia.com