User sivak frr 6.0.3 vrffix #12402
Closed
User sivak frr 6.0.3 vrffix #12402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we're now building through one large Makefile, we can easily put things with their daemons and crossreference nicely. Signed-off-by: David Lamparter <equinox@diac24.net>
test_cli.refout is written by configure into the build directory, thus we need a little special glue to find it correctly. Signed-off-by: David Lamparter <equinox@diac24.net>
Signed-off-by: David Lamparter <equinox@diac24.net>
Whether or not RPKI is enabled during build shouldn't really influence vtysh; the user can always manually install bgpd_rpki.so later and it should work. This also means that the behaviour of "RPKI module not loaded" is consistent regardless of whether it was a compile-time or runtime decision. Signed-off-by: David Lamparter <equinox@diac24.net>
This makes it slightly easier to replace the stub RFP code with an external implementation. Signed-off-by: David Lamparter <equinox@diac24.net>
Signed-off-by: David Lamparter <equinox@diac24.net>
We were linking all libs and binaries against libprotobuf-c if the option was enabled... that makes no sense at all. Signed-off-by: David Lamparter <equinox@diac24.net>
The variable name is not exactly the most helpful thing there. Signed-off-by: David Lamparter <equinox@diac24.net>
ASAN/MSAN/TSAN flags need to be in CFLAGS and LDFLAGS; the latter links the correct compiler-dependent library. Also, the configure switch was broken (--disable-... would enable the sanitizer.) Signed-off-by: David Lamparter <equinox@diac24.net>
Can't build manpages without sphinx-build, oops... Signed-off-by: David Lamparter <equinox@diac24.net>
Need to pass this on configure now to work properly. Signed-off-by: David Lamparter <equinox@diac24.net>
* Add 'foreign' option to allow Automake to ignore missing GNU standard files * Remove AUTHORS * Remove NEWS * Remove ChangeLog Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
Friendly READMEs are all the rage! Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
...so we properly locate config files and daemons whereever the user decided to put them. Signed-Off-By: David Lamparter <equinox@diac24.net>
Signed-off-by: jpmondet <jp@mondet.org>
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
Sphinx always runs, even in the `make install` stage. When `make install`
is run as root and then another `make` is run by a nonprivileged user,
some versions of `mv` prompt like this:
mv: replace 'doc/manpages/_build/man/man.stamp',
overriding mode 0644 (rw-r--r--)?
Add -f to `mv` to avoid this. As `-f` is part of Posix, this should be
portable enough.
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
The script simplifies the relatively lengthy procedure. It should be invoked from the top level source directory, for example: ./tools/build-debian-package.sh Signed-off-by: Daniil Baturin <daniil@baturin.org>
Some test statements were missing "" around variables causing syntax errors during configure runs. Signed-off-by: David Lamparter <equinox@diac24.net>
The -D option zeroes out timestamps in .a files and has become the default on recent distributions to enable reproducible builds. This also shuts up the "u ignored because D is default" warning that is showing up on some distributions. Signed-off-by: David Lamparter <equinox@diac24.net>
The SNMP MIB directory is unneeded, --enable-poll has been long gone, the "build" target is straight up wrong (causing FRR to be built in the install step) and we haven't needed /proc for configure in ages either. Signed-off-by: David Lamparter <equinox@diac24.net>
- accept either python2 or python3 packages for everything - drop texlive-latex-base, texlive-generic-recommended (only needed for PDF docs) - python-ipaddr is not a build time requirement, only runtime Signed-off-by: David Lamparter <equinox@diac24.net>
This strips the USE_PIM, USE_BFD and USE_LDP options, all of which are just straight up counterproductive knobs. Instead, --enable-werror really needs to default to off, so add an option for that. Lastly, use --disable-dependency-tracking to speed up the build. Signed-off-by: David Lamparter <equinox@diac24.net>
We don't need termcap/tinfo/curses, those are just for libreadline. On most modern systems, libreadline will pull in the appropriate libs it needs on its own, so unconditionally adding them adds an extra unneeded dependency for us. Still need to try with curses/... for some systems, but only after bare readline fails. Signed-off-by: David Lamparter <equinox@diac24.net>
If we use "./configure --with-pkg-extra-version=... && make dist", we probably want the dist tarball to remember the extra version it was configured with. Use --without-pkg-extra-version to kill the tag. Signed-off-by: David Lamparter <equinox@diac24.net>
For some reason, automake was "randomizing" the order of these few lines in the generated output Makefile.in. I have absolutely no clue what's going on, but it's the only thing preventing me from building reproducible source tarballs (i.e. bit-exactly identical), so... just slightly "rephrase" this. Should behave exactly the same as before. Signed-off-by: David Lamparter <equinox@diac24.net>
We weren't cleaning up some files (a whole lot of python foobar) and had some files in the dist tarball that don't quite belong there. Signed-off-by: David Lamparter <equinox@diac24.net>
This puts a source tree back in the state it was in after unpacking a dist tarball. Different from distclean in that it doesn't remove files that are included in the tarball. Signed-off-by: David Lamparter <equinox@diac24.net>
stable/6.0: tools/frr: use path settings from ./configure
* print the route type in the detailed route output `sh ip bgp X.X.X.X/Y` * fix the overlay subnet parsing that was broken * continue nh resolution after failure to find a better nh match
* continue with nht recursion if infiot nht fails. we might find a match
When POLLNVAL is received for a FD then that FD is removed from the pfd array and also array is rearranged using memmove. When memmove is used then unused index are not cleanedup. When a new FD takes up that index then it ends up using stale events without any handler set for the same. Signed-off-by: Santosh P K <sapk@vmware.com>
Always resend the nexthop information when we get a registration event. Multiple daemons expect this information. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com.
Adding debug when socket sends out to print bytes_written. This should help match with FRRFpm::selected read buf_len
The last debug added required enabling debug zebra fpm to get the logs. Also, suppressing the Overlay Prefix log as too many gets printed in the scale setups.
* parse overlay extended mask value and update the infiot overlay prefix. *currently reachability check is done based on overlay subnet which causes all prefixes to be installed. updated to check the reachibility based on nh value from trkr. *skip overlay subnet prefix match
*currently bgp schedules an event to zebra socket connect. if bgp config is processed before the socket establishment, then all the neighbor registeration will stall in bgp, as bgp doesn't handle the rnh register failure with zebra. *Added the zebra socket retry in bgp to retry for 12 times with 10 seconds interval. *This issue observed in a cluster where the storage is being put in a cross regional account. it could cause the issue as we aread the inf_config.json file in the zebra bootup. *adding the patch to dev folder for future reference.
vrf with namespace in the backend. dummy overlay interface with the link local ip is needed in the namespace for the leaked route to be installed
Continuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: FailedCheckout code: Failed (click for details)PullReq merge failed. Please rebase your branch: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.