General mayhem #12108
Merged
General mayhem #12108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The zclient data structure was not being cleaned up on shutdown. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Pre: staticd: showing active allocations in memory group libfrr staticd: memstats: Scripting : 16 * (variably sized) staticd: memstats: Hash : 2 * (variably sized) staticd: memstats: Hash Bucket : 8 * 32 staticd: memstats: Hash Index : 1 * (variably sized) staticd: memstats: Link List : 1 * 40 staticd: memstats: Link Node : 1 * 24 staticd: showing active allocations in memory group logging subsystem staticd: memstats: log file target : 1 * 88 staticd: showing active allocations in memory group staticd Post: staticd: showing active allocations in memory group libfrr staticd: showing active allocations in memory group logging subsystem staticd: memstats: log file target : 1 * 88 staticd: showing active allocations in memory group staticd Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
ton31337
reviewed
Oct 12, 2022
| struct frrscript_codec *c = data; | ||
| char *constworkaroundandihateit = (char *)c->typename; | ||
|
|
||
| XFREE(MTYPE_SCRIPT, constworkaroundandihateit); |
ton31337
approved these changes
Oct 12, 2022
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7856/ This is a comment from an automated CI system. |
|
@Mergifyio backport dev/8.4 stable/8.3 |
✅ Backports have been created
|
This was referenced Oct 13, 2022
ton31337
added a commit
that referenced
this pull request
Oct 13, 2022
General mayhem (backport #12108)
ton31337
added a commit
that referenced
this pull request
Oct 13, 2022
General mayhem (backport #12108)
ns-ssomasundaram
pushed a commit
to infiotinc/frr
that referenced
this pull request
Dec 9, 2022
*currently bgp schedules an event to zebra socket connect. if bgp config is processed before the socket establishment, then all the neighbor registeration will stall in bgp, as bgp doesn't handle the rnh register failure with zebra. *Added the zebra socket retry in bgp to retry for 12 times with 10 seconds interval. *This issue observed in a cluster where the storage is being put in a cross regional account. it could cause the issue as we aread the inf_config.json file in the zebra bootup. *adding the patch to dev folder for future reference. (cherry picked from commit 94aeebc)
ns-ssomasundaram
pushed a commit
to infiotinc/frr
that referenced
this pull request
Dec 9, 2022
*currently bgp schedules an event to zebra socket connect. if bgp config is processed before the socket establishment, then all the neighbor registeration will stall in bgp, as bgp doesn't handle the rnh register failure with zebra. *Added the zebra socket retry in bgp to retry for 12 times with 10 seconds interval. *This issue observed in a cluster where the storage is being put in a cross regional account. it could cause the issue as we aread the inf_config.json file in the zebra bootup. *adding the patch to dev folder for future reference. (cherry picked from commit 94aeebc)
ns-ssomasundaram
added a commit
to infiotinc/frr
that referenced
this pull request
Dec 10, 2022
This reverts commit a8fad43.
ns-ssomasundaram
added a commit
to infiotinc/frr
that referenced
this pull request
Dec 10, 2022
This reverts commit a8fad43.
ns-ssomasundaram
pushed a commit
to infiotinc/frr
that referenced
this pull request
Dec 12, 2022
*currently bgp schedules an event to zebra socket connect. if bgp config is processed before the socket establishment, then all the neighbor registeration will stall in bgp, as bgp doesn't handle the rnh register failure with zebra. *Added the zebra socket retry in bgp to retry for 12 times with 10 seconds interval. *This issue observed in a cluster where the storage is being put in a cross regional account. it could cause the issue as we aread the inf_config.json file in the zebra bootup. *adding the patch to dev folder for future reference. (cherry picked from commit 94aeebc)
ns-ssomasundaram
pushed a commit
to infiotinc/frr
that referenced
this pull request
Dec 12, 2022
*currently bgp schedules an event to zebra socket connect. if bgp config is processed before the socket establishment, then all the neighbor registeration will stall in bgp, as bgp doesn't handle the rnh register failure with zebra. *Added the zebra socket retry in bgp to retry for 12 times with 10 seconds interval. *This issue observed in a cluster where the storage is being put in a cross regional account. it could cause the issue as we aread the inf_config.json file in the zebra bootup. *adding the patch to dev folder for future reference. (cherry picked from commit 94aeebc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some memory leaks on shutdown being fixed