Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pim6d: add skeleton & address structures #10281

Merged
merged 3 commits into from
Jan 12, 2022

Conversation

eqvinox
Copy link
Contributor

@eqvinox eqvinox commented Jan 4, 2022

Start some mergeable progress towards pim6d

This replaces PR #10194 (unlike that PR, this one is not WIP, compiles, produces sensible output and can actually be merged)

This also partially replaces PRs #10278 / #10192 which I had previously commented/NAKd; at this point it seems a better allocation of my time to just do it rather than try to steer with reviews.

@frrbot frrbot bot added the pim label Jan 4, 2022
@eqvinox eqvinox added the pimv6 label Jan 4, 2022
@NetDEF-CI

This comment has been minimized.

@NetDEF-CI

This comment has been minimized.

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jan 4, 2022

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2454/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests debian 10 amd64 part 0: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0DEB10AMD64-2454/test

Topology Tests failed for Topotests debian 10 amd64 part 0
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2454/artifact/TOPO0DEB10AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests
  • Topotests Ubuntu 18.04 i386 part 4
  • IPv4 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 i386 part 9
  • Topotests Ubuntu 18.04 amd64 part 1
  • Static analyzer (clang)
  • Topotests Ubuntu 18.04 amd64 part 9
  • Topotests debian 10 amd64 part 7
  • Topotests Ubuntu 18.04 arm8 part 0
  • Debian 9 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 8
  • Topotests debian 10 amd64 part 2
  • Addresssanitizer topotests part 8
  • Debian 10 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 5
  • Topotests Ubuntu 18.04 amd64 part 6
  • Ubuntu 18.04 deb pkg check
  • Addresssanitizer topotests part 6
  • Ubuntu 20.04 deb pkg check
  • Topotests debian 10 amd64 part 6
  • Addresssanitizer topotests part 5
  • Topotests debian 10 amd64 part 1
  • Addresssanitizer topotests part 4
  • Addresssanitizer topotests part 0
  • Topotests debian 10 amd64 part 3
  • Topotests debian 10 amd64 part 4
  • Topotests Ubuntu 18.04 arm8 part 3
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 arm8 part 7
  • Addresssanitizer topotests part 9
  • IPv4 ldp protocol on Ubuntu 18.04
  • Topotests debian 10 amd64 part 5
  • Topotests Ubuntu 18.04 arm8 part 2
  • Ubuntu 16.04 deb pkg check
  • Topotests Ubuntu 18.04 i386 part 7
  • Addresssanitizer topotests part 7
  • Topotests Ubuntu 18.04 arm8 part 8
  • Topotests Ubuntu 18.04 i386 part 6
  • Topotests Ubuntu 18.04 i386 part 1
  • Topotests Ubuntu 18.04 arm8 part 6
  • Topotests Ubuntu 18.04 amd64 part 5
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests Ubuntu 18.04 arm8 part 1
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests Ubuntu 18.04 amd64 part 2
  • Addresssanitizer topotests part 3
  • Fedora 29 rpm pkg check
  • Topotests Ubuntu 18.04 i386 part 5
  • Topotests Ubuntu 18.04 i386 part 0
  • Topotests Ubuntu 18.04 i386 part 8
  • Topotests Ubuntu 18.04 i386 part 3
  • Topotests debian 10 amd64 part 8
  • IPv6 protocols on Ubuntu 18.04
  • CentOS 7 rpm pkg check
  • Topotests Ubuntu 18.04 arm8 part 4
  • Topotests Ubuntu 18.04 amd64 part 4
  • Topotests Ubuntu 18.04 amd64 part 3
  • Topotests Ubuntu 18.04 amd64 part 0
  • Topotests Ubuntu 18.04 arm8 part 9
  • Addresssanitizer topotests part 2
  • Topotests debian 10 amd64 part 9

Warnings Generated during build:

Checkout code: Successful with additional warnings
Topotests debian 10 amd64 part 0: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0DEB10AMD64-2454/test

Topology Tests failed for Topotests debian 10 amd64 part 0
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2454/artifact/TOPO0DEB10AMD64/ErrorLog/log_topotests.txt

Report for pim6_main.c | 4 issues
===============================================
ERROR: space required after that close brace '}'
#134: FILE: /tmp/f1-22402/pim6_main.c:134:
+	static struct option longopts[] = {{0}};
Report for pim_addr.c | 4 issues
===============================================
WARNING: Invalid vsprintf pointer extension '%pP'
#65: FILE: /tmp/f1-22402/pim_addr.c:65:
+	return bprintfrr(buf, "(%pPAs,%pPAs)", &sga->src, &sga->grp);
Report for pim_addr.h | 12 issues
===============================================
WARNING: do not add new typedefs
#26: FILE: /tmp/f1-22402/pim_addr.h:26:
+typedef struct in_addr pim_addr;

WARNING: do not add new typedefs
#28: FILE: /tmp/f1-22402/pim_addr.h:28:
+typedef struct in6_addr pim_addr;

WARNING: do not add new typedefs
#37: FILE: /tmp/f1-22402/pim_addr.h:37:
+typedef struct _pim_sgaddr pim_sgaddr;
Report for pim_join.c | 4 issues
===============================================
< WARNING: Invalid vsprintf pointer extension '%pP'
< #90: FILE: /tmp/f1-22402/pim_join.c:90:
< WARNING: Invalid vsprintf pointer extension '%pP'
< #163: FILE: /tmp/f1-22402/pim_join.c:163:
Report for pim_mlag.c | 8 issues
===============================================
< WARNING: Invalid vsprintf pointer extension '%pP'
< #745: FILE: /tmp/f1-22402/pim_mlag.c:745:
< WARNING: Invalid vsprintf pointer extension '%pP'
< #749: FILE: /tmp/f1-22402/pim_mlag.c:749:
< WARNING: Invalid vsprintf pointer extension '%pP'
< #774: FILE: /tmp/f1-22402/pim_mlag.c:774:
< WARNING: Invalid vsprintf pointer extension '%pP'
< #778: FILE: /tmp/f1-22402/pim_mlag.c:778:
Report for pim_oil.c | 4 issues
===============================================
< WARNING: Invalid vsprintf pointer extension '%pP'
< #146: FILE: /tmp/f1-22402/pim_oil.c:146:
< WARNING: Invalid vsprintf pointer extension '%pP'
< #180: FILE: /tmp/f1-22402/pim_oil.c:180:
Report for pim_register.c | 2 issues
===============================================
< WARNING: Invalid vsprintf pointer extension '%pP'
< #418: FILE: /tmp/f1-22402/pim_register.c:418:

1 similar comment
@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jan 4, 2022

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2454/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests debian 10 amd64 part 0: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0DEB10AMD64-2454/test

Topology Tests failed for Topotests debian 10 amd64 part 0
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2454/artifact/TOPO0DEB10AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests
  • Topotests Ubuntu 18.04 i386 part 4
  • IPv4 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 i386 part 9
  • Topotests Ubuntu 18.04 amd64 part 1
  • Static analyzer (clang)
  • Topotests Ubuntu 18.04 amd64 part 9
  • Topotests debian 10 amd64 part 7
  • Topotests Ubuntu 18.04 arm8 part 0
  • Debian 9 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 8
  • Topotests debian 10 amd64 part 2
  • Addresssanitizer topotests part 8
  • Debian 10 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 5
  • Topotests Ubuntu 18.04 amd64 part 6
  • Ubuntu 18.04 deb pkg check
  • Addresssanitizer topotests part 6
  • Ubuntu 20.04 deb pkg check
  • Topotests debian 10 amd64 part 6
  • Addresssanitizer topotests part 5
  • Topotests debian 10 amd64 part 1
  • Addresssanitizer topotests part 4
  • Addresssanitizer topotests part 0
  • Topotests debian 10 amd64 part 3
  • Topotests debian 10 amd64 part 4
  • Topotests Ubuntu 18.04 arm8 part 3
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 arm8 part 7
  • Addresssanitizer topotests part 9
  • IPv4 ldp protocol on Ubuntu 18.04
  • Topotests debian 10 amd64 part 5
  • Topotests Ubuntu 18.04 arm8 part 2
  • Ubuntu 16.04 deb pkg check
  • Topotests Ubuntu 18.04 i386 part 7
  • Addresssanitizer topotests part 7
  • Topotests Ubuntu 18.04 arm8 part 8
  • Topotests Ubuntu 18.04 i386 part 6
  • Topotests Ubuntu 18.04 i386 part 1
  • Topotests Ubuntu 18.04 arm8 part 6
  • Topotests Ubuntu 18.04 amd64 part 5
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests Ubuntu 18.04 arm8 part 1
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests Ubuntu 18.04 amd64 part 2
  • Addresssanitizer topotests part 3
  • Fedora 29 rpm pkg check
  • Topotests Ubuntu 18.04 i386 part 5
  • Topotests Ubuntu 18.04 i386 part 0
  • Topotests Ubuntu 18.04 i386 part 8
  • Topotests Ubuntu 18.04 i386 part 3
  • Topotests debian 10 amd64 part 8
  • IPv6 protocols on Ubuntu 18.04
  • CentOS 7 rpm pkg check
  • Topotests Ubuntu 18.04 arm8 part 4
  • Topotests Ubuntu 18.04 amd64 part 4
  • Topotests Ubuntu 18.04 amd64 part 3
  • Topotests Ubuntu 18.04 amd64 part 0
  • Topotests Ubuntu 18.04 arm8 part 9
  • Addresssanitizer topotests part 2
  • Topotests debian 10 amd64 part 9

Warnings Generated during build:

Checkout code: Successful with additional warnings
Topotests debian 10 amd64 part 0: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0DEB10AMD64-2454/test

Topology Tests failed for Topotests debian 10 amd64 part 0
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2454/artifact/TOPO0DEB10AMD64/ErrorLog/log_topotests.txt

Report for pim6_main.c | 4 issues
===============================================
ERROR: space required after that close brace '}'
#134: FILE: /tmp/f1-22402/pim6_main.c:134:
+	static struct option longopts[] = {{0}};
Report for pim_addr.c | 4 issues
===============================================
WARNING: Invalid vsprintf pointer extension '%pP'
#65: FILE: /tmp/f1-22402/pim_addr.c:65:
+	return bprintfrr(buf, "(%pPAs,%pPAs)", &sga->src, &sga->grp);
Report for pim_addr.h | 12 issues
===============================================
WARNING: do not add new typedefs
#26: FILE: /tmp/f1-22402/pim_addr.h:26:
+typedef struct in_addr pim_addr;

WARNING: do not add new typedefs
#28: FILE: /tmp/f1-22402/pim_addr.h:28:
+typedef struct in6_addr pim_addr;

WARNING: do not add new typedefs
#37: FILE: /tmp/f1-22402/pim_addr.h:37:
+typedef struct _pim_sgaddr pim_sgaddr;
Report for pim_join.c | 4 issues
===============================================
< WARNING: Invalid vsprintf pointer extension '%pP'
< #90: FILE: /tmp/f1-22402/pim_join.c:90:
< WARNING: Invalid vsprintf pointer extension '%pP'
< #163: FILE: /tmp/f1-22402/pim_join.c:163:
Report for pim_mlag.c | 8 issues
===============================================
< WARNING: Invalid vsprintf pointer extension '%pP'
< #745: FILE: /tmp/f1-22402/pim_mlag.c:745:
< WARNING: Invalid vsprintf pointer extension '%pP'
< #749: FILE: /tmp/f1-22402/pim_mlag.c:749:
< WARNING: Invalid vsprintf pointer extension '%pP'
< #774: FILE: /tmp/f1-22402/pim_mlag.c:774:
< WARNING: Invalid vsprintf pointer extension '%pP'
< #778: FILE: /tmp/f1-22402/pim_mlag.c:778:
Report for pim_oil.c | 4 issues
===============================================
< WARNING: Invalid vsprintf pointer extension '%pP'
< #146: FILE: /tmp/f1-22402/pim_oil.c:146:
< WARNING: Invalid vsprintf pointer extension '%pP'
< #180: FILE: /tmp/f1-22402/pim_oil.c:180:
Report for pim_register.c | 2 issues
===============================================
< WARNING: Invalid vsprintf pointer extension '%pP'
< #418: FILE: /tmp/f1-22402/pim_register.c:418:

Copy link
Contributor

@mobash-rasool mobash-rasool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has happened once again. We agreed last time that conflicting PRs won't be raised. The same changes are present in #10194. Let's discuss this in today's meeting.

@patrasar patrasar self-requested a review January 5, 2022 07:00
#include "pim_iface.h"
#include "pim_zebra.h"

zebra_capabilities_t _caps_p[] = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since _caps_p, pimd_privs is all same for pimd daemon, suggest to keep it in a common file, instead of defining it twice.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a good idea for 3 reasons:

  • pim6d doesn't necessarily need the same capabilities. I think we can actually remove ZCAP_BIND since there is no MSDP in IPv6
  • there is a pattern of having all these things together like in all other daemons, better to have it the same way
  • array_size() doesn't work particularly well with extern array definitions in C (the array size would need to be copied into the header)

{
prefix_list_reset();
access_list_reset();

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a memory leak here, you need to free this memory here, since it was allocated at init time in function pim_router_init.

XFREE(MTYPE_ROUTER, router);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, waiting to rebase on top of #10212

prefix_list_reset();
access_list_reset();

frr_fini();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since pim_vrf_init is initialised, pim_vrf_terminate() should be called here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, waiting to rebase on top of #10212

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jan 11, 2022

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

CentOS 8 amd64 build: Failed (click for details) CentOS 8 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CENTOS8BUILD/config.log/config.log.gz

Make failed for CentOS 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CENTOS8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.2622/frr-source'
In file included from pimd/pim_str.h:29,
pimd/pim_addr.h:25:5: error: "PIM_IPV" is not defined, evaluates to 0 [-Werror=undef]
 #if PIM_IPV == 4
In file included from pimd/pim_igmp.h:29,
pimd/pim_str.h: In function pim_addr_copy:
pimd/pim_str.h:44:6: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h:44:23: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h: In function pim_is_addr_any:

CentOS 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CENTOS8BUILD/config.status/config.status

Ubuntu 20.04 amd64 build: Failed (click for details) Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U2004AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.2622/frr-source'
In file included from pimd/pim_str.h:29,
pimd/pim_addr.h:25:5: error: "PIM_IPV" is not defined, evaluates to 0 [-Werror=undef]
In file included from pimd/pim_igmp.h:29,
pimd/pim_str.h: In function pim_addr_copy:
pimd/pim_str.h:44:6: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h:44:23: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h: In function pim_is_addr_any:
pimd/pim_str.h:49:14: error: pim_addr {aka struct in6_addr} has no member named s_addr

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U2004AMD64BUILD/config.status/config.status

Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.2622/frr-source'
In file included from pimd/pim_str.h:29:0,
pimd/pim_addr.h:25:5: error: "PIM_IPV" is not defined, evaluates to 0 [-Werror=undef]
 #if PIM_IPV == 4
In file included from pimd/pim_igmp.h:29:0,
pimd/pim_str.h: In function pim_addr_copy:
pimd/pim_str.h:44:6: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h:44:23: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h: In function pim_is_addr_any:

Ubuntu 18.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U18ARM8BUILD/config.log/config.log.gz
Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U18ARM8BUILD/config.status/config.status

Debian 9 amd64 build: Failed (click for details) Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CI021BUILD/config.status/config.status

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CI021BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.2622/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
In file included from pimd/pim_str.h:29:0,
pimd/pim_addr.h:25:5: error: "PIM_IPV" is not defined [-Werror=undef]
 #if PIM_IPV == 4
In file included from pimd/pim_igmp.h:29:0,
pimd/pim_str.h: In function pim_addr_copy:
pimd/pim_str.h:44:6: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h:44:23: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h: In function pim_is_addr_any:
Ubuntu 18.04 ppc64le build: Failed (click for details) Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U1804PPC64LEBUILD/config.status/config.status

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.2622/frr-source'
In file included from pimd/pim_str.h:29:0,
pimd/pim_addr.h:25:5: error: "PIM_IPV" is not defined, evaluates to 0 [-Werror=undef]
 #if PIM_IPV == 4
In file included from pimd/pim_igmp.h:29:0,
pimd/pim_str.h: In function pim_addr_copy:
pimd/pim_str.h:44:6: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h:44:23: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h: In function pim_is_addr_any:
Debian 10 amd64 build: Failed (click for details) Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/DEB10BUILD/config.status/config.status

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/DEB10BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.2622/frr-source'
In file included from pimd/pim_str.h:29,
pimd/pim_addr.h:25:5: error: "PIM_IPV" is not defined, evaluates to 0 [-Werror=undef]
 #if PIM_IPV == 4
In file included from pimd/pim_igmp.h:29,
pimd/pim_str.h: In function pim_addr_copy:
pimd/pim_str.h:44:6: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h:44:23: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h: In function pim_is_addr_any:

Debian 10 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/DEB10BUILD/config.log/config.log.gz

Fedora 29 amd64 build: Failed (click for details) Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/F29BUILD/config.log/config.log.gz Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/F29BUILD/config.status/config.status

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/F29BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.2622/frr-source'
In file included from pimd/pim_str.h:29,
pimd/pim_addr.h:25:5: error: "PIM_IPV" is not defined, evaluates to 0 [-Werror=undef]
 #if PIM_IPV == 4
In file included from pimd/pim_igmp.h:29,
pimd/pim_str.h: In function pim_addr_copy:
pimd/pim_str.h:44:6: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h:44:23: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h: In function pim_is_addr_any:
Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CI101BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.2622/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
In file included from pimd/pim_str.h:29:0,
pimd/pim_addr.h:25:5: error: "PIM_IPV" is not defined [-Werror=undef]
 #if PIM_IPV == 4
In file included from pimd/pim_igmp.h:29:0,
pimd/pim_str.h: In function pim_addr_copy:
pimd/pim_str.h:44:6: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h:44:23: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h: In function pim_is_addr_any:

Ubuntu 16.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CI101BUILD/config.log/config.log.gz
Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CI101BUILD/config.status/config.status

Ubuntu 18.04 arm7 build: Failed (click for details) Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.2622/frr-source'
In file included from pimd/pim_str.h:29:0,
pimd/pim_addr.h:25:5: error: "PIM_IPV" is not defined, evaluates to 0 [-Werror=undef]
 #if PIM_IPV == 4
In file included from pimd/pim_igmp.h:29:0,
pimd/pim_str.h: In function pim_addr_copy:
pimd/pim_str.h:44:6: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h:44:23: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h: In function pim_is_addr_any:
Ubuntu 16.04 i386 build: Failed (click for details) Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U1604I386/config.status/config.status

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U1604I386/ErrorLog/log_make.txt)

/home/ci/cibuild.2622/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
In file included from pimd/pim_str.h:29:0,
pimd/pim_addr.h:25:5: error: "PIM_IPV" is not defined [-Werror=undef]
 #if PIM_IPV == 4
In file included from pimd/pim_igmp.h:29:0,
pimd/pim_str.h: In function pim_addr_copy:
pimd/pim_str.h:44:6: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h:44:23: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h: In function pim_is_addr_any:
CentOS 7 amd64 build: Failed (click for details) CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CI005BUILD/config.log/config.log.gz CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CI005BUILD/config.status/config.status

Make failed for CentOS 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CI005BUILD/ErrorLog/log_make.txt)

pimd/pim_msdp.c:723:9: warning: missing braces around initializer [-Wmissing-braces]
pimd/pim_msdp.c:723:9: warning: (near initialization for nexthop.last_lookup) [-Wmissing-braces]
deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.  CC       bgpd/bgp_addpath.o
deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed./home/ci/cibuild.2622/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.2622/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.2622/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.2622/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.2622/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.2622/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
Ubuntu 16.04 arm8 build: Failed (click for details) Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U16ARM8BUILD/config.status/config.status Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U16ARM8BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.2622/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
In file included from pimd/pim_str.h:29:0,
pimd/pim_addr.h:25:5: error: "PIM_IPV" is not defined [-Werror=undef]
 #if PIM_IPV == 4
In file included from pimd/pim_igmp.h:29:0,
pimd/pim_str.h: In function pim_addr_copy:
pimd/pim_str.h:44:6: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h:44:23: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h: In function pim_is_addr_any:
Ubuntu 18.04 amd64 build: Failed (click for details) Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U1804AMD64/config.status/config.status

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U1804AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.2622/frr-source'
In file included from pimd/pim_str.h:29:0,
pimd/pim_addr.h:25:5: error: "PIM_IPV" is not defined, evaluates to 0 [-Werror=undef]
 #if PIM_IPV == 4
In file included from pimd/pim_igmp.h:29:0,
pimd/pim_str.h: In function pim_addr_copy:
pimd/pim_str.h:44:6: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h:44:23: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h: In function pim_is_addr_any:
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/DEB11AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.2622/frr-source'
In file included from pimd/pim_str.h:29,
pimd/pim_addr.h:25:5: error: "PIM_IPV" is not defined, evaluates to 0 [-Werror=undef]
In file included from pimd/pim_igmp.h:29,
pimd/pim_str.h: In function pim_addr_copy:
pimd/pim_str.h:44:6: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h:44:23: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h: In function pim_is_addr_any:
pimd/pim_str.h:49:14: error: pim_addr {aka struct in6_addr} has no member named s_addr

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/DEB11AMD64/config.status/config.status

Ubuntu 16.04 amd64 build: Failed (click for details) Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CI014BUILD/config.log/config.log.gz Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CI014BUILD/config.status/config.status

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CI014BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.2622/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
In file included from pimd/pim_str.h:29:0,
pimd/pim_addr.h:25:5: error: "PIM_IPV" is not defined [-Werror=undef]
 #if PIM_IPV == 4
In file included from pimd/pim_igmp.h:29:0,
pimd/pim_str.h: In function pim_addr_copy:
pimd/pim_str.h:44:6: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h:44:23: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h: In function pim_is_addr_any:
Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U18I386BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.2622/frr-source'
In file included from pimd/pim_str.h:29:0,
pimd/pim_addr.h:25:5: error: "PIM_IPV" is not defined, evaluates to 0 [-Werror=undef]
 #if PIM_IPV == 4
In file included from pimd/pim_igmp.h:29:0,
pimd/pim_str.h: In function pim_addr_copy:
pimd/pim_str.h:44:6: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h:44:23: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h: In function pim_is_addr_any:

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U18I386BUILD/config.log/config.log.gz

Successful on other platforms/tests
  • FreeBSD 11 amd64 build
  • NetBSD 9 amd64 build
  • OpenBSD 7 amd64 build
  • FreeBSD 12 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings
CentOS 8 amd64 build: Failed (click for details) CentOS 8 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CENTOS8BUILD/config.log/config.log.gz

Make failed for CentOS 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CENTOS8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.2622/frr-source'
In file included from pimd/pim_str.h:29,
pimd/pim_addr.h:25:5: error: "PIM_IPV" is not defined, evaluates to 0 [-Werror=undef]
 #if PIM_IPV == 4
In file included from pimd/pim_igmp.h:29,
pimd/pim_str.h: In function pim_addr_copy:
pimd/pim_str.h:44:6: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h:44:23: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h: In function pim_is_addr_any:

CentOS 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CENTOS8BUILD/config.status/config.status

Ubuntu 20.04 amd64 build: Failed (click for details) Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U2004AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.2622/frr-source'
In file included from pimd/pim_str.h:29,
pimd/pim_addr.h:25:5: error: "PIM_IPV" is not defined, evaluates to 0 [-Werror=undef]
In file included from pimd/pim_igmp.h:29,
pimd/pim_str.h: In function pim_addr_copy:
pimd/pim_str.h:44:6: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h:44:23: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h: In function pim_is_addr_any:
pimd/pim_str.h:49:14: error: pim_addr {aka struct in6_addr} has no member named s_addr

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U2004AMD64BUILD/config.status/config.status

Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.2622/frr-source'
In file included from pimd/pim_str.h:29:0,
pimd/pim_addr.h:25:5: error: "PIM_IPV" is not defined, evaluates to 0 [-Werror=undef]
 #if PIM_IPV == 4
In file included from pimd/pim_igmp.h:29:0,
pimd/pim_str.h: In function pim_addr_copy:
pimd/pim_str.h:44:6: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h:44:23: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h: In function pim_is_addr_any:

Ubuntu 18.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U18ARM8BUILD/config.log/config.log.gz
Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U18ARM8BUILD/config.status/config.status

Debian 9 amd64 build: Failed (click for details) Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CI021BUILD/config.status/config.status

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CI021BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.2622/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
In file included from pimd/pim_str.h:29:0,
pimd/pim_addr.h:25:5: error: "PIM_IPV" is not defined [-Werror=undef]
 #if PIM_IPV == 4
In file included from pimd/pim_igmp.h:29:0,
pimd/pim_str.h: In function pim_addr_copy:
pimd/pim_str.h:44:6: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h:44:23: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h: In function pim_is_addr_any:
Ubuntu 18.04 ppc64le build: Failed (click for details) Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U1804PPC64LEBUILD/config.status/config.status

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.2622/frr-source'
In file included from pimd/pim_str.h:29:0,
pimd/pim_addr.h:25:5: error: "PIM_IPV" is not defined, evaluates to 0 [-Werror=undef]
 #if PIM_IPV == 4
In file included from pimd/pim_igmp.h:29:0,
pimd/pim_str.h: In function pim_addr_copy:
pimd/pim_str.h:44:6: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h:44:23: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h: In function pim_is_addr_any:
Debian 10 amd64 build: Failed (click for details) Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/DEB10BUILD/config.status/config.status

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/DEB10BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.2622/frr-source'
In file included from pimd/pim_str.h:29,
pimd/pim_addr.h:25:5: error: "PIM_IPV" is not defined, evaluates to 0 [-Werror=undef]
 #if PIM_IPV == 4
In file included from pimd/pim_igmp.h:29,
pimd/pim_str.h: In function pim_addr_copy:
pimd/pim_str.h:44:6: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h:44:23: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h: In function pim_is_addr_any:

Debian 10 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/DEB10BUILD/config.log/config.log.gz

Fedora 29 amd64 build: Failed (click for details) Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/F29BUILD/config.log/config.log.gz Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/F29BUILD/config.status/config.status

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/F29BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.2622/frr-source'
In file included from pimd/pim_str.h:29,
pimd/pim_addr.h:25:5: error: "PIM_IPV" is not defined, evaluates to 0 [-Werror=undef]
 #if PIM_IPV == 4
In file included from pimd/pim_igmp.h:29,
pimd/pim_str.h: In function pim_addr_copy:
pimd/pim_str.h:44:6: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h:44:23: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h: In function pim_is_addr_any:
Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CI101BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.2622/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
In file included from pimd/pim_str.h:29:0,
pimd/pim_addr.h:25:5: error: "PIM_IPV" is not defined [-Werror=undef]
 #if PIM_IPV == 4
In file included from pimd/pim_igmp.h:29:0,
pimd/pim_str.h: In function pim_addr_copy:
pimd/pim_str.h:44:6: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h:44:23: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h: In function pim_is_addr_any:

Ubuntu 16.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CI101BUILD/config.log/config.log.gz
Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CI101BUILD/config.status/config.status

Ubuntu 18.04 arm7 build: Failed (click for details) Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.2622/frr-source'
In file included from pimd/pim_str.h:29:0,
pimd/pim_addr.h:25:5: error: "PIM_IPV" is not defined, evaluates to 0 [-Werror=undef]
 #if PIM_IPV == 4
In file included from pimd/pim_igmp.h:29:0,
pimd/pim_str.h: In function pim_addr_copy:
pimd/pim_str.h:44:6: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h:44:23: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h: In function pim_is_addr_any:
Ubuntu 16.04 i386 build: Failed (click for details) Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U1604I386/config.status/config.status

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U1604I386/ErrorLog/log_make.txt)

/home/ci/cibuild.2622/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
In file included from pimd/pim_str.h:29:0,
pimd/pim_addr.h:25:5: error: "PIM_IPV" is not defined [-Werror=undef]
 #if PIM_IPV == 4
In file included from pimd/pim_igmp.h:29:0,
pimd/pim_str.h: In function pim_addr_copy:
pimd/pim_str.h:44:6: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h:44:23: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h: In function pim_is_addr_any:
CentOS 7 amd64 build: Failed (click for details) CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CI005BUILD/config.log/config.log.gz CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CI005BUILD/config.status/config.status

Make failed for CentOS 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CI005BUILD/ErrorLog/log_make.txt)

pimd/pim_msdp.c:723:9: warning: missing braces around initializer [-Wmissing-braces]
pimd/pim_msdp.c:723:9: warning: (near initialization for nexthop.last_lookup) [-Wmissing-braces]
deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.  CC       bgpd/bgp_addpath.o
deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed./home/ci/cibuild.2622/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.2622/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.2622/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.2622/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.2622/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.2622/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
Ubuntu 16.04 arm8 build: Failed (click for details) Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U16ARM8BUILD/config.status/config.status Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U16ARM8BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.2622/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
In file included from pimd/pim_str.h:29:0,
pimd/pim_addr.h:25:5: error: "PIM_IPV" is not defined [-Werror=undef]
 #if PIM_IPV == 4
In file included from pimd/pim_igmp.h:29:0,
pimd/pim_str.h: In function pim_addr_copy:
pimd/pim_str.h:44:6: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h:44:23: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h: In function pim_is_addr_any:
Ubuntu 18.04 amd64 build: Failed (click for details) Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U1804AMD64/config.status/config.status

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U1804AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.2622/frr-source'
In file included from pimd/pim_str.h:29:0,
pimd/pim_addr.h:25:5: error: "PIM_IPV" is not defined, evaluates to 0 [-Werror=undef]
 #if PIM_IPV == 4
In file included from pimd/pim_igmp.h:29:0,
pimd/pim_str.h: In function pim_addr_copy:
pimd/pim_str.h:44:6: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h:44:23: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h: In function pim_is_addr_any:
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/DEB11AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.2622/frr-source'
In file included from pimd/pim_str.h:29,
pimd/pim_addr.h:25:5: error: "PIM_IPV" is not defined, evaluates to 0 [-Werror=undef]
In file included from pimd/pim_igmp.h:29,
pimd/pim_str.h: In function pim_addr_copy:
pimd/pim_str.h:44:6: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h:44:23: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h: In function pim_is_addr_any:
pimd/pim_str.h:49:14: error: pim_addr {aka struct in6_addr} has no member named s_addr

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/DEB11AMD64/config.status/config.status

Ubuntu 16.04 amd64 build: Failed (click for details) Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CI014BUILD/config.log/config.log.gz Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CI014BUILD/config.status/config.status

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CI014BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.2622/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
In file included from pimd/pim_str.h:29:0,
pimd/pim_addr.h:25:5: error: "PIM_IPV" is not defined [-Werror=undef]
 #if PIM_IPV == 4
In file included from pimd/pim_igmp.h:29:0,
pimd/pim_str.h: In function pim_addr_copy:
pimd/pim_str.h:44:6: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h:44:23: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h: In function pim_is_addr_any:
Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U18I386BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.2622/frr-source'
In file included from pimd/pim_str.h:29:0,
pimd/pim_addr.h:25:5: error: "PIM_IPV" is not defined, evaluates to 0 [-Werror=undef]
 #if PIM_IPV == 4
In file included from pimd/pim_igmp.h:29:0,
pimd/pim_str.h: In function pim_addr_copy:
pimd/pim_str.h:44:6: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h:44:23: error: pim_addr {aka struct in6_addr} has no member named s_addr
pimd/pim_str.h: In function pim_is_addr_any:

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U18I386BUILD/config.log/config.log.gz

Report for pim6_main.c | 4 issues
===============================================
ERROR: space required after that close brace '}'
#134: FILE: /tmp/f1-20275/pim6_main.c:134:
+	static struct option longopts[] = {{0}};
Report for pim_addr.c | 4 issues
===============================================
WARNING: Invalid vsprintf pointer extension '%pP'
#65: FILE: /tmp/f1-20275/pim_addr.c:65:
+	return bprintfrr(buf, "(%pPAs,%pPAs)", &sga->src, &sga->grp);
Report for pim_addr.h | 12 issues
===============================================
WARNING: do not add new typedefs
#26: FILE: /tmp/f1-20275/pim_addr.h:26:
+typedef struct in_addr pim_addr;

WARNING: do not add new typedefs
#29: FILE: /tmp/f1-20275/pim_addr.h:29:
+typedef struct in6_addr pim_addr;

WARNING: do not add new typedefs
#39: FILE: /tmp/f1-20275/pim_addr.h:39:
+typedef struct _pim_sgaddr pim_sgaddr;
Report for pim_join.c | 4 issues
===============================================
< WARNING: Invalid vsprintf pointer extension '%pP'
< #90: FILE: /tmp/f1-20275/pim_join.c:90:
< WARNING: Invalid vsprintf pointer extension '%pP'
< #163: FILE: /tmp/f1-20275/pim_join.c:163:
Report for pim_mlag.c | 8 issues
===============================================
< WARNING: Invalid vsprintf pointer extension '%pP'
< #745: FILE: /tmp/f1-20275/pim_mlag.c:745:
< WARNING: Invalid vsprintf pointer extension '%pP'
< #749: FILE: /tmp/f1-20275/pim_mlag.c:749:
< WARNING: Invalid vsprintf pointer extension '%pP'
< #774: FILE: /tmp/f1-20275/pim_mlag.c:774:
< WARNING: Invalid vsprintf pointer extension '%pP'
< #778: FILE: /tmp/f1-20275/pim_mlag.c:778:
Report for pim_oil.c | 4 issues
===============================================
< WARNING: Invalid vsprintf pointer extension '%pP'
< #146: FILE: /tmp/f1-20275/pim_oil.c:146:
< WARNING: Invalid vsprintf pointer extension '%pP'
< #180: FILE: /tmp/f1-20275/pim_oil.c:180:
Report for pim_register.c | 2 issues
===============================================
< WARNING: Invalid vsprintf pointer extension '%pP'
< #418: FILE: /tmp/f1-20275/pim_register.c:418:

@LabN-CI
Copy link
Collaborator

LabN-CI commented Jan 11, 2022

Outdated results 🛑

Basic BGPD CI results: FAILURE

_ _
Result FAILURE git merge/10281 a9a59c9 frr.github Build
Date 01/11/2022
Start 08:36:17
Finish 08:37:10
Run-Time 00:53
Total
Pass
Fail
Valgrind-Errors
Valgrind-Loss
Details vncregress-2022-01-11-08:36:17.txt
Log make-2022-01-11-08:36:17.out.bz2
Memory

For details, please contact louberger

static void pim6_terminate(void)
{
pim_vrf_terminate();
pim_router_terminate();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function pim_router_terminate calls the pim_mlag_terminate but mlag is not initialised in the main function. It is under #if 0. So it seems incorrect.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't call pim_mlag_terminate(), I moved that call. Please read the PR properly.

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jan 12, 2022

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2641/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Addresssanitizer topotests part 9: Failed (click for details) Addresssanitizer topotests part 9: No useful log found
Addresssanitizer topotests part 7: Failed (click for details) Addresssanitizer topotests part 7: No useful log found
Addresssanitizer topotests part 6: Failed (click for details) Addresssanitizer topotests part 6: No useful log found
Addresssanitizer topotests part 3: Failed (click for details) Addresssanitizer topotests part 3: No useful log found
Addresssanitizer topotests part 2: Failed (click for details) Addresssanitizer topotests part 2: No useful log found
Addresssanitizer topotests part 1: Failed (click for details) Addresssanitizer topotests part 1: No useful log found
Addresssanitizer topotests part 8: Failed (click for details) Addresssanitizer topotests part 8: No useful log found
Addresssanitizer topotests part 5: Failed (click for details) Addresssanitizer topotests part 5: No useful log found
Addresssanitizer topotests part 4: Failed (click for details) Addresssanitizer topotests part 4: No useful log found
Addresssanitizer topotests part 0: Failed (click for details) Addresssanitizer topotests part 0: No useful log found
Successful on other platforms/tests
  • Topotests debian 10 amd64 part 5
  • Topotests debian 10 amd64 part 0
  • Ubuntu 16.04 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 2
  • Topotests Ubuntu 18.04 arm8 part 7
  • Topotests Ubuntu 18.04 i386 part 1
  • Topotests Ubuntu 18.04 amd64 part 4
  • Topotests Ubuntu 18.04 i386 part 6
  • IPv4 ldp protocol on Ubuntu 18.04
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests Ubuntu 18.04 arm8 part 6
  • Topotests Ubuntu 18.04 arm8 part 1
  • Topotests debian 10 amd64 part 6
  • Topotests Ubuntu 18.04 arm8 part 8
  • Topotests Ubuntu 18.04 amd64 part 5
  • Topotests Ubuntu 18.04 i386 part 7
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests Ubuntu 18.04 i386 part 5
  • Topotests Ubuntu 18.04 i386 part 0
  • Topotests Ubuntu 18.04 amd64 part 2
  • Topotests Ubuntu 18.04 i386 part 3
  • CentOS 7 rpm pkg check
  • Fedora 29 rpm pkg check
  • Topotests Ubuntu 18.04 amd64 part 0
  • Topotests debian 10 amd64 part 8
  • Topotests Ubuntu 18.04 arm8 part 4
  • Topotests debian 10 amd64 part 9
  • Topotests Ubuntu 18.04 arm8 part 9
  • Topotests Ubuntu 18.04 amd64 part 3
  • IPv6 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 amd64 part 1
  • Debian 9 deb pkg check
  • Ubuntu 18.04 deb pkg check
  • Ubuntu 20.04 deb pkg check
  • Topotests Ubuntu 18.04 i386 part 4
  • Topotests Ubuntu 18.04 amd64 part 8
  • Topotests Ubuntu 18.04 i386 part 9
  • IPv4 protocols on Ubuntu 18.04
  • Topotests debian 10 amd64 part 7
  • Topotests Ubuntu 18.04 arm8 part 0
  • Topotests Ubuntu 18.04 i386 part 8
  • Topotests Ubuntu 18.04 amd64 part 9
  • Debian 10 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 6
  • Topotests debian 10 amd64 part 1
  • Topotests Ubuntu 18.04 arm8 part 3
  • Topotests debian 10 amd64 part 4
  • Topotests Ubuntu 18.04 arm8 part 5
  • Topotests debian 10 amd64 part 2
  • Static analyzer (clang)
  • Topotests debian 10 amd64 part 3

Warnings Generated during build:

Checkout code: Successful with additional warnings
Addresssanitizer topotests part 9: Failed (click for details) Addresssanitizer topotests part 9: No useful log found
Addresssanitizer topotests part 7: Failed (click for details) Addresssanitizer topotests part 7: No useful log found
Addresssanitizer topotests part 6: Failed (click for details) Addresssanitizer topotests part 6: No useful log found
Addresssanitizer topotests part 3: Failed (click for details) Addresssanitizer topotests part 3: No useful log found
Addresssanitizer topotests part 2: Failed (click for details) Addresssanitizer topotests part 2: No useful log found
Addresssanitizer topotests part 1: Failed (click for details) Addresssanitizer topotests part 1: No useful log found
Addresssanitizer topotests part 8: Failed (click for details) Addresssanitizer topotests part 8: No useful log found
Addresssanitizer topotests part 5: Failed (click for details) Addresssanitizer topotests part 5: No useful log found
Addresssanitizer topotests part 4: Failed (click for details) Addresssanitizer topotests part 4: No useful log found
Addresssanitizer topotests part 0: Failed (click for details) Addresssanitizer topotests part 0: No useful log found
Report for pim6_main.c | 4 issues
===============================================
ERROR: space required after that close brace '}'
#134: FILE: /tmp/f1-1919/pim6_main.c:134:
+	static struct option longopts[] = {{0}};
Report for pim_addr.c | 4 issues
===============================================
WARNING: Invalid vsprintf pointer extension '%pP'
#65: FILE: /tmp/f1-1919/pim_addr.c:65:
+	return bprintfrr(buf, "(%pPAs,%pPAs)", &sga->src, &sga->grp);
Report for pim_addr.h | 12 issues
===============================================
WARNING: do not add new typedefs
#26: FILE: /tmp/f1-1919/pim_addr.h:26:
+typedef struct in_addr pim_addr;

WARNING: do not add new typedefs
#29: FILE: /tmp/f1-1919/pim_addr.h:29:
+typedef struct in6_addr pim_addr;

WARNING: do not add new typedefs
#39: FILE: /tmp/f1-1919/pim_addr.h:39:
+typedef struct _pim_sgaddr pim_sgaddr;
Report for pim_join.c | 4 issues
===============================================
< WARNING: Invalid vsprintf pointer extension '%pP'
< #90: FILE: /tmp/f1-1919/pim_join.c:90:
< WARNING: Invalid vsprintf pointer extension '%pP'
< #163: FILE: /tmp/f1-1919/pim_join.c:163:
Report for pim_mlag.c | 8 issues
===============================================
< WARNING: Invalid vsprintf pointer extension '%pP'
< #745: FILE: /tmp/f1-1919/pim_mlag.c:745:
< WARNING: Invalid vsprintf pointer extension '%pP'
< #749: FILE: /tmp/f1-1919/pim_mlag.c:749:
< WARNING: Invalid vsprintf pointer extension '%pP'
< #774: FILE: /tmp/f1-1919/pim_mlag.c:774:
< WARNING: Invalid vsprintf pointer extension '%pP'
< #778: FILE: /tmp/f1-1919/pim_mlag.c:778:
Report for pim_oil.c | 4 issues
===============================================
< WARNING: Invalid vsprintf pointer extension '%pP'
< #146: FILE: /tmp/f1-1919/pim_oil.c:146:
< WARNING: Invalid vsprintf pointer extension '%pP'
< #180: FILE: /tmp/f1-1919/pim_oil.c:180:
Report for pim_register.c | 2 issues
===============================================
< WARNING: Invalid vsprintf pointer extension '%pP'
< #418: FILE: /tmp/f1-1919/pim_register.c:418:

Copy link
Contributor

@mobash-rasool mobash-rasool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are fine. Please fix the style issues and check CI failures.

This newborn pim6d is essentially an empty husk, but it does build
without warnings or errors and has the build system integration prepared
and working.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
Since this is only used in very few places, moving it out of the way is
reasonable.  (`%pSG` will be pim_sgaddr)

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
Depending on whether we're compiling pimd or pim6d, these types take on
the appropriate AF being used.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2660/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Addresssanitizer topotests part 7: Failed (click for details) Addresssanitizer topotests part 7: No useful log found
Addresssanitizer topotests part 5: Failed (click for details) Addresssanitizer topotests part 5: No useful log found
Addresssanitizer topotests part 2: Failed (click for details) Addresssanitizer topotests part 2: No useful log found
Addresssanitizer topotests part 3: Failed (click for details) Addresssanitizer topotests part 3: No useful log found
Addresssanitizer topotests part 9: Failed (click for details) Addresssanitizer topotests part 9: No useful log found
Addresssanitizer topotests part 8: Failed (click for details) Addresssanitizer topotests part 8: No useful log found
Addresssanitizer topotests part 6: Failed (click for details) Addresssanitizer topotests part 6: No useful log found
Addresssanitizer topotests part 0: Failed (click for details) Addresssanitizer topotests part 0: No useful log found
Addresssanitizer topotests part 1: Failed (click for details) Addresssanitizer topotests part 1: No useful log found
Addresssanitizer topotests part 4: Failed (click for details) Addresssanitizer topotests part 4: No useful log found
Successful on other platforms/tests
  • Topotests Ubuntu 18.04 arm8 part 8
  • Topotests debian 10 amd64 part 4
  • Topotests debian 10 amd64 part 9
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests Ubuntu 18.04 i386 part 7
  • Topotests Ubuntu 18.04 amd64 part 3
  • Topotests Ubuntu 18.04 amd64 part 2
  • Topotests Ubuntu 18.04 i386 part 6
  • IPv4 ldp protocol on Ubuntu 18.04
  • Ubuntu 16.04 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 4
  • Topotests debian 10 amd64 part 8
  • Topotests Ubuntu 18.04 arm8 part 4
  • Topotests Ubuntu 18.04 i386 part 1
  • Ubuntu 20.04 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 9
  • Debian 10 deb pkg check
  • IPv6 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 amd64 part 5
  • Topotests Ubuntu 18.04 amd64 part 0
  • Topotests Ubuntu 18.04 arm8 part 2
  • Topotests Ubuntu 18.04 amd64 part 7
  • Fedora 29 rpm pkg check
  • IPv4 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 arm8 part 7
  • Topotests debian 10 amd64 part 0
  • Topotests Ubuntu 18.04 i386 part 3
  • Topotests Ubuntu 18.04 i386 part 8
  • CentOS 7 rpm pkg check
  • Topotests Ubuntu 18.04 arm8 part 5
  • Topotests Ubuntu 18.04 amd64 part 9
  • Static analyzer (clang)
  • Topotests debian 10 amd64 part 1
  • Topotests Ubuntu 18.04 amd64 part 1
  • Topotests Ubuntu 18.04 i386 part 5
  • Topotests Ubuntu 18.04 i386 part 0
  • Topotests debian 10 amd64 part 2
  • Topotests debian 10 amd64 part 7
  • Topotests Ubuntu 18.04 arm8 part 0
  • Topotests Ubuntu 18.04 amd64 part 8
  • Topotests debian 10 amd64 part 3
  • Topotests Ubuntu 18.04 amd64 part 6
  • Ubuntu 18.04 deb pkg check
  • Topotests debian 10 amd64 part 6
  • Topotests Ubuntu 18.04 arm8 part 1
  • Topotests Ubuntu 18.04 arm8 part 6
  • Topotests Ubuntu 18.04 i386 part 4
  • Topotests debian 10 amd64 part 5
  • Topotests Ubuntu 18.04 arm8 part 3
  • Topotests Ubuntu 18.04 i386 part 9
  • Debian 9 deb pkg check

Warnings Generated during build:

Checkout code: Successful with additional warnings
Addresssanitizer topotests part 7: Failed (click for details) Addresssanitizer topotests part 7: No useful log found
Addresssanitizer topotests part 5: Failed (click for details) Addresssanitizer topotests part 5: No useful log found
Addresssanitizer topotests part 2: Failed (click for details) Addresssanitizer topotests part 2: No useful log found
Addresssanitizer topotests part 3: Failed (click for details) Addresssanitizer topotests part 3: No useful log found
Addresssanitizer topotests part 9: Failed (click for details) Addresssanitizer topotests part 9: No useful log found
Addresssanitizer topotests part 8: Failed (click for details) Addresssanitizer topotests part 8: No useful log found
Addresssanitizer topotests part 6: Failed (click for details) Addresssanitizer topotests part 6: No useful log found
Addresssanitizer topotests part 0: Failed (click for details) Addresssanitizer topotests part 0: No useful log found
Addresssanitizer topotests part 1: Failed (click for details) Addresssanitizer topotests part 1: No useful log found
Addresssanitizer topotests part 4: Failed (click for details) Addresssanitizer topotests part 4: No useful log found
Report for pim_addr.c | 4 issues
===============================================
WARNING: Invalid vsprintf pointer extension '%pP'
#65: FILE: /tmp/f1-10611/pim_addr.c:65:
+	return bprintfrr(buf, "(%pPAs,%pPAs)", &sga->src, &sga->grp);
Report for pim_addr.h | 12 issues
===============================================
WARNING: do not add new typedefs
#26: FILE: /tmp/f1-10611/pim_addr.h:26:
+typedef struct in_addr pim_addr;

WARNING: do not add new typedefs
#29: FILE: /tmp/f1-10611/pim_addr.h:29:
+typedef struct in6_addr pim_addr;

WARNING: do not add new typedefs
#39: FILE: /tmp/f1-10611/pim_addr.h:39:
+typedef struct _pim_sgaddr pim_sgaddr;
Report for pim_join.c | 4 issues
===============================================
< WARNING: Invalid vsprintf pointer extension '%pP'
< #90: FILE: /tmp/f1-10611/pim_join.c:90:
< WARNING: Invalid vsprintf pointer extension '%pP'
< #163: FILE: /tmp/f1-10611/pim_join.c:163:
Report for pim_mlag.c | 8 issues
===============================================
< WARNING: Invalid vsprintf pointer extension '%pP'
< #745: FILE: /tmp/f1-10611/pim_mlag.c:745:
< WARNING: Invalid vsprintf pointer extension '%pP'
< #749: FILE: /tmp/f1-10611/pim_mlag.c:749:
< WARNING: Invalid vsprintf pointer extension '%pP'
< #774: FILE: /tmp/f1-10611/pim_mlag.c:774:
< WARNING: Invalid vsprintf pointer extension '%pP'
< #778: FILE: /tmp/f1-10611/pim_mlag.c:778:
Report for pim_oil.c | 4 issues
===============================================
< WARNING: Invalid vsprintf pointer extension '%pP'
< #146: FILE: /tmp/f1-10611/pim_oil.c:146:
< WARNING: Invalid vsprintf pointer extension '%pP'
< #180: FILE: /tmp/f1-10611/pim_oil.c:180:
Report for pim_register.c | 2 issues
===============================================
< WARNING: Invalid vsprintf pointer extension '%pP'
< #418: FILE: /tmp/f1-10611/pim_register.c:418:

@donaldsharp donaldsharp merged commit 26625d5 into FRRouting:master Jan 12, 2022
@eqvinox eqvinox deleted the pim6-skel-addr branch January 12, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants