-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pim6d: add skeleton & address structures #10281
pim6d: add skeleton & address structures #10281
Conversation
This comment has been minimized.
This comment has been minimized.
b8037aa
to
dee3305
Compare
This comment has been minimized.
This comment has been minimized.
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests debian 10 amd64 part 0: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0DEB10AMD64-2454/test Topology Tests failed for Topotests debian 10 amd64 part 0 Successful on other platforms/tests
Warnings Generated during build:Checkout code: Successful with additional warningsTopotests debian 10 amd64 part 0: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0DEB10AMD64-2454/test Topology Tests failed for Topotests debian 10 amd64 part 0
|
1 similar comment
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests debian 10 amd64 part 0: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0DEB10AMD64-2454/test Topology Tests failed for Topotests debian 10 amd64 part 0 Successful on other platforms/tests
Warnings Generated during build:Checkout code: Successful with additional warningsTopotests debian 10 amd64 part 0: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0DEB10AMD64-2454/test Topology Tests failed for Topotests debian 10 amd64 part 0
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has happened once again. We agreed last time that conflicting PRs won't be raised. The same changes are present in #10194. Let's discuss this in today's meeting.
#include "pim_iface.h" | ||
#include "pim_zebra.h" | ||
|
||
zebra_capabilities_t _caps_p[] = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since _caps_p, pimd_privs is all same for pimd daemon, suggest to keep it in a common file, instead of defining it twice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a good idea for 3 reasons:
pim6d
doesn't necessarily need the same capabilities. I think we can actually removeZCAP_BIND
since there is no MSDP in IPv6- there is a pattern of having all these things together like in all other daemons, better to have it the same way
array_size()
doesn't work particularly well withextern
array definitions in C (the array size would need to be copied into the header)
{ | ||
prefix_list_reset(); | ||
access_list_reset(); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a memory leak here, you need to free this memory here, since it was allocated at init time in function pim_router_init.
XFREE(MTYPE_ROUTER, router);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, waiting to rebase on top of #10212
prefix_list_reset(); | ||
access_list_reset(); | ||
|
||
frr_fini(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since pim_vrf_init is initialised, pim_vrf_terminate() should be called here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, waiting to rebase on top of #10212
dee3305
to
a9a59c9
Compare
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: FailedCentOS 8 amd64 build: Failed (click for details)CentOS 8 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CENTOS8BUILD/config.log/config.log.gzMake failed for CentOS 8 amd64 build:
CentOS 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CENTOS8BUILD/config.status/config.status Ubuntu 20.04 amd64 build: Failed (click for details)Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U2004AMD64BUILD/config.log/config.log.gzMake failed for Ubuntu 20.04 amd64 build:
Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U2004AMD64BUILD/config.status/config.status Ubuntu 18.04 arm8 build: Failed (click for details)Make failed for Ubuntu 18.04 arm8 build:
Ubuntu 18.04 arm8 build: Unknown Log <config.log.gz> Debian 9 amd64 build: Failed (click for details)Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CI021BUILD/config.status/config.statusMake failed for Debian 9 amd64 build:
Ubuntu 18.04 ppc64le build: Failed (click for details)Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U1804PPC64LEBUILD/config.status/config.statusMake failed for Ubuntu 18.04 ppc64le build:
Debian 10 amd64 build: Failed (click for details)Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/DEB10BUILD/config.status/config.statusMake failed for Debian 10 amd64 build:
Debian 10 amd64 build: Unknown Log <config.log.gz> Fedora 29 amd64 build: Failed (click for details)Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/F29BUILD/config.log/config.log.gz Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/F29BUILD/config.status/config.statusMake failed for Fedora 29 amd64 build:
Ubuntu 16.04 arm7 build: Failed (click for details)Make failed for Ubuntu 16.04 arm7 build:
Ubuntu 16.04 arm7 build: Unknown Log <config.log.gz> Ubuntu 18.04 arm7 build: Failed (click for details)Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U18ARM7BUILD/config.log/config.log.gzMake failed for Ubuntu 18.04 arm7 build:
Ubuntu 16.04 i386 build: Failed (click for details)Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U1604I386/config.status/config.statusMake failed for Ubuntu 16.04 i386 build:
CentOS 7 amd64 build: Failed (click for details)CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CI005BUILD/config.log/config.log.gz CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CI005BUILD/config.status/config.statusMake failed for CentOS 7 amd64 build:
Ubuntu 16.04 arm8 build: Failed (click for details)Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U16ARM8BUILD/config.status/config.status Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U16ARM8BUILD/config.log/config.log.gzMake failed for Ubuntu 16.04 arm8 build:
Ubuntu 18.04 amd64 build: Failed (click for details)Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U1804AMD64/config.status/config.statusMake failed for Ubuntu 18.04 amd64 build:
Debian 11 amd64 build: Failed (click for details)Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/DEB11AMD64/config.log/config.log.gzMake failed for Debian 11 amd64 build:
Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/DEB11AMD64/config.status/config.status Ubuntu 16.04 amd64 build: Failed (click for details)Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CI014BUILD/config.log/config.log.gz Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CI014BUILD/config.status/config.statusMake failed for Ubuntu 16.04 amd64 build:
Ubuntu 18.04 i386 build: Failed (click for details)Make failed for Ubuntu 18.04 i386 build:
Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U18I386BUILD/config.status/config.status Successful on other platforms/tests
Warnings Generated during build:Checkout code: Successful with additional warningsCentOS 8 amd64 build: Failed (click for details)CentOS 8 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CENTOS8BUILD/config.log/config.log.gzMake failed for CentOS 8 amd64 build:
CentOS 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CENTOS8BUILD/config.status/config.status Ubuntu 20.04 amd64 build: Failed (click for details)Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U2004AMD64BUILD/config.log/config.log.gzMake failed for Ubuntu 20.04 amd64 build:
Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U2004AMD64BUILD/config.status/config.status Ubuntu 18.04 arm8 build: Failed (click for details)Make failed for Ubuntu 18.04 arm8 build:
Ubuntu 18.04 arm8 build: Unknown Log <config.log.gz> Debian 9 amd64 build: Failed (click for details)Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CI021BUILD/config.status/config.statusMake failed for Debian 9 amd64 build:
Ubuntu 18.04 ppc64le build: Failed (click for details)Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U1804PPC64LEBUILD/config.status/config.statusMake failed for Ubuntu 18.04 ppc64le build:
Debian 10 amd64 build: Failed (click for details)Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/DEB10BUILD/config.status/config.statusMake failed for Debian 10 amd64 build:
Debian 10 amd64 build: Unknown Log <config.log.gz> Fedora 29 amd64 build: Failed (click for details)Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/F29BUILD/config.log/config.log.gz Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/F29BUILD/config.status/config.statusMake failed for Fedora 29 amd64 build:
Ubuntu 16.04 arm7 build: Failed (click for details)Make failed for Ubuntu 16.04 arm7 build:
Ubuntu 16.04 arm7 build: Unknown Log <config.log.gz> Ubuntu 18.04 arm7 build: Failed (click for details)Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U18ARM7BUILD/config.log/config.log.gzMake failed for Ubuntu 18.04 arm7 build:
Ubuntu 16.04 i386 build: Failed (click for details)Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U1604I386/config.status/config.statusMake failed for Ubuntu 16.04 i386 build:
CentOS 7 amd64 build: Failed (click for details)CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CI005BUILD/config.log/config.log.gz CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CI005BUILD/config.status/config.statusMake failed for CentOS 7 amd64 build:
Ubuntu 16.04 arm8 build: Failed (click for details)Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U16ARM8BUILD/config.status/config.status Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U16ARM8BUILD/config.log/config.log.gzMake failed for Ubuntu 16.04 arm8 build:
Ubuntu 18.04 amd64 build: Failed (click for details)Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U1804AMD64/config.status/config.statusMake failed for Ubuntu 18.04 amd64 build:
Debian 11 amd64 build: Failed (click for details)Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/DEB11AMD64/config.log/config.log.gzMake failed for Debian 11 amd64 build:
Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/DEB11AMD64/config.status/config.status Ubuntu 16.04 amd64 build: Failed (click for details)Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CI014BUILD/config.log/config.log.gz Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/CI014BUILD/config.status/config.statusMake failed for Ubuntu 16.04 amd64 build:
Ubuntu 18.04 i386 build: Failed (click for details)Make failed for Ubuntu 18.04 i386 build:
Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2622/artifact/U18I386BUILD/config.status/config.status
|
Outdated results 🛑Basic BGPD CI results: FAILURE
For details, please contact louberger |
static void pim6_terminate(void) | ||
{ | ||
pim_vrf_terminate(); | ||
pim_router_terminate(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function pim_router_terminate calls the pim_mlag_terminate but mlag is not initialised in the main function. It is under #if 0. So it seems incorrect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't call pim_mlag_terminate()
, I moved that call. Please read the PR properly.
a9a59c9
to
6f4a406
Compare
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedAddresssanitizer topotests part 9: Failed (click for details)Addresssanitizer topotests part 9: No useful log foundAddresssanitizer topotests part 7: Failed (click for details)Addresssanitizer topotests part 7: No useful log foundAddresssanitizer topotests part 6: Failed (click for details)Addresssanitizer topotests part 6: No useful log foundAddresssanitizer topotests part 3: Failed (click for details)Addresssanitizer topotests part 3: No useful log foundAddresssanitizer topotests part 2: Failed (click for details)Addresssanitizer topotests part 2: No useful log foundAddresssanitizer topotests part 1: Failed (click for details)Addresssanitizer topotests part 1: No useful log foundAddresssanitizer topotests part 8: Failed (click for details)Addresssanitizer topotests part 8: No useful log foundAddresssanitizer topotests part 5: Failed (click for details)Addresssanitizer topotests part 5: No useful log foundAddresssanitizer topotests part 4: Failed (click for details)Addresssanitizer topotests part 4: No useful log foundAddresssanitizer topotests part 0: Failed (click for details)Addresssanitizer topotests part 0: No useful log foundSuccessful on other platforms/tests
Warnings Generated during build:Checkout code: Successful with additional warningsAddresssanitizer topotests part 9: Failed (click for details)Addresssanitizer topotests part 9: No useful log foundAddresssanitizer topotests part 7: Failed (click for details)Addresssanitizer topotests part 7: No useful log foundAddresssanitizer topotests part 6: Failed (click for details)Addresssanitizer topotests part 6: No useful log foundAddresssanitizer topotests part 3: Failed (click for details)Addresssanitizer topotests part 3: No useful log foundAddresssanitizer topotests part 2: Failed (click for details)Addresssanitizer topotests part 2: No useful log foundAddresssanitizer topotests part 1: Failed (click for details)Addresssanitizer topotests part 1: No useful log foundAddresssanitizer topotests part 8: Failed (click for details)Addresssanitizer topotests part 8: No useful log foundAddresssanitizer topotests part 5: Failed (click for details)Addresssanitizer topotests part 5: No useful log foundAddresssanitizer topotests part 4: Failed (click for details)Addresssanitizer topotests part 4: No useful log foundAddresssanitizer topotests part 0: Failed (click for details)Addresssanitizer topotests part 0: No useful log found
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes are fine. Please fix the style issues and check CI failures.
This newborn pim6d is essentially an empty husk, but it does build without warnings or errors and has the build system integration prepared and working. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
Since this is only used in very few places, moving it out of the way is reasonable. (`%pSG` will be pim_sgaddr) Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
Depending on whether we're compiling pimd or pim6d, these types take on the appropriate AF being used. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
6f4a406
to
26625d5
Compare
Continuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedAddresssanitizer topotests part 7: Failed (click for details)Addresssanitizer topotests part 7: No useful log foundAddresssanitizer topotests part 5: Failed (click for details)Addresssanitizer topotests part 5: No useful log foundAddresssanitizer topotests part 2: Failed (click for details)Addresssanitizer topotests part 2: No useful log foundAddresssanitizer topotests part 3: Failed (click for details)Addresssanitizer topotests part 3: No useful log foundAddresssanitizer topotests part 9: Failed (click for details)Addresssanitizer topotests part 9: No useful log foundAddresssanitizer topotests part 8: Failed (click for details)Addresssanitizer topotests part 8: No useful log foundAddresssanitizer topotests part 6: Failed (click for details)Addresssanitizer topotests part 6: No useful log foundAddresssanitizer topotests part 0: Failed (click for details)Addresssanitizer topotests part 0: No useful log foundAddresssanitizer topotests part 1: Failed (click for details)Addresssanitizer topotests part 1: No useful log foundAddresssanitizer topotests part 4: Failed (click for details)Addresssanitizer topotests part 4: No useful log foundSuccessful on other platforms/tests
Warnings Generated during build:Checkout code: Successful with additional warningsAddresssanitizer topotests part 7: Failed (click for details)Addresssanitizer topotests part 7: No useful log foundAddresssanitizer topotests part 5: Failed (click for details)Addresssanitizer topotests part 5: No useful log foundAddresssanitizer topotests part 2: Failed (click for details)Addresssanitizer topotests part 2: No useful log foundAddresssanitizer topotests part 3: Failed (click for details)Addresssanitizer topotests part 3: No useful log foundAddresssanitizer topotests part 9: Failed (click for details)Addresssanitizer topotests part 9: No useful log foundAddresssanitizer topotests part 8: Failed (click for details)Addresssanitizer topotests part 8: No useful log foundAddresssanitizer topotests part 6: Failed (click for details)Addresssanitizer topotests part 6: No useful log foundAddresssanitizer topotests part 0: Failed (click for details)Addresssanitizer topotests part 0: No useful log foundAddresssanitizer topotests part 1: Failed (click for details)Addresssanitizer topotests part 1: No useful log foundAddresssanitizer topotests part 4: Failed (click for details)Addresssanitizer topotests part 4: No useful log found
|
Start some mergeable progress towards
pim6d
This replaces PR #10194 (unlike that PR, this one is not WIP, compiles, produces sensible output and can actually be merged)
This also partially replaces PRs #10278 / #10192 which I had previously commented/NAKd; at this point it seems a better allocation of my time to just do it rather than try to steer with reviews.