pimd: Data structure changes to accommodate address family for IPv4 and IPv6 #10212

mobash-rasool · 2021-12-14T11:46:19Z

PIM_ADDR will be controlled at compile time for IPv4 and IPv6.
in_addr and in6_addr will be compiled for the respective daemons.
Added few macros to access some common addresses.

Please refer #10194 for the pimv6
compilation stuff.
pim_str.h will be included only for pimv4 compilation.

Issue: #10023
Co-authored-by: Sarita Patra saritap@vmware.com
Signed-off-by: Mobashshera Rasool mrasool@vmware.com

NetDEF-CI · 2021-12-14T12:21:11Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2114/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

OpenBSD 6 amd64 build: Failed (click for details)

OpenBSD 6 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2114/artifact/CI011BUILD/frr.xref.xz/frr.xref.xz OpenBSD 6 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2114/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2114/artifact/CI011BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for OpenBSD 6 amd64 build:
(see full PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2114/artifact/CI011BUILD/ErrorLog/log_pytests.txt)

=================================== FAILURES ===================================
_________________________ TestMpath.test_exit_cleanly __________________________
self = <test_mpath.TestMpath object at 0x1b924c0e61d0>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:108: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrsix.py:62: in reraise
    raise value
helpers/python/frrtest.py:82: in _run_tests
    test(self)
helpers/python/frrtest.py:100: in matchfunction
    method(self, *args, **kwargs)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <test_mpath.TestMpath object at 0x1b924c0e61d0>
    def _exit_cleanly(self):
        if self.exitcode != 0:
>           raise MultiTestFailure("Program did not terminate with exit code 0")
E           frrtest.MultiTestFailure: Program did not terminate with exit code 0
helpers/python/frrtest.py:90: MultiTestFailure
----------------------------- Captured stderr call -----------------------------
2021/12/14 04:10:37 [YAF85-253AP][EC 100663299] buffer_write: write error on fd 0: Bad file descriptor
2021/12/14 04:10:37 [X6B3Y-6W42R][EC 100663302] zclient_send_message: buffer_write failed to zclient fd 0, closing
___________________ TestMpath.test_bgp_maximum_paths_config ____________________
self = <test_mpath.TestMpath object at 0x1b9267a31cf8>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:108: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrsix.py:62: in reraise
    raise value
helpers/python/frrtest.py:82: in _run_tests
    test(self)
helpers/python/frrtest.py:100: in matchfunction
    method(self, *args, **kwargs)
helpers/python/frrtest.py:152: in _okfail
    self._onesimple(line)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <test_mpath.TestMpath object at 0x1b924c0e61d0>
line = b'bgp maximum-paths config'
    def _onesimple(self, line):
        if type(line) is str:
            line = line.encode("utf8")
        idx = self.output.find(line)
        if idx != -1:
            self.output = self.output[idx + len(line) :]
        else:
>           raise MultiTestFailure("%r could not be found" % line)
E           frrtest.MultiTestFailure: b'bgp maximum-paths config' could not be found
helpers/python/frrtest.py:149: MultiTestFailure
__________________________ TestMpath.test_bgp_mp_list __________________________
self = <test_mpath.TestMpath object at 0x1b924c0dd048>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:108: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrsix.py:62: in reraise
    raise value
helpers/python/frrtest.py:82: in _run_tests
    test(self)
helpers/python/frrtest.py:100: in matchfunction
    method(self, *args, **kwargs)
helpers/python/frrtest.py:152: in _okfail
    self._onesimple(line)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <test_mpath.TestMpath object at 0x1b924c0e61d0>, line = b'bgp_mp_list'
    def _onesimple(self, line):
        if type(line) is str:
            line = line.encode("utf8")
        idx = self.output.find(line)
        if idx != -1:
            self.output = self.output[idx + len(line) :]
        else:
>           raise MultiTestFailure("%r could not be found" % line)
E           frrtest.MultiTestFailure: b'bgp_mp_list' could not be found
helpers/python/frrtest.py:149: MultiTestFailure
__________________ TestMpath.test_bgp_path_info_mpath_update ___________________
self = <test_mpath.TestMpath object at 0x1b92a5172710>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:108: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrsix.py:62: in reraise
    raise value
helpers/python/frrtest.py:82: in _run_tests
    test(self)
helpers/python/frrtest.py:100: in matchfunction
    method(self, *args, **kwargs)
helpers/python/frrtest.py:152: in _okfail

Successful on other platforms/tests

Fedora 29 amd64 build
Ubuntu 20.04 amd64 build
Ubuntu 18.04 arm8 build
Debian 9 amd64 build
Debian 10 amd64 build
FreeBSD 11 amd64 build
Ubuntu 18.04 ppc64le build
Ubuntu 16.04 arm7 build
Ubuntu 16.04 arm8 build
Ubuntu 18.04 amd64 build
Debian 11 amd64 build
Ubuntu 18.04 i386 build
NetBSD 8 amd64 build
Ubuntu 18.04 arm7 build
Ubuntu 16.04 amd64 build
CentOS 7 amd64 build
CentOS 8 amd64 build
FreeBSD 12 amd64 build
Ubuntu 16.04 i386 build

mobash-rasool · 2021-12-14T13:37:10Z

ci:rerun

NetDEF-CI · 2021-12-14T13:38:45Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2113/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

NetDEF-CI · 2021-12-14T15:28:58Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2120/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 8: Failed (click for details)

Topotests Ubuntu 18.04 i386 part 8: No useful log found

Successful on other platforms/tests

Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 i386 part 6
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 7
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 1
Addresssanitizer topotests part 9
Fedora 29 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 7
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 2
Addresssanitizer topotests part 3
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 18.04 i386 part 7
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 amd64 part 3
Addresssanitizer topotests part 6
Topotests debian 10 amd64 part 9
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 i386 part 0
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 amd64 part 2
Debian 10 deb pkg check
IPv6 protocols on Ubuntu 18.04
Topotests Ubuntu 18.04 arm8 part 4
Topotests debian 10 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 9
Topotests Ubuntu 18.04 amd64 part 1
Addresssanitizer topotests part 1
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 i386 part 4
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 i386 part 9
IPv4 protocols on Ubuntu 18.04
Debian 9 deb pkg check
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 amd64 part 9
Topotests Ubuntu 18.04 i386 part 3
Addresssanitizer topotests part 8
Addresssanitizer topotests part 7
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 arm8 part 5
Topotests Ubuntu 18.04 arm8 part 3
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 1
Static analyzer (clang)
Topotests Ubuntu 18.04 arm8 part 0
Ubuntu 16.04 deb pkg check
IPv4 ldp protocol on Ubuntu 18.04
Topotests debian 10 amd64 part 2
Addresssanitizer topotests part 0

NetDEF-CI · 2021-12-14T15:58:14Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2122/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 amd64 part 8: Failed (click for details)

Topotests Ubuntu 18.04 amd64 part 8: No useful log found

Successful on other platforms/tests

Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 amd64 part 5
Addresssanitizer topotests part 2
IPv4 ldp protocol on Ubuntu 18.04
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 arm8 part 1
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 amd64 part 7
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 i386 part 2
Topotests debian 10 amd64 part 5
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 arm8 part 7
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 arm8 part 8
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 i386 part 7
Fedora 29 rpm pkg check
Addresssanitizer topotests part 6
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 0
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 i386 part 0
Topotests debian 10 amd64 part 8
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 4
Topotests Ubuntu 18.04 arm8 part 9
Debian 10 deb pkg check
Debian 9 deb pkg check
Topotests debian 10 amd64 part 3
IPv6 protocols on Ubuntu 18.04
Topotests Ubuntu 18.04 amd64 part 1
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 i386 part 9
Topotests Ubuntu 18.04 i386 part 3
IPv4 protocols on Ubuntu 18.04
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 i386 part 8
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 amd64 part 9
Topotests debian 10 amd64 part 4
Addresssanitizer topotests part 7
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 arm8 part 5
Addresssanitizer topotests part 5
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 arm8 part 3
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 arm8 part 0
Static analyzer (clang)
Ubuntu 16.04 deb pkg check
Addresssanitizer topotests part 0

mobash-rasool · 2021-12-14T16:07:32Z

ci:rerun

NetDEF-CI · 2021-12-14T18:03:00Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2126/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

NetDEF-CI · 2021-12-14T19:19:06Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2132/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

NetDEF-CI · 2021-12-15T09:01:49Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2146/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topotests Ubuntu 18.04 amd64 part 9: No useful log found

Successful on other platforms/tests

Topotests Ubuntu 18.04 arm8 part 8
Addresssanitizer topotests part 7
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 i386 part 2
Ubuntu 16.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 2
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 i386 part 1
IPv4 ldp protocol on Ubuntu 18.04
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 amd64 part 4
Topotests debian 10 amd64 part 8
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 4
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 amd64 part 0
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 arm8 part 9
Debian 10 deb pkg check
IPv6 protocols on Ubuntu 18.04
Fedora 29 rpm pkg check
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 arm8 part 7
Addresssanitizer topotests part 3
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 i386 part 3
IPv4 protocols on Ubuntu 18.04
CentOS 7 rpm pkg check
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 i386 part 5
Static analyzer (clang)
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 amd64 part 1
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 i386 part 0
Topotests debian 10 amd64 part 1
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 arm8 part 5
Topotests Ubuntu 18.04 amd64 part 6
Addresssanitizer topotests part 0
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 arm8 part 6
Topotests debian 10 amd64 part 3
Topotests debian 10 amd64 part 6
Topotests debian 10 amd64 part 5
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 18.04 i386 part 9
Topotests debian 10 amd64 part 4
Addresssanitizer topotests part 4
Debian 9 deb pkg check

NetDEF-CI · 2021-12-15T13:49:24Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.2172/frr-source'
In file included from pimd/pim_iface.h:31:0,
pimd/pim_igmp.h:97:18: error: duplicate member querier_addr
Makefile:9264: recipe for target 'pimd/pim_assert.o' failed
make[1]: *** [pimd/pim_assert.o] Error 1
In file included from pimd/pim_iface.h:31:0,
pimd/pim_igmp.h:97:18: error: duplicate member querier_addr
Makefile:9264: recipe for target 'pimd/pim_bfd.o' failed
make[1]: *** [pimd/pim_bfd.o] Error 1

Ubuntu 18.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/U18ARM8BUILD/config.log/config.log.gz
Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/U18ARM8BUILD/config.status/config.status

Debian 9 amd64 build: Failed (click for details)

Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/CI021BUILD/config.status/config.status

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/CI021BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.2172/frr-source'
In file included from pimd/pim_iface.h:31:0,
pimd/pim_igmp.h:97:18: error: duplicate member querier_addr
Makefile:9264: recipe for target 'pimd/pim_assert.o' failed
make[1]: *** [pimd/pim_assert.o] Error 1
In file included from pimd/pim_iface.h:31:0,
pimd/pim_igmp.h:97:18: error: duplicate member querier_addr
Makefile:9264: recipe for target 'pimd/pim_bfd.o' failed
make[1]: *** [pimd/pim_bfd.o] Error 1

CentOS 8 amd64 build: Failed (click for details)

CentOS 8 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/CENTOS8BUILD/config.log/config.log.gz

Make failed for CentOS 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/CENTOS8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.2172/frr-source'
In file included from pimd/pim_iface.h:31,
pimd/pim_igmp.h:97:18: error: duplicate member querier_addr
make[1]: *** [Makefile:9890: pimd/pim_assert.o] Error 1
In file included from pimd/pim_iface.h:31,
pimd/pim_igmp.h:97:18: error: duplicate member querier_addr
make[1]: *** [Makefile:9890: pimd/pim_bfd.o] Error 1
In file included from pimd/pim_iface.h:31,
pimd/pim_igmp.h:97:18: error: duplicate member querier_addr

CentOS 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/CENTOS8BUILD/config.status/config.status

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/U2004AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.2172/frr-source'
In file included from pimd/pim_iface.h:31,
pimd/pim_igmp.h:97:18: error: duplicate member querier_addr
make[1]: *** [Makefile:9891: pimd/pim_assert.o] Error 1
In file included from pimd/pim_iface.h:31,
pimd/pim_igmp.h:97:18: error: duplicate member querier_addr
make[1]: *** [Makefile:9891: pimd/pim_bfd.o] Error 1
In file included from pimd/pim_iface.h:31,
pimd/pim_igmp.h:97:18: error: duplicate member querier_addr

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/U2004AMD64BUILD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details)

Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/U1804PPC64LEBUILD/config.status/config.status

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.2172/frr-source'
In file included from pimd/pim_iface.h:31:0,
pimd/pim_igmp.h:97:18: error: duplicate member querier_addr
Makefile:9264: recipe for target 'pimd/pim_assert.o' failed
make[1]: *** [pimd/pim_assert.o] Error 1
In file included from pimd/pim_iface.h:31:0,
pimd/pim_igmp.h:97:18: error: duplicate member querier_addr
Makefile:9264: recipe for target 'pimd/pim_bfd.o' failed
make[1]: *** [pimd/pim_bfd.o] Error 1

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/DEB10BUILD/config.status/config.status

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/DEB10BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.2172/frr-source'
In file included from pimd/pim_iface.h:31,
pimd/pim_igmp.h:97:18: error: duplicate member querier_addr
make[1]: *** [Makefile:9891: pimd/pim_assert.o] Error 1
In file included from pimd/pim_iface.h:31,
pimd/pim_igmp.h:97:18: error: duplicate member querier_addr
make[1]: *** [Makefile:9891: pimd/pim_bfd.o] Error 1
In file included from pimd/pim_iface.h:31,
pimd/pim_igmp.h:97:18: error: duplicate member querier_addr

Debian 10 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/DEB10BUILD/config.log/config.log.gz

Fedora 29 amd64 build: Failed (click for details)

Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/F29BUILD/config.log/config.log.gz Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/F29BUILD/config.status/config.status

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/F29BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.2172/frr-source'
In file included from pimd/pim_iface.h:31,
pimd/pim_igmp.h:97:18: error: duplicate member querier_addr
make[1]: *** [Makefile:9890: pimd/pim_assert.o] Error 1
In file included from pimd/pim_iface.h:31,
pimd/pim_igmp.h:97:18: error: duplicate member querier_addr
make[1]: *** [Makefile:9890: pimd/pim_bfd.o] Error 1
In file included from pimd/pim_iface.h:31,
pimd/pim_igmp.h:97:18: error: duplicate member querier_addr

Ubuntu 18.04 arm7 build: Failed (click for details)

Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.2172/frr-source'
In file included from pimd/pim_iface.h:31:0,
pimd/pim_igmp.h:97:18: error: duplicate member querier_addr
Makefile:9264: recipe for target 'pimd/pim_assert.o' failed
make[1]: *** [pimd/pim_assert.o] Error 1
In file included from pimd/pim_iface.h:31:0,
pimd/pim_igmp.h:97:18: error: duplicate member querier_addr
Makefile:9264: recipe for target 'pimd/pim_bfd.o' failed
make[1]: *** [pimd/pim_bfd.o] Error 1

FreeBSD 11 amd64 build: Failed (click for details)

FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.2172/frr-source'
In file included from pimd/pim_iface.h:31,
pimd/pim_igmp.h:97:18: error: duplicate member 'querier_addr'
gmake[1]: *** [Makefile:9893: pimd/pim_assert.o] Error 1
In file included from pimd/pim_iface.h:31,
pimd/pim_igmp.h:97:18: error: duplicate member 'querier_addr'
gmake[1]: *** [Makefile:9893: pimd/pim_bfd.o] Error 1
In file included from pimd/pim_iface.h:31,
pimd/pim_igmp.h:97:18: error: duplicate member 'querier_addr'

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/CI101BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.2172/frr-source'
In file included from pimd/pim_iface.h:31:0,
pimd/pim_igmp.h:97:18: error: duplicate member querier_addr
Makefile:9264: recipe for target 'pimd/pim_assert.o' failed
make[1]: *** [pimd/pim_assert.o] Error 1
In file included from pimd/pim_iface.h:31:0,
pimd/pim_igmp.h:97:18: error: duplicate member querier_addr
Makefile:9264: recipe for target 'pimd/pim_bfd.o' failed
make[1]: *** [pimd/pim_bfd.o] Error 1

Ubuntu 16.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/CI101BUILD/config.log/config.log.gz
Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/CI101BUILD/config.status/config.status

Ubuntu 16.04 i386 build: Failed (click for details)

Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/U1604I386/config.status/config.status

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/U1604I386/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.2172/frr-source'
In file included from pimd/pim_iface.h:31:0,
pimd/pim_igmp.h:97:18: error: duplicate member querier_addr
Makefile:9264: recipe for target 'pimd/pim_assert.o' failed
make[1]: *** [pimd/pim_assert.o] Error 1
In file included from pimd/pim_iface.h:31:0,
pimd/pim_igmp.h:97:18: error: duplicate member querier_addr
Makefile:9264: recipe for target 'pimd/pim_bfd.o' failed
make[1]: *** [pimd/pim_bfd.o] Error 1

Ubuntu 18.04 amd64 build: Failed (click for details)

Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/U1804AMD64/config.status/config.status

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/U1804AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.2172/frr-source'
In file included from pimd/pim_iface.h:31:0,
pimd/pim_igmp.h:97:18: error: duplicate member querier_addr
Makefile:9264: recipe for target 'pimd/pim_assert.o' failed
make[1]: *** [pimd/pim_assert.o] Error 1
In file included from pimd/pim_iface.h:31:0,
pimd/pim_igmp.h:97:18: error: duplicate member querier_addr
Makefile:9264: recipe for target 'pimd/pim_bfd.o' failed
make[1]: *** [pimd/pim_bfd.o] Error 1

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/DEB11AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.2172/frr-source'
In file included from pimd/pim_iface.h:31,
pimd/pim_igmp.h:97:18: error: duplicate member querier_addr
make[1]: *** [Makefile:9894: pimd/pim_assert.o] Error 1
In file included from pimd/pim_iface.h:31,
pimd/pim_igmp.h:97:18: error: duplicate member querier_addr
make[1]: *** [Makefile:9894: pimd/pim_bfd.o] Error 1
In file included from pimd/pim_iface.h:31,
pimd/pim_igmp.h:97:18: error: duplicate member querier_addr

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/DEB11AMD64/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.2172/frr-source'
In file included from pimd/pim_iface.h:31:0,
pimd/pim_igmp.h:97:18: error: duplicate member 'querier_addr'
gmake[1]: *** [Makefile:9890: pimd/pim_assert.o] Error 1
In file included from pimd/pim_iface.h:31:0,
pimd/pim_igmp.h:97:18: error: duplicate member 'querier_addr'
gmake[1]: *** [Makefile:9890: pimd/pim_bfd.o] Error 1
In file included from pimd/pim_iface.h:31:0,
pimd/pim_igmp.h:97:18: error: duplicate member 'querier_addr'

Ubuntu 16.04 amd64 build: Failed (click for details)

Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/CI014BUILD/config.log/config.log.gz Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/CI014BUILD/config.status/config.status

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/CI014BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.2172/frr-source'
In file included from pimd/pim_iface.h:31:0,
pimd/pim_igmp.h:97:18: error: duplicate member querier_addr
Makefile:9264: recipe for target 'pimd/pim_assert.o' failed
make[1]: *** [pimd/pim_assert.o] Error 1
In file included from pimd/pim_iface.h:31:0,
pimd/pim_igmp.h:97:18: error: duplicate member querier_addr
Makefile:9264: recipe for target 'pimd/pim_bfd.o' failed
make[1]: *** [pimd/pim_bfd.o] Error 1

Ubuntu 16.04 arm8 build: Failed (click for details)

Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/U16ARM8BUILD/config.status/config.status Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/U16ARM8BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.2172/frr-source'
In file included from pimd/pim_iface.h:31:0,
pimd/pim_igmp.h:97:18: error: duplicate member querier_addr
Makefile:9264: recipe for target 'pimd/pim_assert.o' failed
make[1]: *** [pimd/pim_assert.o] Error 1
In file included from pimd/pim_iface.h:31:0,
pimd/pim_igmp.h:97:18: error: duplicate member querier_addr
Makefile:9264: recipe for target 'pimd/pim_bfd.o' failed
make[1]: *** [pimd/pim_bfd.o] Error 1

CentOS 7 amd64 build: Failed (click for details)

CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/CI005BUILD/config.log/config.log.gz CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/CI005BUILD/config.status/config.status

Make failed for CentOS 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/CI005BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory `/home/ci/cibuild.2172/frr-source'
In file included from pimd/pim_iface.h:31:0,
pimd/pim_igmp.h:97:18: error: duplicate member querier_addr
make[1]: *** [pimd/pim_assert.o] Error 1
In file included from pimd/pim_iface.h:31:0,
pimd/pim_igmp.h:97:18: error: duplicate member querier_addr
make[1]: *** [pimd/pim_bfd.o] Error 1
In file included from pimd/pim_iface.h:31:0,
pimd/pim_igmp.h:97:18: error: duplicate member querier_addr

Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/U18I386BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.2172/frr-source'
In file included from pimd/pim_iface.h:31:0,
pimd/pim_igmp.h:97:18: error: duplicate member querier_addr
Makefile:9264: recipe for target 'pimd/pim_assert.o' failed
make[1]: *** [pimd/pim_assert.o] Error 1
In file included from pimd/pim_iface.h:31:0,
pimd/pim_igmp.h:97:18: error: duplicate member querier_addr
Makefile:9264: recipe for target 'pimd/pim_bfd.o' failed
make[1]: *** [pimd/pim_bfd.o] Error 1

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/U18I386BUILD/config.log/config.log.gz

NetBSD 8 amd64 build: Failed (click for details)

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/CI012BUILD/config.status/config.status

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/CI012BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/home/ci/cibuild.2172/frr-source'
In file included from pimd/pim_iface.h:31:0,
pimd/pim_igmp.h:97:18: error: duplicate member 'querier_addr'
In file included from pimd/pim_iface.h:31:0,
pimd/pim_igmp.h:97:18: error: duplicate member 'querier_addr'
gmake[1]: *** [Makefile:9894: pimd/pim_assert.o] Error 1
gmake[1]: *** [Makefile:9894: pimd/pim_bfd.o] Error 1
In file included from pimd/pim_iface.h:31:0,
pimd/pim_igmp.h:97:18: error: duplicate member 'querier_addr'

NetBSD 8 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2172/artifact/CI012BUILD/config.log/config.log.gz

Successful on other platforms/tests

OpenBSD 6 amd64 build

PIM_ADDR will be controlled at compile time for IPv4 and IPv6. in_addr and in6_addr will be compiled for the respective daemons. Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>

Added apis which will be decided on compile time for pimd and pim6d daemon Reviewed-by: Sarita Patra <saritap@vmware.com> Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>

mobash-rasool · 2022-01-10T09:55:52Z

Can you please:

put 3ddf018 in a separate PR with nothing else so it can be merged immediately

remove the PIM_PREFIX change (and 3ddf018) from this PR so it can be merged

Thanks David for your comments. I have fixed it.

NetDEF-CI · 2022-01-10T12:23:03Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2581/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for pim_str.h | 2 issues
===============================================
< WARNING: do not add new typedefs
< #29: FILE: /tmp/f1-17196/pim_str.h:29:

eqvinox

Two mistakes left to fix

pimd/pim_assert.c

mobash-rasool · 2022-01-11T05:08:31Z

Two mistakes left to fix

Thanks David. Have fixed it.

Changed struct in_addr ifassert_winner to pim_addr which will be used in both IPv4 and IPv6(Both MLD and IGMP). Reviewed-by: Sarita Patra <saritap@vmware.com> Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>

This change is to accomodate IPv6 and IPv4 in the same code. Based on pimd or pim6d, this will be compiled. Reviewed-by: Sarita Patra <saritap@vmware.com> Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>

Based on compiler option, pim_addr will be changed to in_addr or in6_addr for pimd and pim6d respectively. Reviewed-by: Sarita Patra <saritap@vmware.com> Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>

Changed struct in_addr source_addr to pim_addr source_addr in struct igmp_join which is to be used in both IPv4 and IPv6(Both MLD and IGMP). Reviewed-by: Sarita Patra <saritap@vmware.com> Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>

Changed struct in_addr source_addr to pim_addr source_addr in struct igmp_source which is to be used in both IPv4 and IPv6(Both MLD and IGMP). Reviewed-by: Sarita Patra <saritap@vmware.com> Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>

Changed struct in_addr group to struct pim_addr group which is to be used in both IPv4 and IPv6(Both MLD and IGMP). Reviewed-by: Sarita Patra <saritap@vmware.com> Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>

Changed struct in_addr address to struct pim_addr in struct pim_iface_upstream_switch which is to be used in both IPv4 and IPv6(Both MLD and IGMP). Reviewed-by: Mobashshera Rasool <mrasool@vmware.com> Signed-off-by: sarita patra <saritap@vmware.com>

Changed struct in_addr group_addr to struct PIM_ADDR group_addr in struct igmp_group which is to be used in both IPv4 and IPv6(Both MLD and IGMP). Reviewed-by: Mobashshera Rasool <mrasool@vmware.com> Signed-off-by: sarita patra <saritap@vmware.com>

Changed struct in_addr last_lookup to struct PIM_ADDR last_lookup which is to be used in both IPv4 and IPv6(Both MLD and IGMP). Reviewed-by: Mobashshera Rasool <mrasool@vmware.com> Signed-off-by: sarita patra <saritap@vmware.com>

Changed struct in_addr upstream_addr and struct in_addr upstream_register to struct PIM_ADDR upstream_addr and struct PIM_ADDR upstream_register which are to be used in both IPv4 and IPv6(Both MLD and IGMP). Reviewed-by: Mobashshera Rasool <mrasool@vmware.com> Signed-off-by: sarita patra <saritap@vmware.com>

Changed struct in_addr source_addr to struct PIM_ADDR source_addr which is to be used in both IPv4 and IPv6(Both MLD and IGMP). Reviewed-by: Mobashshera Rasool <mrasool@vmware.com> Signed-off-by: sarita patra <saritap@vmware.com>

eqvinox

Merging when CI is green

NetDEF-CI · 2022-01-11T07:43:32Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2602/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for pim_str.h | 2 issues
===============================================
< WARNING: do not add new typedefs
< #29: FILE: /tmp/f1-13865/pim_str.h:29:

NetDEF-CI · 2022-01-11T07:56:58Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2601/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-2601/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2601/artifact/TOPO9U18I386/ErrorLog/log_topotests.txt

Successful on other platforms/tests

CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 arm8 part 5
Addresssanitizer topotests part 6
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 0
Static analyzer (clang)
Topotests Ubuntu 18.04 i386 part 5
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 amd64 part 6
Topotests debian 10 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 1
Topotests Ubuntu 18.04 arm8 part 6
Ubuntu 18.04 deb pkg check
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 arm8 part 1
Topotests debian 10 amd64 part 6
Topotests debian 10 amd64 part 5
Debian 9 deb pkg check
Addresssanitizer topotests part 8
Topotests debian 10 amd64 part 9
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 arm8 part 8
Topotests debian 10 amd64 part 4
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 arm8 part 3
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 amd64 part 3
Ubuntu 16.04 deb pkg check
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 amd64 part 2
Addresssanitizer topotests part 0
Topotests Ubuntu 18.04 arm8 part 4
Debian 10 deb pkg check
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 arm8 part 9
Topotests Ubuntu 18.04 amd64 part 4
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 amd64 part 5
IPv6 protocols on Ubuntu 18.04
Topotests Ubuntu 18.04 i386 part 6
IPv4 ldp protocol on Ubuntu 18.04
Topotests Ubuntu 18.04 amd64 part 0
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 i386 part 3
IPv4 protocols on Ubuntu 18.04
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 amd64 part 7
Fedora 29 rpm pkg check
Topotests Ubuntu 18.04 i386 part 8
Topotests debian 10 amd64 part 0
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 amd64 part 9
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 arm8 part 7

NetDEF-CI · 2022-01-11T08:22:39Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2608/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for pim_str.h | 2 issues
===============================================
< WARNING: do not add new typedefs
< #29: FILE: /tmp/f1-17575/pim_str.h:29:

frrbot bot added documentation pim labels Dec 14, 2021

mobash-rasool added the pimv6 label Dec 14, 2021

mobash-rasool force-pushed the mld-pim6-dev-prefix branch from 9aeec69 to 9c6e8b4 Compare December 14, 2021 11:48

mobash-rasool force-pushed the mld-pim6-dev-prefix branch from 9c6e8b4 to 493f6d7 Compare December 14, 2021 14:06

mobash-rasool force-pushed the mld-pim6-dev-prefix branch from 493f6d7 to 1010abf Compare December 14, 2021 17:12

mobash-rasool marked this pull request as ready for review December 15, 2021 05:12

mobash-rasool marked this pull request as draft December 15, 2021 05:13

mobash-rasool force-pushed the mld-pim6-dev-prefix branch from 1010abf to 4f0fde4 Compare December 15, 2021 07:09

mobash-rasool force-pushed the mld-pim6-dev-prefix branch 4 times, most recently from 8528d6b to 5303055 Compare December 15, 2021 13:44

mobash-rasool force-pushed the mld-pim6-dev-prefix branch 5 times, most recently from 007d6f6 to 020753f Compare December 15, 2021 14:05

mobash-rasool marked this pull request as ready for review December 15, 2021 14:08

mobash-rasool changed the title ~~[WIP] pimd: Data structure changes to accommodate address family for IPv4 and IPv6~~ pimd: Data structure changes to accommodate address family for IPv4 and IPv6 Dec 15, 2021

mobash-rasool added 2 commits January 9, 2022 23:51

pimd: Adding pim_addr as common address for IPv4 and IPv6

3e5b708

PIM_ADDR will be controlled at compile time for IPv4 and IPv6. in_addr and in6_addr will be compiled for the respective daemons. Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>

pimd: API changes to accomodate IPv4 and IPv6

3b37b96

Added apis which will be decided on compile time for pimd and pim6d daemon Reviewed-by: Sarita Patra <saritap@vmware.com> Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>

mobash-rasool force-pushed the mld-pim6-dev-prefix branch from 7c8dcfc to 6824e73 Compare January 10, 2022 09:48

mobash-rasool requested a review from eqvinox January 10, 2022 13:37

eqvinox requested changes Jan 10, 2022

View reviewed changes

pimd/pim_assert.c Outdated Show resolved Hide resolved

pimd/pim_assert.c Outdated Show resolved Hide resolved

mobash-rasool force-pushed the mld-pim6-dev-prefix branch from 6824e73 to 07cd4d1 Compare January 11, 2022 05:01

mobash-rasool requested a review from eqvinox January 11, 2022 05:08

mobash-rasool and others added 11 commits January 10, 2022 21:10

pimd: Modifying in_addr to pim_addr in struct pim_ifchannel for IPv6.

b85201d

Changed struct in_addr ifassert_winner to pim_addr which will be used in both IPv4 and IPv6(Both MLD and IGMP). Reviewed-by: Sarita Patra <saritap@vmware.com> Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>

pimd: Modify in_addr to pim_addr in pim_assert_metric

95d5166

This change is to accomodate IPv6 and IPv4 in the same code. Based on pimd or pim6d, this will be compiled. Reviewed-by: Sarita Patra <saritap@vmware.com> Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>

pimd: Modifying in_addr to pim_addr in struct pim_interface for IPv6

12e7634

Based on compiler option, pim_addr will be changed to in_addr or in6_addr for pimd and pim6d respectively. Reviewed-by: Sarita Patra <saritap@vmware.com> Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>

mobash-rasool force-pushed the mld-pim6-dev-prefix branch from 07cd4d1 to ca7613e Compare January 11, 2022 05:10

eqvinox mentioned this pull request Jan 11, 2022

pim6d: add skeleton & address structures #10281

Merged

eqvinox approved these changes Jan 11, 2022

View reviewed changes

g-balaji1 approved these changes Jan 11, 2022

View reviewed changes

eqvinox merged commit 0064d47 into FRRouting:master Jan 11, 2022

pimd: Data structure changes to accommodate address family for IPv4 and IPv6 #10212

pimd: Data structure changes to accommodate address family for IPv4 and IPv6 #10212

Conversation

mobash-rasool commented Dec 14, 2021 • edited Loading

NetDEF-CI commented Dec 14, 2021 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

mobash-rasool commented Dec 14, 2021

NetDEF-CI commented Dec 14, 2021 • edited Loading

Continuous Integration Result: SUCCESSFUL

NetDEF-CI commented Dec 14, 2021 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

NetDEF-CI commented Dec 14, 2021 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

mobash-rasool commented Dec 14, 2021

NetDEF-CI commented Dec 14, 2021 • edited Loading

Continuous Integration Result: SUCCESSFUL

NetDEF-CI commented Dec 14, 2021 • edited Loading

Continuous Integration Result: SUCCESSFUL

NetDEF-CI commented Dec 15, 2021 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

NetDEF-CI commented Dec 15, 2021 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

mobash-rasool commented Jan 10, 2022 • edited Loading

NetDEF-CI commented Jan 10, 2022

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

eqvinox left a comment

Choose a reason for hiding this comment

mobash-rasool commented Jan 11, 2022

eqvinox left a comment

Choose a reason for hiding this comment

NetDEF-CI commented Jan 11, 2022

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

NetDEF-CI commented Jan 11, 2022

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

NetDEF-CI commented Jan 11, 2022

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

mobash-rasool commented Dec 14, 2021 •

edited

Loading

NetDEF-CI commented Dec 14, 2021 •

edited

Loading

NetDEF-CI commented Dec 14, 2021 •

edited

Loading

NetDEF-CI commented Dec 14, 2021 •

edited

Loading

NetDEF-CI commented Dec 14, 2021 •

edited

Loading

NetDEF-CI commented Dec 14, 2021 •

edited

Loading

NetDEF-CI commented Dec 14, 2021 •

edited

Loading

NetDEF-CI commented Dec 15, 2021 •

edited

Loading

NetDEF-CI commented Dec 15, 2021 •

edited

Loading

mobash-rasool commented Jan 10, 2022 •

edited

Loading