-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let rating service publish rating changes to RabbitMQ #804
Let rating service publish rating changes to RabbitMQ #804
Conversation
284319e
to
a7b589e
Compare
Running the tests locally, I see Likewise |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you want to add an integration test? I think I added some helpers for getting rabbitmq messages in my broadcast PR.
f7db8d2
to
29cb8d6
Compare
Codecov Report
|
I added an integration test - turns out there are some floating point issues somewhere in the interaction between the database and trueskill that lead to results like this:
|
1d19488
to
6d471c1
Compare
And uncomment pytestmark
6d471c1
to
6d87d04
Compare
Closes #803.