Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish rating changes to RabbitMQ for LeagueService to use #803

Closed
cleborys opened this issue Jun 29, 2021 · 0 comments · Fixed by #804
Closed

Publish rating changes to RabbitMQ for LeagueService to use #803

cleborys opened this issue Jun 29, 2021 · 0 comments · Fixed by #804

Comments

@cleborys
Copy link
Member

cleborys commented Jun 29, 2021

Right now only game results are published to RabbitMQ, but since the league service doesn't want to duplicate the rater logic, what it really wants is an event published on rating change.
The expected format of these messages is e.g. available in these tests.
When this is done the routing keys in the league service should be updated accordingly.

(Right now the league service actually listens for game results using the "success.gameResult.create" routing key, but it then tries to parse the message as if it was an event as described above and hence fails.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant