Remove references to equilibrium #744 #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ass detection up the call stack out of game_service.py
Codecov Report
|
Askaholic
requested changes
Apr 6, 2021
server/lobbyconnection.py
Outdated
Comment on lines
906
to
911
| game_class = { | ||
| FeaturedModType.LADDER_1V1: LadderGame, | ||
| FeaturedModType.COOP: CoopGame, | ||
| FeaturedModType.FAF: CustomGame, | ||
| FeaturedModType.FAFBETA: CustomGame | ||
| }.get(game_mode, Game) |
There was a problem hiding this comment.
We only need to check for coop here, and default to CustomGame.
There was a problem hiding this comment.
Just use an if statement
| @@ -15,6 +15,7 @@ async def test_create_game(players, game_service): | |||
| game = game_service.create_game( | |||
| visibility=VisibilityState.PUBLIC, | |||
| game_mode="faf", | |||
| game_class=CustomGame, | |||
There was a problem hiding this comment.
I think you could make this the default argument.
| @@ -154,15 +151,6 @@ def create_game( | |||
| "matchmaker_queue_id": matchmaker_queue_id, | |||
| } | |||
| game_args.update(kwargs) | |||
|
|
|||
There was a problem hiding this comment.
I would definitely either make game_class a required argument, or give it a sensible default. Defaulting to None just doesn't make any sense anymore.
…e. Also simplified class detection in lobbyconnection.py.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove references to equilibrium
I was able do three things as part of this change set.
FeaturedModTypeenum and all referencesgame_serviceclassgame_servicetests to pass in a game class since the method signature technically changedPlease let me know if you have any questions or feedback for improvement!
Closes #744