-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove references to equilibrium #744
Comments
Howdy, I'd like to lend a hand with this issue |
Hi, sounds great! Are you up for taking a stab at removing the game class detection from that function too? |
Isn't the class detection needed to support the create game calls from the lobbyconnection class (command_game_host function)? If the game class detection is removed from the create_game function, it looks like it would just move up the call stack to command_game_host. Am I understanding that correctly? |
Yep that’s correct, but there just needs to be one case for coop games. Everything else that’s created through There has been some discussion about supporting coop games using different featured mods e.g. nomads, in which case we would need a different way of deciding when to use the |
* Removed references to the equilibrium game mode, and migrated game class detection up the call stack out of game_service.py * Fixing a failing test, and cleaning up some messy formatting * Added CustomGame as a default game_class type argument for create_game. Also simplified class detection in lobbyconnection.py. * Cleaning up a couple unused imports--oops
Equilibrium was removed as a featured mod since it stopped being developed. We should remove all hardcoded references to it, there aren't very many.
We should also refactor this:
server/server/game_service.py
Lines 158 to 165 in 4a39a48
I think it would be best to get rid of the automatic game class detection and pass in the desired class when creating a game.
The text was updated successfully, but these errors were encountered: