Issue/#687 Fix coop leaderboards again #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleborys
approved these changes
Feb 7, 2021
Askaholic
force-pushed
the
issue/#687-coop-leaderboards
branch
2 times, most recently
from
2e9a1ed
to
dc1a09a
Compare
Askaholic
force-pushed
the
issue/#687-coop-leaderboards
branch
from
dc1a09a
to
0790c99
Compare
cleborys
approved these changes
Feb 21, 2021
| @@ -614,11 +618,11 @@ async def validate_game_settings(self): | |||
| await self.mark_invalid(ValidityState.FFA_NOT_RANKED) | |||
| return | |||
| valid_options = { | |||
| "AIReplacement": ("Off", ValidityState.HAS_AI_PLAYERS), | |||
There was a problem hiding this comment.
Oh wow I didn't realize that there were even more words for true/false used already 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like these two things were broken:
Expansionvalues as 'true' or 'false' now instead of 1 or 0OperationComplete, and since coop games don't report any results they were getting marked asUNKNOWN_RESULT. This wasn't an issue before because they used to be marked as unknown only after having been inserted into the leaderboard.If you have better ideas for how to solve point 2, let me hear them. Right now I'm overriding
on_game_endinCoopGame, to remove the game result checking, but that leaves a bunch of other code duplicated.Closes #687