Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coop leaderboards are not updated anymore #687

Closed
Askaholic opened this issue Nov 11, 2020 · 2 comments · Fixed by #718
Closed

Coop leaderboards are not updated anymore #687

Askaholic opened this issue Nov 11, 2020 · 2 comments · Fixed by #718
Labels
bug regression

Comments

@Askaholic
Copy link
Collaborator

Requires Investigation

This was reported on discord.

Archsimkat Nov. 5, 2020

I have issues with coop times not being saved. None of my coop times have been saved for the last couple of months. Is that functionality supposed to be working?

I haven't seen any new times from any other people. The leaderboards look exactly the same as it has. I've personally played a dozen or so games with 1/2/3 players and none of them have been recorded.
@Askaholic
Copy link
Collaborator Author

Looks like someone changed something on the FA end and started sending Expansion='true' instead of Expansion=1 which is now causing all coop games to be unranked.

@Askaholic
Copy link
Collaborator Author

Additionally, since the result handling code now triggers when GameEnded is sent, and GameEnded is sent before OperationComplete, games are marked as UNKNOWN_RESULT, and therefore not inserted into the leaderboard table.

@Askaholic Askaholic mentioned this issue Feb 6, 2021
Merged
Askaholic added a commit that referenced this issue Feb 21, 2021
@Askaholic
Issue/#687 Fix coop leaderboards again (#718)
31168aa 
* Add test for coop game

* Change expected value of Expansion to 'true'

* Ignore result reports for coop games

* Make boolean game option checks more lenient
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue/#687 Fix coop leaderboards again Askaholic/server
1 participant
@Askaholic