-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/#676 remove python version check #677
Enhancement/#676 remove python version check #677
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Brutus5000 Thoughts on keeping the user agent check?
Oh and I can take care of the Pipfile and Pipfile.lock in a separate PR. That's no problem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another thing I just noticed was that there are references to the version_lobby
table in our test-data.sql file. We should remove those too so our tests don't break when the table is dropped.
And you'll need to rebase.
OK, I'm first time doing rebase and I need little help here. Current branch is ahead of develop to 10 commits:
Should I go back to 10 commits and squash them? Right? |
Sorry for taking so long to respond, somehow I overlooked this. I usually do this:
Where You shouldn't need to squash anything, and after the rebase you should be left with just the commits that you made, except that they will have been moved to be the most recent commits in the commit history. |
@Askaholic Thanks a lot. Today I will finish it then. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Removed
client_version_info
from project.isort
show sorting error in file which I didn't editedflake8
throws tons of errors on local env--keep-outdated
flag)I can update PR later with all necessary changes.
Closes #676