Remove python client version check

[Brutus5000]

I would like to drop the table version_lobby in the database. The whole version check is sort of pointless today. The database records point to the download of the java client and the minimum version is 0.13.0 which is like 5 years old. Seems like it's completely useless.

Both clients have an auto-update mechanism outside of the faf-database.

Related code (didn't check for tests):

server/server/player_service.py

Line 40 in 2932f86

self.client_version_info = ("0.0.0", None)

server/server/player_service.py

Lines 259 to 265 in 2932f86

	# Client version number
	result = await conn.execute(
	"SELECT version, file FROM version_lobby ORDER BY id DESC LIMIT 1"
	)
	row = await result.fetchone()
	if row is not None:
	self.client_version_info = (row[0], row[1])

server/server/lobbyconnection.py

Lines 458 to 478 in 2932f86

	versionDB, updateFile = self.player_service.client_version_info
	update_msg = {
	"command": "update",
	"update": updateFile,
	"new_version": versionDB
	}
	if not self.user_agent or "downlords-faf-client" not in self.user_agent:
	await self.send_warning(
	"You are using an unofficial client version! "
	"Some features might not work as expected. "
	"If you experience any problems please download the latest "
	"version of the official client from "
	f'<a href="{config.WWW_URL}">{config.WWW_URL}</a>'
	)
	if not self._version or not self.user_agent:
	update_msg["command"] = "welcome"
	# For compatibility with 0.10.x updating mechanism
	await self.send(update_msg)
	return False

[andrewmiko]

I can work on this issue during #hacktoberfest. Is this about remove code which is somehow related to self.client_version_info and table version_lobby?

I've found 1 test here:

server/tests/unit_tests/test_player_service.py

Line 122 in 9495de5

assert player_service.client_version_info == ("0.10.125", "some-installer.msi")

Should this line be removed from test too?

Thanks.

[Askaholic]

Yea that’s right. We don’t need to be keeping track of client version numbers at all, so we can just remove any reference to that attribute. You can also run the tests and see what fails after you remove stuff (use the Travis build if you don’t want to set it up locally). Removing this code will also let us get rid of the semver dependency (need to update Pipfile and Pipfile.lock)

[andrewmiko]

@Askaholic thanks. I will work on it.