-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Page do scroll to bottom when send message in public room #52955
Page do scroll to bottom when send message in public room #52955
Conversation
@Anaslancer Please check all the boxes in the checklist. |
Reviewer Checklist
Screenshots/VideosAndroid: Native52955-android-native.mp4Android: mWeb Chrome52955-android-chrome.mp4iOS: Native52955-ios-native.mp4iOS: mWeb Safari52955-ios-safari.mp4MacOS: Chrome / Safari52208-web.mp4MacOS: Desktop52208-desktop.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to complete the following in the initial post.
- Complete the checklist, meaning check all the boxes
- Include your testing videos / screenshots for each platform
@Anaslancer bump on #52955 (review) |
Hey @Anaslancer 👋 , are planning to finish the PR here?, it was pretty closed to be ready for merging, we just need you to follow the process of including the testing videos/screenshots. |
@aldo-expensify I will add the videos in a few days. Thanks |
Does a "few days" mean this week? or can it be longer |
It will be this week, I am waiting my new mac. |
Ah, that is great, thanks for the information! |
@Anaslancer Any updates here? |
I am getting this error when npm run android;
|
@Anaslancer Make sure you have your ANDROID_HOME environment variable set. You would also need to install the Android SDK build tools and platform tools (if not yet installed) on Android Studio. Launch Android Studio > Settings > Languages & Framework > Android SDK, select the SDK tools tab and then choose the missing dependencies to install. |
@Anaslancer You can ask for guidance on this in the #expensify-open-source Slack channel if you are unable to resolve the problem. |
But I don't have slack account for Expensify |
I requested before but they said they can't accept. Let me request again? |
Finally, I figured out we can't use Windows for android. I built it on MacOS |
@akinwale I've uploaded all videos. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@aldo-expensify All test videos have been uploaded. This is ready for your review. |
Nice, thank you! |
🚀 Deployed to staging by https://github.com/aldo-expensify in version: 9.0.77-0 🚀
|
@akinwale , after pulling the code from staging, I can't run on web. Do you know why? Seems like web socket error |
Not sure what it may be, can you post a screenshot? |
Could you be missing a dependency? did you try running |
Nope, I will try now |
I am going to have a travel, and will fix once back. |
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.77-6 🚀
|
@akinwale
Explanation of Change
I've wrapped the
scrollToBottomForCurrentUserAction
function withInteractionManager.runAfterInteractions
.Fixed Issues
$ #52208.
PROPOSAL: #52208 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
test.mp4
Android: mWeb Chrome
video1.mp4
iOS: Native
Recording.2024-12-08.183806.mp4
iOS: mWeb Safari
Recording.2024-12-08.190941.mp4
MacOS: Chrome / Safari
386153028-162ba043-9a48-42a8-bb62-41d66ed71dc7.mp4
MacOS: Desktop
Recording.2024-12-06.151751.mp4