[HOLD for payment 2024-12-30] [$250] Room - Page does not scroll to bottom when send message in #expensify-roadmap public room

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.59-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Log in to staging.new.expensify.com
2. Open #expensify-roadmap public room ( https://staging.new.expensify.com/r/868417741568295
   )
3. Scroll to the top of the page
4. Send a message

Expected Result:

Page should scroll to the bottom when send new message

Actual Result:

Page does not scroll to bottom of the conversation

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6657900_1731001767296.Recording__4488.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021855979378378206243
• Upwork Job ID: 1855979378378206243
• Last Price Increase: 2024-11-18

Issue Owner

Current Issue Owner: @akinwale / @sonialiap

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021855979378378206243

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

[jestinjoshi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Page does not scroll to bottom of the conversation in #expensify-roadmap public room

What is the root cause of that problem?

App/src/pages/home/report/ReportActionsList.tsx

Line 427 in b2d6a0e

return;

What changes do you think we should make in order to solve the problem?

The return statement can be removed here, as it was added simply to follow a similar logic in scrollToBottomAndMarkReportAsRead, as noted in #46724 (comment). Removing it won't affect functionality in this context.

What alternative solutions did you explore? (Optional)

NA

[Anaslancer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Room - Page does not scroll to bottom when send message in #expensify-roadmap public room

What is the root cause of that problem?

We are calling the scrollToBottomForCurrentUserAction callback function before changing the hasNewestReportActionRef.current. we should wait until changing hasNewestReportActionRef.current.

What changes do you think we should make in order to solve the problem?

We need to wrap this block into the InteractionManager.runAfterInteractions.

App/src/pages/home/report/ReportActionsList.tsx

Lines 417 to 429 in b2d6a0e

	// If a new comment is added and it's from the current user scroll to the bottom otherwise leave the user positioned where
	// they are now in the list.
	if (!isFromCurrentUser) {
	return;
	}
	if (!hasNewestReportActionRef.current) {
	if (isInNarrowPaneModal) {
	return;
	}
	Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(report.reportID));
	return;
	}
	InteractionManager.runAfterInteractions(() => reportScrollManager.scrollToBottom());

So this below is the working block;

            InteractionManager.runAfterInteractions(() => {
                // If a new comment is added and it's from the current user scroll to the bottom otherwise leave the user positioned where
                // they are now in the list.
                if (!isFromCurrentUser) {
                    return;
                }
                if (!hasNewestReportActionRef.current) {
                    if (isInNarrowPaneModal) {
                        return;
                    }
                    Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(report.reportID));
                    return;
                }
                reportScrollManager.scrollToBottom();
            });

What alternative solutions did you explore? (Optional)

N/A

Contributor details

Your Expensify account email: anasup1995@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01aff093c9a804b145

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[akinwale]

@Anaslancer Could you post a video demo of your proposed solution?

[Anaslancer]

@akinwale Here is the before video

before.mp4

[Anaslancer]

@akinwale Here is the after video

after.mp4

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@akinwale, @sonialiap Eep! 4 days overdue now. Issues have feelings too...

[sonialiap]

@akinwale what do you think of the videos showing the proposal?

[akinwale]

I will review and test this today.

[akinwale]

We can move forward with @Anaslancer's proposal here.

🎀👀🎀 C+ reviewed.

[melvin-bot]

Triggered auto assignment to @aldo-expensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.77-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Page do scroll to bottom when send message in public room  #52955

If no regressions arise, payment will be issued on 2024-12-30. 🎊

For reference, here are some details about the assignees on this issue:

• @akinwale requires payment through NewDot Manual Requests

[melvin-bot]

@akinwale @twisterdotcom / @sonialiap @akinwale The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @akinwale owed $250 via NewDot

BugZero Checklist (@twisterdotcom)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1855979378378206243/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[sonialiap]

Not regression #54307 (comment)

[sonialiap]

Payment summary:

• @akinwale $250 via ND - please complete the checklist
• @Anaslancer $250 via upwork - offer sent - paid ✔️

[akinwale]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: N/A

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue: https://github.com/Expensify/Expensify/issues/457622

Regression Test Proposal

Test:

1. Launch Expensify
2. Log in with an account
3. Navigate to a chat room that has a long chat history that can be scrolled, with the latest message being a message from a user different from the currently logged in account
4. Scroll up through the chat history to the top
5. Send a message to the chat room
6. Verify that the chat area automatically scrolls to the bottom after the message has been sent to the room.

Do we agree 👍 or 👎?

[sonialiap]

Thanks @akinwale! If you haven't yet, please request payment in ND

[Anaslancer]

@sonialiap Can I get the payment?

[aldo-expensify]

Seems like @anaslance removed themselves from the issue and that caused some confusion:

[sonialiap]

@Anaslancer $250 for fix, offer sent!

[Anaslancer]

Thank you!!!

[sonialiap]

Payment completed 😊

[JmillsExpensify]

$250 approved for @akinwale