[HOLD for payment 2023-09-04] Text is overlapping in the main chat window

[sakluger]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Clicked on a push notification for a new message, which opened NewDot to that message

Expected Result:

The text should be shown in chronological order of how it was sent

Actual Result:

Some chat messages are overlapping others. When I hover over the message, it flashes.

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.56-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): sasha@expensify.com, jessica.dooley@team.expensify.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Screenshots from jessica.dooley@team.expensify.com:

Expensify/Expensify Issue URL:
Issue reported by: @sakluger
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692664635223199

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[spcheema]

Reproducible on staging:

Also on hover, there is a console error.

[roryabraham]

Potential dupe of #25616, but should still be addressed with urgency

[roryabraham]

Looks like it might be fixed by #25613 cc @Li357

[MonilBhavsar]

I am not able to reproduce this. @dylanexpensify could you please check if you're able to reproduce this?

[dylanexpensify]

On it now

[dylanexpensify]

Unable to reproduce on staging as well @MonilBhavsar @roryabraham (also @Li357 is OOO now)

[MonilBhavsar]

Thanks! I'll comment in the slack.
@spcheema looks like you were able to reproduce this issue. Do you have any specific clear steps to reproduce?

[MonilBhavsar]

Posted here in slack https://expensify.slack.com/archives/C049HHMV9SM/p1692694595371789?thread_ts=1692664635.223199&cid=C049HHMV9SM

[spcheema]

@MonilBhavsar Here is the video

https://www.loom.com/share/14427568487f42178ed1f89363cade7b?sid=390c0339-4bc1-4b82-bf83-be6cf7763492

Seems like some issue with formatted messages.

[dylanexpensify]

Woof, still cannot reproduce

[spcheema]

Not sure then but I have cleared the cache and removed the local DB to test. You can use my account if needed.

[MonilBhavsar]

Thanks! I have been able to reproduce by sending long quoted message

> Hello



> Yes, long quotes

[spcheema]

@MonilBhavsar Is this regression from another issue or open for proposals?

[MonilBhavsar]

It does seem like regression, as it is only happening on staging. I'm currently checking the list of PR's

[Li357]

I think we can address this quickly. The regression is due to a styling I added for receipt scanning that had unintended effects.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[MonilBhavsar]

Thank you @Li357 ! Mind linking the PR that you think caused this

[dangrous]

This may be the same as #25678, caused by #24235 (comment)

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[tjferriss]

Applause reported a similar issue happening on iPad #25478. I have also seen my text overlapping recently.

[mountiny]

This is fixed in the latest staging and reported internally so closing

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.57-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Polish displaying receipts in chat #25613
• [CP Staging] Remove global styling in BaseHTMLEngineProvider #25691

If no regressions arise, payment will be issued on 2023-09-04. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@MonilBhavsar] The PR that introduced the bug has been identified. Link to the PR:
• [@MonilBhavsar] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@MonilBhavsar] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@MonilBhavsar] Determine if we should create a regression test for this bug.
• [@MonilBhavsar] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: