[HOLD for payment 2023-09-04] Console error on opening the report

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

To reproduce open report which has money request previews.

1. Open any chat report
2. Observer the console error(Unexpected text node: . A text node cannot be a child of a )

Expected Result:

Console error should not occur

Actual Result:

Console error occurs(Unexpected text node: . A text node cannot be a child of a )

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: dev
Reproducible in staging?: dev
Reproducible in production?: dev
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-08-22.at.12.15.14.AM.mov

Expensify/Expensify Issue URL:
Issue reported by: @Pujan92
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692641891784579

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kavimuru]

Proposal from @Pujan92

Please re-state the problem that we are trying to solve in this issue.

Console error on opening the report which has money request previews

What is the root cause of that problem?

It seems to be a regression from this PR where we are using string variable for a conditional rendering. For an empty string it tries to render empty Text and causes the issue.

App/src/components/ReportActionItem/MoneyRequestPreview.js

Lines 257 to 261 in d1cf9be

	{requestMerchant && (
	<View style={[styles.flexRow]}>
	<Text style={[styles.textLabelSupporting, styles.mb1, styles.lh16]}>{requestMerchant}</Text>
	</View>
	)}

What changes do you think we should make in order to solve the problem?

Use !_.isEmpty(requestMerchant) to convert it to a boolean to avoid rendering unexpected empty Text which prevents the issue Unexpected text node: . A text node cannot be a child of a <View>..

[melvin-bot]

Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[s77rt]

cc @Li357 Can you raise a follow up PR as I think the PR is still within the regression period

[Li357]

@s77rt Will address here! #25613

[roryabraham]

Not able to reproduce on staging, not a deploy blocker.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[mountiny]

This was deployed yesterday so its a deploy blocker, assigning @Li357 as he ha a fix up

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mountiny]

Cant reproduce anymore @Pujan92 Can you confirm

If that is the case @bfitzexpensify can you please pay out $250 to @Pujan92 for reporting?

[Pujan92]

Yes @mountiny , not reproducible now.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.57-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Polish displaying receipts in chat #25613

If no regressions arise, payment will be issued on 2023-09-04. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @Pujan92 requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Li357] The PR that introduced the bug has been identified. Link to the PR: Display receipts in chat #24235
• [@Li357] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/24235/files#r1315014083
• [@Li357] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Li357] Determine if we should create a regression test for this bug.
• [@Li357] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Li357]

No regression steps needed.

[bfitzexpensify]

Offer sent for reporting @Pujan92

[Pujan92]

Offer sent for reporting @Pujan92

Accepted @bfitzexpensify :)

[bfitzexpensify]

Cool, all paid out, we're done here!