[HOLD for payment 2023-09-04] Workspace - 'WS chat closed' message is expanded to full screen even if there were messages

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open iOS App and login with any account
2. Create new workspace or open existing WS
3. Send some messages in #announce room
4. Delete this workspace
5. Open archived #announce chat

Expected Result:

The message that the 'WS chat is closed' is at the bottom of the screen. All previously sent messages are visible

Actual Result:

The message that the WS chat is closed is expanded to full screen even if there were messages in the chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.56-2

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6172890_T3606025-Closed-chat-message-full-screen.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[shubham1206agra]

Hey
Can you confirm that current prod behaviour is correct?

[robertjchen]

Yes, the prod behavior is correct, the stg behavior definitely is not. Though, I'm trying to find which particular change introduced the issue as observed: #25625

[shubham1206agra]

Found it #24235

[shubham1206agra]

See BaseHTMLEngineProvider.js

[robertjchen]

@shubham1206agra Thanks! If you have a proposal for a fix, I can mark as External and we can get it reviewed 👍

[shubham1206agra]

Wait
I will post it a little later (little busy rn)

[robertjchen]

Actually, I just saw that they were considering reverting the PR that introduced this along with the other issues. #24235 (comment)

[shubham1206agra]

Yes
But I think most of the bug stated there can be fixed easily

[robertjchen]

ok, looks like we won't be reverting the original changes, but we'll need a quick turnaround on a fix as it's a DeployBlocker. Will open this up for proposals shortly, would you be available to submit a quick fix @shubham1206agra ?

[Li357]

@robertjchen @shubham1206agra How quickly do you think you can handle this? I am going to work on a PR that will fix this and #25648 within the next 30 minutes.

[robertjchen]

@Li357 DeployBlockers take priority, so definitely feel free to handle this internally 👍

[shubham1206agra]

F
@Li357 Feel free to ask for help

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[mountiny]

No longer repro in staging, fixed

Internal reporter so closing

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.57-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Polish displaying receipts in chat #25613
• [CP Staging] Remove global styling in BaseHTMLEngineProvider #25691

If no regressions arise, payment will be issued on 2023-09-04. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty