Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rpc): add hold field to orders #645

Merged
merged 3 commits into from
Nov 13, 2018
Merged

feat(rpc): add hold field to orders #645

merged 3 commits into from
Nov 13, 2018

Conversation

ImmanuelSegol
Copy link
Contributor

closes #644

@ghost ghost assigned ImmanuelSegol Nov 6, 2018
@ghost ghost added the in progress label Nov 6, 2018
sangaman
sangaman requested changes Nov 12, 2018
View reviewed changes
Copy link
Collaborator

@sangaman sangaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just a couple of quick things.

lib/grpc/GrpcService.ts Outdated Show resolved Hide resolved
proto/xudrpc.proto Outdated Show resolved Hide resolved
@sangaman sangaman merged commit 27ec3c2 into master Nov 13, 2018
@ghost ghost removed the in progress label Nov 13, 2018
@sangaman sangaman deleted the proto-hold-value branch November 13, 2018 17:59
@sangaman sangaman changed the title Refactor(Order proto) added hold value feat(rpc): add hold field to orders Nov 13, 2018
@sangaman sangaman added the grpc gRPC API label Nov 13, 2018
@ghost ghost mentioned this pull request Nov 15, 2018
Closed
@sangaman sangaman mentioned this pull request Nov 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sangaman sangaman sangaman approved these changes

Assignees

@ImmanuelSegol ImmanuelSegol

Labels
grpc gRPC API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add hold to getorders response
2 participants
@ImmanuelSegol @sangaman