Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI - buy/sell fails due to grpcOrder.setHold #674

Closed
ghost opened this issue Nov 15, 2018 · 3 comments
Closed

CLI - buy/sell fails due to grpcOrder.setHold #674

ghost opened this issue Nov 15, 2018 · 3 comments
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Nov 15, 2018

Using latest master (03b8cd4) xucli buy/sell commands error with the following output:

[RPC] error: grpcOrder.setHold is not a function

Caused by: #645

CC @ImmanuelSegol @sangaman

@ghost ghost added the bug Something isn't working label Nov 15, 2018
@ImmanuelSegol
Copy link
Contributor

ImmanuelSegol commented Nov 15, 2018

@erkarl It works for me on the master branch.

But sometimes I run into similar issues with grpc, but they always seem to solve themselves and I never make a PR if it doesn't work locally.

Could you share some more details?

@sangaman
Copy link
Collaborator

Sorry I just saw this. xucli buy is working for me as well, can't reproduce. @erkarl, did you make sure you compiled after getting the latest from master?

@ghost
Copy link
Author

ghost commented Nov 16, 2018

@ImmanuelSegol @sangaman

Turning it off and on again worked. I was using dev:watch which I assumed would copy lib/proto to dist/proto.

Sorry for the false alarm.

@ghost ghost closed this as completed Nov 16, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants