-
Couldn't load subscription status.
- Fork 4.6k
Downgrade 2.3.2 #2088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downgrade 2.3.2 #2088
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -3367,12 +3367,7 @@ export class BaileysStartupService extends ChannelStartupService { | |||||||||||
| } | ||||||||||||
|
|
||||||||||||
| const numberJid = numberVerified?.jid || user.jid; | ||||||||||||
| const lid = | ||||||||||||
| typeof numberVerified?.lid === 'string' | ||||||||||||
| ? numberVerified.lid | ||||||||||||
| : numberJid.includes('@lid') | ||||||||||||
| ? numberJid.split('@')[1] | ||||||||||||
| : undefined; | ||||||||||||
| const lid = numberJid.includes('@lid') ? numberJid.split('@')[1] : undefined; | ||||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. question: The new lid extraction logic may not handle all edge cases. The new logic may miss cases where numberVerified.lid is set but numberJid lacks '@lid'. Please review if this could impact functionality. |
||||||||||||
| return new OnWhatsAppDto( | ||||||||||||
| numberJid, | ||||||||||||
| !!numberVerified?.exists, | ||||||||||||
|
|
@@ -4561,8 +4556,8 @@ export class BaileysStartupService extends ChannelStartupService { | |||||||||||
| return response; | ||||||||||||
| } | ||||||||||||
|
|
||||||||||||
| public async baileysAssertSessions(jids: string[], force: boolean) { | ||||||||||||
| const response = await this.client.assertSessions(jids, force); | ||||||||||||
| public async baileysAssertSessions(jids: string[]) { | ||||||||||||
| const response = await this.client.assertSessions(jids); | ||||||||||||
|
|
||||||||||||
| return response; | ||||||||||||
|
Comment on lines
+4560
to
4562
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. suggestion (code-quality): Inline variable that is immediately returned (
Suggested change
ExplanationSomething that we often see in people's code is assigning to a result variableand then immediately returning it. Returning the result directly shortens the code and removes an unnecessary Where intermediate variables can be useful is if they then get used as a |
||||||||||||
| } | ||||||||||||
|
|
||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question (bug_risk): The removal of the 'force' argument may affect voice call session assertions.
Verify that removing the 'force' parameter does not break any session assertion scenarios.