Downgrade 2.3.2 #2088
Closed
Downgrade 2.3.2 #2088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecessary parameters - Refactored CORS middleware setup in main.ts for improved readability and maintainability. - Removed the 'force' parameter from assertSessions method in Baileys service for consistency. - Updated related calls in useVoiceCallsBaileys to align with the new method signature.
Reviewer's GuideRefactored CORS middleware setup, streamlined LID extraction and session assertion logic in the WhatsApp integration, and downgraded the package version. Sequence diagram for updated CORS middleware setup in bootstrapsequenceDiagram
participant App
participant ConfigService
participant CorsMiddleware
App->>ConfigService: get('CORS')
App->>CorsMiddleware: cors(corsOptions)
CorsMiddleware->>ConfigService: get('CORS')
CorsMiddleware-->>App: Allow/deny request origin
Class diagram for BaileysStartupService session assertion method changeclassDiagram
class BaileysStartupService {
+baileysAssertSessions(jids: string[]): Promise<any>
}
BaileysStartupService --> Client : uses
class Client {
+assertSessions(jids: string[]): Promise<any>
}
Class diagram for streamlined LID extraction in BaileysStartupServiceclassDiagram
class BaileysStartupService {
+extractLid(numberJid: string): string | undefined
}
BaileysStartupService : - lid extraction logic simplified
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Consider retrieving the CORS config once outside the origin callback to avoid hitting
configService.geton every request and improve performance. - The cast
compression() as anybypasses type safety—import or declare the correct middleware type instead of usingany. - You’ve removed the
forceparameter frombaileysAssertSessionsand its callers—double-check that this preserves the intended session assertion behavior and update related interfaces or logic if needed.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider retrieving the CORS config once outside the origin callback to avoid hitting `configService.get` on every request and improve performance.
- The cast `compression() as any` bypasses type safety—import or declare the correct middleware type instead of using `any`.
- You’ve removed the `force` parameter from `baileysAssertSessions` and its callers—double-check that this preserves the intended session assertion behavior and update related interfaces or logic if needed.
## Individual Comments
### Comment 1
<location> `src/api/integrations/channel/whatsapp/whatsapp.baileys.service.ts:3370` </location>
<code_context>
- : numberJid.includes('@lid')
- ? numberJid.split('@')[1]
- : undefined;
+ const lid = numberJid.includes('@lid') ? numberJid.split('@')[1] : undefined;
return new OnWhatsAppDto(
numberJid,
</code_context>
<issue_to_address>
**question:** The new lid extraction logic may not handle all edge cases.
The new logic may miss cases where numberVerified.lid is set but numberJid lacks '@lid'. Please review if this could impact functionality.
</issue_to_address>
### Comment 2
<location> `src/api/integrations/channel/whatsapp/voiceCalls/useVoiceCallsBaileys.ts:74` </location>
<code_context>
socket.on('assertSessions', async (jids, force, callback) => {
try {
- const response = await baileys_sock.assertSessions(jids, force);
+ const response = await baileys_sock.assertSessions(jids);
callback(response);
</code_context>
<issue_to_address>
**question (bug_risk):** The removal of the 'force' argument may affect voice call session assertions.
Verify that removing the 'force' parameter does not break any session assertion scenarios.
</issue_to_address>
### Comment 3
<location> `src/api/integrations/channel/whatsapp/whatsapp.baileys.service.ts:4560-4562` </location>
<code_context>
const response = await this.client.assertSessions(jids);
return response;
</code_context>
<issue_to_address>
**suggestion (code-quality):** Inline variable that is immediately returned ([`inline-immediately-returned-variable`](https://docs.sourcery.ai/Reference/Rules-and-In-Line-Suggestions/TypeScript/Default-Rules/inline-immediately-returned-variable))
```suggestion
return await this.client.assertSessions(jids);
```
<br/><details><summary>Explanation</summary>Something that we often see in people's code is assigning to a result variable
and then immediately returning it.
Returning the result directly shortens the code and removes an unnecessary
variable, reducing the mental load of reading the function.
Where intermediate variables can be useful is if they then get used as a
parameter or a condition, and the name can act like a comment on what the
variable represents. In the case where you're returning it from a function, the
function name is there to tell you what the result is, so the variable name
is unnecessary.
</details>
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| : numberJid.includes('@lid') | ||
| ? numberJid.split('@')[1] | ||
| : undefined; | ||
| const lid = numberJid.includes('@lid') ? numberJid.split('@')[1] : undefined; |
There was a problem hiding this comment.
question: The new lid extraction logic may not handle all edge cases.
The new logic may miss cases where numberVerified.lid is set but numberJid lacks '@lid'. Please review if this could impact functionality.
| socket.on('assertSessions', async (jids, force, callback) => { | ||
| try { | ||
| const response = await baileys_sock.assertSessions(jids, force); | ||
| const response = await baileys_sock.assertSessions(jids); |
There was a problem hiding this comment.
question (bug_risk): The removal of the 'force' argument may affect voice call session assertions.
Verify that removing the 'force' parameter does not break any session assertion scenarios.
Comment on lines
+4560
to
4562
| const response = await this.client.assertSessions(jids); | ||
|
|
||
| return response; |
There was a problem hiding this comment.
suggestion (code-quality): Inline variable that is immediately returned (inline-immediately-returned-variable)
Suggested change
| const response = await this.client.assertSessions(jids); | |
| return response; | |
| return await this.client.assertSessions(jids); | |
Explanation
Something that we often see in people's code is assigning to a result variableand then immediately returning it.
Returning the result directly shortens the code and removes an unnecessary
variable, reducing the mental load of reading the function.
Where intermediate variables can be useful is if they then get used as a
parameter or a condition, and the name can act like a comment on what the
variable represents. In the case where you're returning it from a function, the
function name is there to tell you what the result is, so the variable name
is unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Description
🔗 Related Issue
Closes #(issue_number)
🧪 Type of Change
🧪 Testing
📸 Screenshots (if applicable)
✅ Checklist
📝 Additional Notes
Summary by Sourcery
Refactor middleware and service logic in main and WhatsApp Baileys integration, remove unused parameters, and revert version to 2.3.2
Enhancements:
Chores: