Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German and better English localization for keybinds #489

Merged
merged 5 commits into from
Aug 22, 2022

Conversation

Kalobi
Copy link
Member

@Kalobi Kalobi commented Jul 30, 2022

This clarifies what the mountain camera controls are for and localizes keybindings in German. Feedback from other German speakers is appreciated. This partially addresses #484 . Once #488 is merged, I plan to also add subheaders to the keybindings menu that will be able to further clarify.

@Kalobi Kalobi marked this pull request as draft August 5, 2022 01:59
@Kalobi
Copy link
Member Author

Kalobi commented Aug 8, 2022

Subheaders have been added and localized in German. The mountain camera keybinds have been reverted to only contain "Camera" since the subheader now explains the context.

@Kalobi Kalobi marked this pull request as ready for review August 8, 2022 23:25
@bigkahuna443 bigkahuna443 merged commit 071dc36 into EverestAPI:dev Aug 22, 2022
@Kalobi Kalobi deleted the keybindlocalization branch August 24, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants