Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attribute to use subheaders in mod menus #488

Merged
merged 3 commits into from
Aug 3, 2022

Conversation

Kalobi
Copy link
Member

@Kalobi Kalobi commented Jul 30, 2022

This PR adds a SettingSubHeaderAttribute that can be used on a setting to add a subheader before that setting. When used for settings that appear in the main mod options menu, it will omit the padding before the subheader to prevent confusion with separate mod sections. For controls, it maintains the padding, since controls form their own submenu.
Sample images:
image
image

Copy link
Member

@coloursofnoise coloursofnoise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, although it makes me realize how many different ways we have to make "SubMenus" now 😅

This will also need to be added to the wiki page once merged, which is also still missing #325.

Copy link
Contributor

@bigkahuna443 bigkahuna443 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it out, looks good to me too! Surprised this wasn't added yet, pretty natural way to break up some of the bigger mod menus

@bigkahuna443 bigkahuna443 merged commit 33858b9 into EverestAPI:dev Aug 3, 2022
@Kalobi Kalobi deleted the subheaderattribute branch August 3, 2022 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants