Double Reconnect Test #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
thanks for adding the tests @Badunk |
|
This fixes #57 |
|
@aslakhellesoy any chance this can be reviewed? |
|
I ran into this as well. I'd love to see it merged. @aslakhellesoy any particular reason to hold this up? |
|
Got time to review this, @rexxars? Can't speak to the test implementation, but the fix itself has been valuable enough that I've had to run philstrong's fork. |
|
On Easter holidays at the moment, promise I'll look at this as soon as I get back! |
joeybaker
approved these changes
Apr 11, 2017
tricknotes
added a commit
to tricknotes/hubot-idobata
that referenced
this pull request
May 28, 2017
EventSource/eventsource#61 is merged and released as a new version of eventsource.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a PR with both @philstrong work and my test to expose the bug.
The test's approach is for the server to disconnect the first connection immediately. Subsequent connections are allowed to sit around. You would expect 2 connections (1 initial, 1 retry) within the timeframe of the test, however there are actually 3 that are made (2 retries).
The test might not be to your liking as it waits 1500 seconds before succeeding. This threshold basically has to exceed the 1,000 of the
reconnectIntervalso that the client may issue a 2nd (and 3rd) reconnect.