Fix multi connects

[philstrong]

No description provided.

[philstrong]

Testing ongoing. Please wait for feedback on whether this solves our issue

[philstrong]

So this isn't going to work due to the fact that if the connection doesn't happen on first attempt it simply does not work. We're removing the req.on('error', onConnectionClosed); as well.

I'm going to selectively remove end and close.

[aslakhellesoy]

The tests control both the server and the client, so whatever situation you've run into it should be reproducible with a test.

I'm afraid I won't accept pull requests without tests.

[philstrong]

Yeah I get it. See what I can do

[rrapant]

@philstrong I think a test that has the server return a redirect (307) will prove this out.

[aslakhellesoy]

I'll close this PR soon unless someone adds tests for it

[anacronw]

I'm running into the same issue. Basically, when the server drops the socket, both "close" and "event" fire. Since onConnectionClosed handler also does a connect, you double the number of connections.

Subsequently, when both connections are closed, that gets doubled again (4 connects) and so forth 2^x

[anacronw]

Please look at my PR #61 for a test that exposes the bug

[philstrong]

closed in favor of #61