Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove border conflicts with bg's, update Sass vars hex values #71

Merged
merged 4 commits into from
Jun 25, 2021
Merged

feat: Remove border conflicts with bg's, update Sass vars hex values #71

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8e7cca7
Remove border conflicts with bg's, update Sass vars hex values (#68)
caripizza Jun 3, 2021
e8d0ed6
update the source TS file
caripizza Jun 3, 2021
ebedf0f
update package-lock.json to current version
caripizza Jun 3, 2021
a15b9c9
add the updated CSS var values to CHANGELOG
caripizza Jun 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove border conflicts with bg's, update Sass vars hex values (#68)
  • Loading branch information
@caripizza
caripizza committed Jun 3, 2021
commit 8e7cca7507ee4a326661cf3e8462522b0c74cb53
11 changes: 11 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,17 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## 6.0.1 - 2021-06-03

#### SASS variable updates

- :warning: `$ui-border-2-light` is now `#d4d4d4` (`$blk-040`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe note the changes to the resulting css vars if there are any that are updated as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Should I bump the patch version on package-lock/package.json too (6.0.1), or is that done during release?

- :warning: `$ui-border-3-light` is now `#dfdfdf` (`$blk-030`)
- :warning: `$ui-border-1-dark` is now `#555555` (`$blk-160`)
- :warning: `$ui-border-2-dark` is now `#4a4a4a` (`$blk-170`)
- :warning: `$ui-border-3-dark` is now `#404040` (`$blk-180`)


## 6.0.0 - 2021-01-28
### Breaking Changes

Expand Down
10 changes: 5 additions & 5 deletions dist/colors.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,8 +488,8 @@ $ui-text-3-light: #6a6a6a;
$ui-text-inverse-light: #FFFFFF;
$ui-text-link-light: #00619b;
$ui-border-1-light: #cacaca;
$ui-border-2-light: #dfdfdf;
$ui-border-3-light: #eaeaea;
$ui-border-2-light: #d4d4d4;
$ui-border-3-light: #dfdfdf;
$ui-border-input-light: #949494;
$ui-info-light: #00619b;
$ui-success-light: #35ac46;
Expand Down Expand Up @@ -534,9 +534,9 @@ $ui-text-2-dark: #bfbfbf;
$ui-text-3-dark: #9f9f9f;
$ui-text-inverse-dark: #151515;
$ui-text-link-dark: #00A0FF;
$ui-border-1-dark: #4a4a4a;
$ui-border-2-dark: #404040;
$ui-border-3-dark: #353535;
$ui-border-1-dark: #555555;
$ui-border-2-dark: #4a4a4a;
$ui-border-3-dark: #404040;
$ui-border-input-dark: #757575;
$ui-info-dark: #00A0FF;
$ui-success-dark: #36DA43;
Expand Down