feat: Remove border conflicts with bg's, update Sass vars hex values #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| #### SASS variable updates | ||
|
|
||
| - :warning: `$ui-border-2-light` is now `#d4d4d4` (`$blk-040`) |
There was a problem hiding this comment.
maybe note the changes to the resulting css vars if there are any that are updated as well
There was a problem hiding this comment.
Done! Should I bump the patch version on package-lock/package.json too (6.0.1), or is that done during release?
paulcpederson
approved these changes
Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #68
Summary:
This pr updates the following Sass var values for light/dark theme borders:
(I tested these changes via
npm linkwith my local cc clone, and they looked good to me/no major changes that I could see.)Note: I wasn't sure if I should bump the patch version in package-lock/package.json. I can add that if that'd be helpful for release.