Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix compatible field serializer binary search bugs #539

Closed
wants to merge 1 commit into from
Closed

fix compatible field serializer binary search bugs #539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ public T read (Kryo kryo, Input input, Class<T> type) {
// binary search for schemaName
int low, mid, high;
int compare;
int maxFieldLength = allFields.length > length ? allFields.length : length;
int maxFieldLength = allFields.length;
outerBinarySearch:
for (int i = 0; i < length; i++) {
String schemaName = names[i];
Expand Down
3 changes: 3 additions & 0 deletions test/com/esotericsoftware/kryo/CompatibleFieldSerializerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,12 +176,15 @@ public void testRemovedFieldFromClassWithManyFields () throws FileNotFoundExcept

CompatibleFieldSerializer serializer = new CompatibleFieldSerializer(kryo, ClassWithManyFields.class);
serializer.removeField("bAdd");
serializer.removeField("zz");
kryo.register(ClassWithManyFields.class, serializer);
Object object2 = kryo.readClassAndObject(input);
assertTrue(object2 instanceof ClassWithManyFields);
assertNull("the bAdd field should be null", ((ClassWithManyFields) object2).bAdd);
assertNull("the zz field should be null", ((ClassWithManyFields) object2).zz);
// update the field in order to verify the remainder of the object was deserialized correctly
((ClassWithManyFields) object2).bAdd = object1.bAdd;
((ClassWithManyFields) object2).zz = object1.zz;
assertEquals(object1, object2);
}

Expand Down