fix compatible field serializer binary search bugs #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Can you describe in greater detail in which case/scenario an unexpected effect is triggered? |
|
This unexpected effect is triggered when binary search is used on object with more than 32 fields. And the case I have already added into the unit test. Just a little mistake in Kryo's binary search algorithm~ |
|
Just a glance of the code in CompatibleFieldSerializer.java and you'll know what i'm talking about. With this bug, Kryo losts its backward compatibilty when removing fields in objects with more than 32 fields. |
|
This is a fairly major bug, is there a reason why there is no bug report for it, nor has this pull request been added to any release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix deserializing bugs using CompatibleFieldSerializer with object which can trigger binary search. Just set the max boundary of binary search to the length of target array. I also update the unit test for this situation.